845660 - [Call] Proximity sensor shouldn't work on speaker/BT SCO mode in call.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect, P2)

Description

[leo.bugzilla.gecko]

Even though the speaker mode is ON during a call, proximity sensor still works.
Proximity sensor should not be worked in the speaker or bluetooth mode.

Thanks in advance

Comment 2

[Leo]

needinfo? UX to confirm that proximity sensor is supposed to work during phone call when the speaker mode is on or bluetooth mode is on.

Comment 4

[Kai-Chih Hu [:khu]]

Josh, do you have any comments on this one? We need your input. 
Thanks!

Comment 5

[Dietrich Ayala (:dietrich)]

This is broken. The phone is not bumping against your face when in speaker mode (the point of that feature is that the phone is *not* against your face), and then when you try to interact with the phone in-call, the screen will go dark. Blocking+.

Comment 6

[Marco Chen [:mchen]]

Currently, we implemented the detection of closing face by proximity sensor on system app (screen_manager.js). So if we want to know the timing of enabling speaker mode, we need a specific Web API to know this. But currently there is no Web API can be used to register a callback or listen the event. (There is just a attribute for reading/writing - nsIDOMTelephony::speakerEnabled)

So we need a way to know the timing of speakerEnabled. 

Hi Hsin-Yi,

Am I right of there is no way to know the timing of speakerEnabled from Gaia?

Thanks

Comment 7

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Marco, sorry for the late reply. As you mentioned, current API only provides an attribute to set/get the speaker state, but no events are fired when the state changes.

Comment 8

[Marco Chen [:mchen]]

Attachment: Patch v1

Before calling turnScreenOff(), if SCO or speaker is enabled then just to skip it.

Thanks for the review.

Comment 9

[Marco Chen [:mchen]]

https://github.com/mozilla-b2g/gaia/pull/9134

Comment 10

[Marco Chen [:mchen]]

https://github.com/mozilla-b2g/gaia/pull/9181

Comment 11

[Tim Guan-tin Chien [:timdream] (please needinfo)]

https://github.com/mozilla-b2g/gaia/commit/70c13d2f583c6578037b0b65c47cd55f2ce1ce1c

Comment 12

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted 845660 to:
v1-train: 33581942ead5d424b7626c6197c33392948019c8

Comment 13

[Jason Smith [:jsmith]]

Haven't fixed the queries yet, so I'm using qawanted for now. Someone needs to see if this bug also reproduces on v1.01.

Comment 14

[Jason Smith [:jsmith]]

mlevin tested this and indicates that v1.01 in unaffected here.

Comment 15

[mlevin]

(In reply to Jason Smith [:jsmith] from comment #14)
> mlevin tested this and indicates that v1.01 in unaffected here.

Tested on the following:
Inari Build ID: 20130418070206
Kernel Date: Feb 21
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/0c76ef5f8677
Gaia: 64d5096e1746bd4b08bc1bf69844d164ac961970

Call screen stays active during an active call when placed near the ear. 
Tested both speaker mode, and bluetooth mode.

NOTE: Also tested an active call in normal (speaker and bluetooth off) mode. Call screen still stayed active when Inari was placed near the ear!

Comment 16

[Marco Chen [:mchen]]

(In reply to mlevin from comment #15)
> (In reply to Jason Smith [:jsmith] from comment #14)
> > mlevin tested this and indicates that v1.01 in unaffected here.
> NOTE: Also tested an active call in normal (speaker and bluetooth off) mode.
> Call screen still stayed active when Inari was placed near the ear!

Hi mlevin,

Could you make sure that your device have a calibration file for proximity sensor or it doesn't work?

Please check whether the file as below is exist or not in your device.

 /data/misc/prox/prox_threshold.txt

Thanks.

Comment 17

[mlevin]

(In reply to Marco Chen [:mchen] from comment #16)
> (In reply to mlevin from comment #15)
> > (In reply to Jason Smith [:jsmith] from comment #14)
> > > mlevin tested this and indicates that v1.01 in unaffected here.
> > NOTE: Also tested an active call in normal (speaker and bluetooth off) mode.
> > Call screen still stayed active when Inari was placed near the ear!
> 
> Hi mlevin,
> 
> Could you make sure that your device have a calibration file for proximity
> sensor or it doesn't work?
> 
> Please check whether the file as below is exist or not in your device.
> 
>  /data/misc/prox/prox_threshold.txt
> 
> Thanks.

Marco,

I checked 3 of our Inari devices using DDMS-ACT (Eclipse) and under file explorer I did not see this file within the prox folder. In fact there were no files under this folder.

Comment 18

[Marco Chen [:mchen]]

(In reply to mlevin from comment #17)
> Marco,
> 
> I checked 3 of our Inari devices using DDMS-ACT (Eclipse) and under file
> explorer I did not see this file within the prox folder. In fact there were
> no files under this folder.

If you did the replace of userdata.img into your inari device then the calibration file will be gone. Please refer to the same case on Bug 857484.

You can get calibration file from
  1. inari/unagi with Android OS.
  2. Ikura with Firefox OS provided by OEM partner (bug 857484) and ask OEM partner about how to perform calibration app.

If you still can't get calibration file, please let me know. I will try to figure out whether that file can be sent to you from me.

Comment 19

[mlevin]

(In reply to Marco Chen [:mchen] from comment #18)
> (In reply to mlevin from comment #17)
> > Marco,
> > 
> > I checked 3 of our Inari devices using DDMS-ACT (Eclipse) and under file
> > explorer I did not see this file within the prox folder. In fact there were
> > no files under this folder.
> 
> If you did the replace of userdata.img into your inari device then the
> calibration file will be gone. Please refer to the same case on Bug 857484.
> 
> You can get calibration file from
>   1. inari/unagi with Android OS.
>   2. Ikura with Firefox OS provided by OEM partner (bug 857484) and ask OEM
> partner about how to perform calibration app.
> 
> If you still can't get calibration file, please let me know. I will try to
> figure out whether that file can be sent to you from me.

Marco,

Still cannot get the file.

1. Can you send?
2. Why is not there after our daily flash updates?
3. How do I install it once I receive it from you?

Thanks,
Matt.

Comment 20

[Marco Chen [:mchen]]

> 1. Can you send?
I need to check whether there is any legal issue prevent Mozilla send this file to you first. If there is no any legal concern I can send to you.

> 2. Why is not there after our daily flash updates?
That file is under userdata partition and our FOTA doesn't update that partition.

3. How do I install it once I receive it from you?
You just put file into /data/misc/prox/prox_threshold.txt.