846220 - [OPEN_][Gallery]Two images are overlayed in edit mode.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Gallery, defect)

Description

[Firefox_Mozilla]

Attachment: Gallery edit mode

Steps to reproduce:
1.Go into Gallery and select a big image to view;
2.Go into edit mode and press the power key;
3.press the power key again to wake up the screen;
4.tap camera key in lock screen;
5.switch to Gallery in camera interface;
6.select another small image to view;
7.Go into edit mode;
Expected results:
1.it is shown normal in edit mode;
Actual results:
1.the big image also in the lower lay. Two images are overlay in edit mode.

Comment 1

[Kai-Chih Hu [:khu]]

It looks like a serious problem in Gallery.

Comment 2

[Michael Vines [:m1] [:evilmachines]]

What build was used to reproduce this issue?

Comment 3

[Michael Vines [:m1] [:evilmachines]]

(moving shira+ -> tef+ to simplify tracking)

Comment 4

[William Hsu [:whsu]]

Hi, all,

I have double confirmed this case.
The build: 20130218070201 (Can reproduce)
The latest build: 20130304230203 (Can reproduce, please see attachment)
Thanks!

Comment 5

[William Hsu [:whsu]]

Attachment: Overlapped image

Comment 6

[David Flanagan [:djf]]

Nice catch. I can reproduce this. It isn't necessary to return to the lockscreen. You can also just go to the homescreen, open camera and switch to gallery that way.

So this is related to how we handle the 'browse' activity.  And it should be an easy fix.

I wonder what the right thing (from a UX standpoint) is to do here: abandon the edit in progress and show the user the list of thumbnails, since they're coming from the camera and probably want to see that.  Or just return the the app where they left it in the middle of an edit?

Casey: sorry to keep needinfo'ing you on these last minute bugs, but I'd like your advice on how to handle this.

Comment 7

[David Flanagan [:djf]]

Attachment: link to patch on github

Even though I haven't heard from Casey yet, I've decided that allowing the user to lose work (an in progress edit or in-progress selection) isn't good.  So this patch modifies how we handle the browse activity.  Previously we always reverted to displaying the thumbnail list.  Now we only do that if the user was just viewing a photo. If they were editing or selecting, we just open the gallery where they left it.

Comment 8

[Jon Hylands [:jhylands]]

Comment on attachment 721417 [details]
link to patch on github

Looks good, tested it and it works.

Comment 9

[David Flanagan [:djf]]

Merged into master: https://github.com/mozilla-b2g/gaia/commit/28276e469cb7f9ee8abdb09fe84189bb9898f2f7

Cancelling the needinfo request for Casey because I think I've finessed the situation sufficiently. When opened from the camera, we go to thumbnail mode if we were displaying a single photo, and only remain out of thumbnail mode if the user had left the gallery in edit mode or select mode.  That is unlikely to happen very often, and I think it is an adequate solution.

Comment 10

[David Flanagan [:djf]]

Closing

Comment 11

[John Ford [:jhford] CET/CEST Berlin Time]

v1-train: 7359be50cc60e737d44ea0d0c0dff29fc2a1a95d
v1.0.1: 364f2074b7df0e9c1442a269d16a57331dacab0d

Comment 12

[Natalya Kot [:nkot]]

same issue was described in bug #845544

Comment 13

[Julien Wajsberg [:julienw]]

John,

we need to backout this from v1-train and v1.0.1 because this bug depends on Bug 841251 which is not uplifted yet. Could you please do that ?

Comment 14

[Julien Wajsberg [:julienw]]

This is what produced Bug 849290.

Comment 15

[John Ford [:jhford] CET/CEST Berlin Time]

backouts:

v1-train: 9d7b1ffaa3478a7ebc66c0aa82c360b58495cd71
v1.0.1: 46c13bcd9cf8c4ac5853bd0f3a1ce846303b011e

Comment 16

[John Ford [:jhford] CET/CEST Berlin Time]

v1-train: 788e786fc12b7fd8c1ae011160ba870cc2ee8576
v1.0.1: 8e73a77836d5b8a251441fe9e6b3864e37b073d9

Comment 17

[Natalya Kot [:nkot]]

The issue no longer appears to be occurring on an Unagi device running the following build:

Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/af9270e8f205
Gaia: a78ebf426840b5ef08c0cc3e437ad30aba3e2528
Build: 20130318070202

User is now prompted to close edit mode in order to be able browsing gallery

Verifying as fixed.