846255 - Work - Provide relevant HTTPS manual update links in Firefox for Metro

Status: RESOLVED FIXED

(Firefox for Metro Graveyard :: General, defect)

Description

[Frank Yan (:fryn)]

We currently have some mobile pages that aren't relevant to Firefox for Metro as the manual update urls in about:config.
The two pref names are:
app.update.url.manual
app.update.url.details

If you look through the discussion in bug 841221, it looks like the relevant URL is something like https://www.mozilla.org/%LOCALE%/%APP%/update/ which resolves to https://www.mozilla.org/en-US/firefox/update/ in desktop Firefox.
Does %APP% also resolve to Firefox in Firefox for Metro?
If so, the patch that I attached probably does the job.

Comment 1

[Frank Yan (:fryn)]

I don't think we have manual update UI yet in Firefox for Metro, so I guess those URLs aren't being used yet. Perhaps, this bug won't be relevant until later.

Comment 2

[Frank Yan (:fryn)]

Attachment: patch

Comment 3

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

(In reply to Frank Yan (:fryn) from comment #0)
> We currently have some mobile pages that aren't relevant to Firefox for
> Metro as the manual update urls in about:config.
> The two pref names are:
> app.update.url.manual
> app.update.url.details
> 
> If you look through the discussion in bug 841221, it looks like the relevant
> URL is something like https://www.mozilla.org/%LOCALE%/%APP%/update/ which
> resolves to https://www.mozilla.org/en-US/firefox/update/ in desktop Firefox.
> Does %APP% also resolve to Firefox in Firefox for Metro?
> If so, the patch that I attached probably does the job.

%APP% resolves to "metrofirefox" in Immersive/Metro Firefox.  However, we will soon be redirecting https://www.mozilla.org/%LOCALE%/metrofirefox/* to https://www.mozilla.org/%LOCALE%/firefox/*.  See bug 845983

Comment 4

[Asa Dotzler [:asa]]

Yeah. This blocks Bug 833182 - Story - Updating Firefox.

Comment 5

[Frank Yan (:fryn)]

Attachment: patch not blocked by bug 845983

I don't like leaving this open waiting for its dependency by another team, so here's a patch that just hardcodes "firefox" instead of %APP%. If/when the dependency (bug 845983) gets fixed, I'll get notified of it via bugmail, and I can make a patch to use %APP%.

Also, even if the redirect gets put in place, I don't think that we really need to use %APP%. It's even hard-coded as "firefox" in some places on desktop, e.g.

browser/app/profile/firefox.js:
pref("browser.geolocation.warning.infoURL", "http://www.mozilla.com/%LOCALE%/firefox/geolocation/");
pref("browser.mixedcontent.warning.infoURL", "http://support.mozilla.org/1/%APP%/%VERSION%/%OS%/%LOCALE%/mixed-content/");

Comment 6

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

(In reply to Frank Yan (:fryn) from comment #5)
[...]
> Also, even if the redirect gets put in place, I don't think that we really
> need to use %APP%. It's even hard-coded as "firefox" in some places on
> desktop, e.g.

If we care about server-side logging that tells us roughly how many desktop Firefox users are hitting these pages vs how many Immersive/Metro Firefox users are hitting them, we'll want to use %APP%.  Also if we ever want metro-specific content, we might care that the URLs are built using 'metrofirefox' instead of 'firefox'

Comment 7

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

Of course, I don't know how much we actually care about these things.  In the short term it probably makes the most sense to just use 'firefox' but maybe to revisit before we go to aurora.

Comment 8

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/d3d9a1552a4d