Closed Bug 846255 Opened 8 years ago Closed 8 years ago

Work - Provide relevant HTTPS manual update links in Firefox for Metro

Categories

(Firefox for Metro Graveyard :: General, defect)

All
Windows 8.1
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 22

People

(Reporter: fryn, Assigned: fryn)

References

Details

(Whiteboard: feature=work)

Attachments

(1 file, 1 obsolete file)

We currently have some mobile pages that aren't relevant to Firefox for Metro as the manual update urls in about:config.
The two pref names are:
app.update.url.manual
app.update.url.details

If you look through the discussion in bug 841221, it looks like the relevant URL is something like https://www.mozilla.org/%LOCALE%/%APP%/update/ which resolves to https://www.mozilla.org/en-US/firefox/update/ in desktop Firefox.
Does %APP% also resolve to Firefox in Firefox for Metro?
If so, the patch that I attached probably does the job.
See Also: → 841221
I don't think we have manual update UI yet in Firefox for Metro, so I guess those URLs aren't being used yet. Perhaps, this bug won't be relevant until later.
Attached patch patch (obsolete) — Splinter Review
(In reply to Frank Yan (:fryn) from comment #0)
> We currently have some mobile pages that aren't relevant to Firefox for
> Metro as the manual update urls in about:config.
> The two pref names are:
> app.update.url.manual
> app.update.url.details
> 
> If you look through the discussion in bug 841221, it looks like the relevant
> URL is something like https://www.mozilla.org/%LOCALE%/%APP%/update/ which
> resolves to https://www.mozilla.org/en-US/firefox/update/ in desktop Firefox.
> Does %APP% also resolve to Firefox in Firefox for Metro?
> If so, the patch that I attached probably does the job.

%APP% resolves to "metrofirefox" in Immersive/Metro Firefox.  However, we will soon be redirecting https://www.mozilla.org/%LOCALE%/metrofirefox/* to https://www.mozilla.org/%LOCALE%/firefox/*.  See bug 845983
Depends on: 845983
Whiteboard: p=1
Flags: needinfo?(asa)
Yeah. This blocks Bug 833182 - Story - Updating Firefox.
Blocks: 833182
No longer blocks: metrov1triage
Flags: needinfo?(asa)
Summary: Provide relevant HTTPS manual update links in Firefox for Metro → Work - Provide relevant HTTPS manual update links in Firefox for Metro
I don't like leaving this open waiting for its dependency by another team, so here's a patch that just hardcodes "firefox" instead of %APP%. If/when the dependency (bug 845983) gets fixed, I'll get notified of it via bugmail, and I can make a patch to use %APP%.

Also, even if the redirect gets put in place, I don't think that we really need to use %APP%. It's even hard-coded as "firefox" in some places on desktop, e.g.

browser/app/profile/firefox.js:
pref("browser.geolocation.warning.infoURL", "http://www.mozilla.com/%LOCALE%/firefox/geolocation/");
pref("browser.mixedcontent.warning.infoURL", "http://support.mozilla.org/1/%APP%/%VERSION%/%OS%/%LOCALE%/mixed-content/");
Assignee: nobody → fyan
Attachment #719432 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #724150 - Flags: review?(mbrubeck)
Whiteboard: p=1 → feature=work
(In reply to Frank Yan (:fryn) from comment #5)
[...]
> Also, even if the redirect gets put in place, I don't think that we really
> need to use %APP%. It's even hard-coded as "firefox" in some places on
> desktop, e.g.

If we care about server-side logging that tells us roughly how many desktop Firefox users are hitting these pages vs how many Immersive/Metro Firefox users are hitting them, we'll want to use %APP%.  Also if we ever want metro-specific content, we might care that the URLs are built using 'metrofirefox' instead of 'firefox'
Of course, I don't know how much we actually care about these things.  In the short term it probably makes the most sense to just use 'firefox' but maybe to revisit before we go to aurora.
Attachment #724150 - Flags: review?(mbrubeck) → review+
https://hg.mozilla.org/mozilla-central/rev/d3d9a1552a4d
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 22
OS: Windows 8 Metro → Windows 8.1
You need to log in before you can comment on or make changes to this bug.