Image blocking doesn't block background image

RESOLVED FIXED in mozilla0.9.9

Status

()

P3
normal
RESOLVED FIXED
18 years ago
17 years ago

People

(Reporter: doctor__j, Assigned: pavlov)

Tracking

Trunk
mozilla0.9.9
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: needs r= and sr=)

Attachments

(2 attachments, 1 obsolete attachment)

178 bytes, text/html
Details
fix
4.68 KB, patch
bryner
: review+
Details | Diff | Splinter Review
(Reporter)

Description

18 years ago
From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Win98; en-US; rv:0.9.1+) Gecko/20010607
BuildID:    2001060709

Reproducible: Always
Steps to Reproduce:
1. Go to Pref menu
2. In "Privacy and Security -> Images", select "Do not load any images"
3. Load the testcase.

Actual Results:  Background image is loaded.

Expected Results:  No background image is loaded whatsoever.
(Reporter)

Comment 1

18 years ago
Created attachment 37633 [details]
Testcase
-> Imagelib
Assignee: asa → pavlov
Component: Browser-General → ImageLib
QA Contact: doronr → tpreston

Updated

18 years ago
OS: Windows 98 → All

Comment 3

18 years ago
->morse
Assignee: pavlov → morse
Component: ImageLib → Cookies
QA Contact: tpreston → tever

Comment 4

18 years ago
Actually imagelib is the right component for this.  The cookie module handles 
the permissions for whether or not to load the image, but it is up to imagelib 
to make a call into the cooke module to obtain the permission.  Reassigning back 
to imagelib.
Assignee: morse → pavlov
Component: Cookies → ImageLib
QA Contact: tever → tpreston
(Assignee)

Comment 5

18 years ago
this will be fixed when i remove old imagelib.

Comment 6

18 years ago
adding dep...
Depends on: 78690
Priority: -- → P4
Target Milestone: --- → mozilla0.9.3
(Reporter)

Comment 7

18 years ago
*** Bug 86344 has been marked as a duplicate of this bug. ***

Comment 8

18 years ago
*** Bug 86940 has been marked as a duplicate of this bug. ***

Comment 9

18 years ago
*** Bug 89179 has been marked as a duplicate of this bug. ***

Comment 10

18 years ago
Doesn't look like this is getting fixed before the freeze tomorrow night.
Pushing out a milestone.  Please correct if I'm mistaken.
Target Milestone: mozilla0.9.3 → mozilla0.9.4

Comment 11

18 years ago
*** Bug 94509 has been marked as a duplicate of this bug. ***
(Assignee)

Comment 12

18 years ago
Created attachment 46204 [details] [diff] [review]
fix.
(Assignee)

Updated

18 years ago
Target Milestone: mozilla0.9.4 → mozilla0.9.5

Comment 13

18 years ago
See also bug 97216, Referer is not sent on background image.
(Assignee)

Updated

18 years ago
Status: NEW → ASSIGNED
Keywords: patch

Comment 14

18 years ago
*** Bug 101895 has been marked as a duplicate of this bug. ***
(Assignee)

Comment 15

18 years ago
.
Target Milestone: mozilla0.9.5 → mozilla0.9.6
(Assignee)

Updated

18 years ago
Target Milestone: mozilla0.9.6 → mozilla0.9.8
(Assignee)

Updated

17 years ago
Whiteboard: needs r= and sr=
(Assignee)

Updated

17 years ago
Priority: P4 → P3
I ran into this bug when trying to block the images at this URL:
http://toolbar.netscape.com/tw_hat/iframe/cnn.html
The mail button is actually a background image for the table cell and therefore
still loads.

Comment 17

17 years ago
*** Bug 107312 has been marked as a duplicate of this bug. ***

Comment 18

17 years ago
is the patch still valid?

to reproduce this one:
1. first block all images from ad.ads.dk. View the
http://ad.ads.dk/mediesalg/jobline/140x350hvemtrordu.gif image and block from
this server
2. load http://bugzilla.mozilla.org/attachment.cgi?id=58362&action=view

the background image will show...

build 20020103

(Assignee)

Comment 19

17 years ago
Created attachment 65302 [details] [diff] [review]
fix

updated fix to work with the trunk
Attachment #46204 - Attachment is obsolete: true
(Assignee)

Updated

17 years ago
Target Milestone: mozilla0.9.8 → mozilla0.9.9
Comment on attachment 65302 [details] [diff] [review]
fix

r=bryner
Attachment #65302 - Flags: review+

Comment 21

17 years ago
The patch looks ok, but I'm a little concerned about the performance hit. We 
should keep an eye on the tinderbox numbers. sr=sfraser
Hardware: PC → All
(Assignee)

Comment 22

17 years ago
checked in
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED
I think this new code is causing a crasher in mailnews (and other places.)

see #126033

Comment 24

17 years ago
Verified BuildID: 2002021503 WINNT 4 SP6

BTW. I don't use MailNews

Comment 25

17 years ago
*** Bug 126623 has been marked as a duplicate of this bug. ***

Comment 26

17 years ago
*** Bug 129487 has been marked as a duplicate of this bug. ***
You need to log in before you can comment on or make changes to this bug.