Closed Bug 84654 Opened 23 years ago Closed 23 years ago

Image blocking doesn't block background image

Categories

(Core :: Graphics: ImageLib, defect, P3)

Product:
Core
Component:
Graphics: ImageLib
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla0.9.9

People

(Reporter: doctor__j, Assigned: pavlov)

References

Details

(Whiteboard: needs r= and sr=)

Attachments

(2 files, 1 obsolete file)

Testcase
178 bytes, text/html
Details
fix
4.68 KB, patch
bryner
: review+
Details | Diff | Splinter Review 
From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Win98; en-US; rv:0.9.1+) Gecko/20010607
BuildID:    2001060709

Reproducible: Always
Steps to Reproduce:
1. Go to Pref menu
2. In "Privacy and Security -> Images", select "Do not load any images"
3. Load the testcase.

Actual Results:  Background image is loaded.

Expected Results:  No background image is loaded whatsoever.
Attached file Testcase — 

    
    

    
  
-> Imagelib
Assignee: asa → pavlov
Component: Browser-General → ImageLib
QA Contact: doronr → tpreston

    
  
OS: Windows 98 → All

    
    

    
  
->morse
Assignee: pavlov → morse
Component: ImageLib → Cookies
QA Contact: tpreston → tever

    
    

    
  
Actually imagelib is the right component for this.  The cookie module handles 
the permissions for whether or not to load the image, but it is up to imagelib 
to make a call into the cooke module to obtain the permission.  Reassigning back 
to imagelib.
Assignee: morse → pavlov
Component: Cookies → ImageLib
QA Contact: tever → tpreston

    
    

    
  
this will be fixed when i remove old imagelib.

    
    

    
  
adding dep...
Depends on: 78690
Priority: -- → P4
Target Milestone: --- → mozilla0.9.3

    
    

    
  
*** Bug 86344 has been marked as a duplicate of this bug. ***

    
    

    
  
*** Bug 86940 has been marked as a duplicate of this bug. ***

    
    

    
  
*** Bug 89179 has been marked as a duplicate of this bug. ***

    
    

    
  
Doesn't look like this is getting fixed before the freeze tomorrow night.
Pushing out a milestone.  Please correct if I'm mistaken.

Target Milestone: mozilla0.9.3 → mozilla0.9.4

    
    

    
  
*** Bug 94509 has been marked as a duplicate of this bug. ***

    
    

    
  

      
      
      
      

        Attached patch
          
          
        fix. (obsolete)
        — 
          — Splinter Review
      

    


  

    
  
Target Milestone: mozilla0.9.4 → mozilla0.9.5

    
    

    
  
See also bug 97216, Referer is not sent on background image.

    
  
Status: NEW → ASSIGNED
Keywords: patch

    
    

    
  
*** Bug 101895 has been marked as a duplicate of this bug. ***

    
    

    
  
.
Target Milestone: mozilla0.9.5 → mozilla0.9.6

    
  
Target Milestone: mozilla0.9.6 → mozilla0.9.8

    
  
Whiteboard: needs r= and sr=

    
  
Priority: P4 → P3

    
    

    
  
I ran into this bug when trying to block the images at this URL:
http://toolbar.netscape.com/tw_hat/iframe/cnn.html
The mail button is actually a background image for the table cell and therefore
still loads.

    
    

    
  
*** Bug 107312 has been marked as a duplicate of this bug. ***

    
    

    
  
is the patch still valid?

to reproduce this one:
1. first block all images from ad.ads.dk. View the
http://ad.ads.dk/mediesalg/jobline/140x350hvemtrordu.gif image and block from
this server
2. load http://bugzilla.mozilla.org/attachment.cgi?id=58362&action=view

the background image will show...

build 20020103



    
    

    
  

      
      
      
      

        Attached patch
          
          
        fix
        — 
          — Splinter Review
      

    


  
updated fix to work with the trunk

        Attachment #46204 -
        Attachment is obsolete: true

    
  
Target Milestone: mozilla0.9.8 → mozilla0.9.9

    
    

    
  
Comment on attachment 65302 [details] [diff] [review]
fix

r=bryner

        Attachment #65302 -
        Flags: review+

    
    

    
  
The patch looks ok, but I'm a little concerned about the performance hit. We 
should keep an eye on the tinderbox numbers. sr=sfraser

Hardware: PC → All

    
    

    
  
checked in
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED

    
    

    
  
I think this new code is causing a crasher in mailnews (and other places.)

see #126033

    
    

    
  
Verified BuildID: 2002021503 WINNT 4 SP6

BTW. I don't use MailNews

    
    

    
  
*** Bug 126623 has been marked as a duplicate of this bug. ***

    
    

    
  
*** Bug 129487 has been marked as a duplicate of this bug. ***

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: