Closed Bug 846541 Opened 7 years ago Closed 6 years ago

[B2G] [settings] [keyboard]: Keyboard settings like "Word suggestion,"Auto Correction","Vibration" are disabled by default

Categories

(Firefox OS Graveyard :: Gaia::Settings, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(blocking-b2g:1.3+)

VERIFIED FIXED
blocking-b2g 1.3+

People

(Reporter: pgorantla, Assigned: gioyik)

References

Details

(Whiteboard: permafail, [good first bug][mentor=rudyl][mentor=arthurcc][mentor-lang=zh])

Attachments

(3 files)

Description:
Keyboard "Vibration" and keyboard "word suggestion" should be enable by default and then user have an option of enabling/disabling it 

Repro Steps:
1) Updated to Unagi Build ID: 20130225070200
2) Go to Settings app
3) Click on keyboard under personalization


Expected:
According to the test cases #3376 and  #3367 "Vibration" and "Word suggestion" options should be turned on by default

Actual:
"Vibration" and "word suggestion" are not turned on by default

Repro frequency:
3/3, 100%, on multiple devices

Environmental  Variables:
Kernel Date: Dec 5
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/3a5a27992a75
Gaia: 5691a16fff8e1403c75ed9d6f3a443b7e58198c6


Notes:
Test Suite Name: Settings-Keyboard
UCID: set-098, set-096
Link to failed test case: https://moztrap.mozilla.org/runtests/run/859/env/305/?pagenumber=1&pagesize=20&sortfield=order&sortdirection=asc&filter-id=3376&filter-tag=105&filter-tag=237&filter-suite=191
                                https://moztrap.mozilla.org/runtests/run/859/env/305/?pagenumber=1&pagesize=20&sortfield=order&sortdirection=asc&filter-id=3367&filter-tag=105&filter-tag=237&filter-suite=191

Q Analysts Test Team Priority Levels: Pri 3
Clarify requirements.
Keywords: qawanted
UCID: set-098
As a user, I want keyboard "vibratons" to be turned on by default, so that my phone will automatically vibrate when I type.
Tested on
Gecko  http://hg.mozilla.org/releases/mozilla-b2g18/rev/99680a32f297
Gaia   de3e5b9205e6cb1a6bd0858a98d159272ad96d11
BuildID 20130312070202
Version 18.0

Neither Vibration nor word suggestion were enabled by default, and it was in scope for 1.0 version.  Removing QA wanted
Keywords: qawanted
Depends on: 834182
We disabled both the vibration and word suggestion during Berlin workweek.

Vibration:
  - Bug 827410 - Disable keyboard haptic feedback by default
  - This is a UX call.

Word suggestion:
  - Bug 827393 - Disable word suggestions/predictions by default
  - This one is due to keyboard performance concern, maybe we will re-enable that after the keyboard performance is improved (WIP).
Whiteboard: testrun 5.1 → testrun 5.1, inarirun1
Whiteboard: testrun 5.1, inarirun1 → testrun 5.1, inarirun1, leorun1
Whiteboard: testrun 5.1, inarirun1, leorun1 → testrun 5.1, inarirun1, leorun1, inarirun2
set-096 As a user, I want "word suggestions" to be turned on by default , so that my phone can suggest the correct words when I make mistakes typing

These requirements are still in scope, apparently.  Nomming this.
blocking-b2g: --- → leo?
Flags: needinfo?(firefoxos-ux-bugzilla)
Flagging UX for input here regarding what the right behavior should be given comment #5 and the recent keyboard changes.
Putting qawanted to check if it is enabled by default already in current builds.
Keywords: qawanted
Flagging Josh and/or Casey to test what's on v1 right now. Performance issues with this should be greatly improved. We've also flagged QA.
Flags: needinfo?(kyee)
Flags: needinfo?(jcarpenter)
Flags: needinfo?(firefoxos-ux-bugzilla)
Retested against unagi 1.1 nightly (after uplift of bug 879533):

Gecko  http://hg.mozilla.org/releases/mozilla-b2g18/rev/bb6c9375f53b
Gaia   d85d73e50a82cc665d862a93aa7ab34ec0f861ba
BuildID 20130607070208
Version 18.0

See the screenshot for the default settings after a fresh flash.   Noticed that Vibration is still "off" by default, but word suggest is "On".
if product or UX thinks these settings are fine for 1.1, please mark this resolved.
Issue repros on
Leo Build ID: 20130605070207
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/09dc1ae3b1b5
Gaia: 92a6e36957145cdb2ac8867e5cdba8ecf12308fc
Platform Version: 18.0

and on

Unagi Build ID: 20130607070208
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/bb6c9375f53b
Gaia: d85d73e50a82cc665d862a93aa7ab34ec0f861ba
Platform Version: 18.0

However on Leo and Unagi the word suggestion is now 'On' as noted in Comment 10 and displayed on the attachment.  Although, On the Leo Auto correction is not listed.
Keywords: qawanted
Summary: [B2G] [settings] [keyboard]:Vibration and Word suggestion are not enable by default → [B2G] [settings] [keyboard]: Keyboard settings like "Word suggestion,"Auto Correction","Vibration" are disabled by default
Flags: needinfo?(firefoxos-ux-bugzilla)
Switching Casey to Francis since Casey is out this morning and we need to clear this.
Flags: needinfo?(kyee)
Flags: needinfo?(firefoxos-ux-bugzilla)
(In reply to John Hammink from comment #6)
> set-096 As a user, I want "word suggestions" to be turned on by default , so
> that my phone can suggest the correct words when I make mistakes typing
> 
> These requirements are still in scope, apparently.  Nomming this.

The caveat to that user story is: "...if it works." We need to confirm that the feature works well enough to enable by default. Previous implementations did not, and actually hurt instead of helped. We hope that the improvements made by David and co are strong enough to let us turn this on by default, but need to verify on a build first. Casey and Francis will make that determination.
Flags: needinfo?(jcarpenter)
Whiteboard: testrun 5.1, inarirun1, leorun1, inarirun2 → testrun 5.1, inarirun1, leorun1, inarirun2, leorun3
Assigning to Francis per Josh's comment.
Flags: needinfo?(fdjabri)
removing leorun3 tag... it seems like current default settings are in sync with the TC 

TC: https://moztrap.mozilla.org/runtests/run/1475/env/314/?&pagenumber=1&pagesize=20&sortfield=order&sortdirection=asc&filter-id=3367

UCID: set-096

- "Auto correction" and "Word suggestion" are set to On by default (see screenshot in comment 10)
Whiteboard: testrun 5.1, inarirun1, leorun1, inarirun2, leorun3 → testrun 5.1, inarirun1, leorun1, inarirun2,
Triage - non-blocking as a preference setting, per comment 14 and 15, Francis, can you renom this if the performance is good enough to be set default enabled?
blocking-b2g: leo? → ---
The auto-correct and word suggestion performance has improved dramatically and is fit to be on by default, pending bug #884609. According to comment 16 it seems however that they are now switched on by default, so all is good.

The vibra however isn't functioning well enough, so should be off by default at this time, so leaving this bug un-nominated.
Flags: needinfo?(fdjabri)
Whiteboard: testrun 5.1, inarirun1, leorun1, inarirun2, → testrun 5.1, inarirun1, leorun1, inarirun2,leorun4
Whiteboard: testrun 5.1, inarirun1, leorun1, inarirun2,leorun4 → testrun 5.1, inarirun1, leorun1, inarirun2,leorun4, retest_leorun4
As per Francis's comment I'm also leaving this unnommed.   My suggestion is to disable the referring moztrap case, so also in-moztrap - this one, as it seems they SHOULD be disabled.
Flags: in-moztrap-
test case 3367 has been disabled per comment 19
QA Contact: dsubramanian
Since vibration functionality works properly for me now (tested browser, contacts, and MMS), should we reconsider making it on by default again as stated in test case https://moztrap.mozilla.org/manage/case/3376/ or should the test case be updated?

Environment Variables
Device: Buri 1.2 aurora mozRIL
Gaia:   def8e152db6a317162c03a316f68c409f3af3979
SourceStamp: b955a00f4167
BuildID: 20131002004001
Version: 26.0a2
Whiteboard: testrun 5.1, inarirun1, leorun1, inarirun2,leorun4, retest_leorun4 → testrun 5.1, inarirun1, leorun1, inarirun2,leorun4, retest_leorun4, burirun2
Per Francis earlier, if vibration functionality works as expected (and QA should verify that first), it should be on by default and the bug can be nominated.
I have verified it works and is not on by default. How can one nominate a bug.
Set the Project Flags field to koi? if 1.2 is being targeted. If 1.3 is the target release (and keyboard improvements like this are a UX quality focus area for 1.3), set the Project Flags field to 1.3?. The "?" means "nominated." Then, the bug will have a flag for evaluation during triage. :)
Nominating for 1.3 via your comment.

Thanks for the help Stephany. :)
blocking-b2g: --- → 1.3?
Whiteboard: testrun 5.1, inarirun1, leorun1, inarirun2,leorun4, retest_leorun4, burirun2 → testrun 5.1, inarirun1, leorun1, inarirun2,leorun4, retest_leorun4, burirun2,burirun3
Whiteboard: testrun 5.1, inarirun1, leorun1, inarirun2,leorun4, retest_leorun4, burirun2,burirun3 → permafail
This is a easy fix in build/settings.js
blocking-b2g: 1.3? → 1.3+
Whiteboard: permafail → permafail, [good first bug][mentor=rudyl][mentor=arthurcc]
Whiteboard: permafail, [good first bug][mentor=rudyl][mentor=arthurcc] → permafail, [good first bug][mentor=rudyl][mentor=arthurcc][mentor-lang=zh]
Hello,

I sent a patch for this, please review it and tell me if this is the correct fix for this bug, and the work is well done.

Regards,
Gio
Attached file Github pull request
Attachment #833392 - Flags: review?
Comment on attachment 833392 [details] [review]
Github pull request

Giovanny, thanks for the patch. Your patch is alright and I will merge it.

Please make sure your review?/needinfo?/feedback? flags actually pointed to someone so the bug will not be left unattended.
Attachment #833392 - Flags: review? → review+
QA Contact: dsubramanian
Summary the information.
So, we decide to turn on following functionalities.

'keyboard.vibration': true,
'keyboard.clicksound': true,
'keyboard.autocorrect': true,
'keyboard.wordsuggestion': true,

Verified it.Also, attaching the screenshot.

* Test Build:
 - Gaia:     6415b8b44068596404c10365394544e94edd5ce5
 - Gecko:    http://hg.mozilla.org/mozilla-central/rev/12ea03a70243
 - BuildID   20131211040203
 - Version   29.0a1
Status: RESOLVED → VERIFIED
Assignee: nobody → gioyik
Depends on: 969287
You need to log in before you can comment on or make changes to this bug.