847534 - please update treestatus stage to 41fb79d69f1e362ba008fc32d48255fcbc36e8ff

Status: RESOLVED FIXED

(Infrastructure & Operations Graveyard :: WebOps: Other, task)

Description

[Chris AtLee [:catlee]]

please update treestatus stage to 41fb79d69f1e362ba008fc32d48255fcbc36e8ff (which is the current tip of master right now)

there may be some DB schema upgrades that need to happen as part of this. let's iron these out before pushing to prod.

Comment 1

[Chris Turra [:cturra]]

:catlee - i just pushed origin/master to stage. for the outstanding db schema changes, can you explain what needs to be run? my guess is something with `python manage-db.py`

Comment 2

[Chris AtLee [:catlee]]

yes, you need to run manage-db.py like this:

python manage-db.py version_control --version 1 mysql://user:pass@dbhost/dbname /path/to/treestatus/schema
python manage-db.py upgrade mysql://user:pass@dbhost/dbname /path/to/treestatus/schema

what's the URL for the staging instance?

Comment 3

[Chris Turra [:cturra]]

(In reply to Chris AtLee [:catlee] from comment #2)
> yes, you need to run manage-db.py like this:
> 
> python manage-db.py version_control --version 1
> mysql://user:pass@dbhost/dbname /path/to/treestatus/schema

we're seeing the following traceback:

[[e-mail]1 tree-status]# python manage-db.py version_control --version 1 mysql://treestatus_stage:<REMOVED>@dev-zeus-rw.db.phx1.mozilla.com/treestatus_allizom_org schema
Traceback (most recent call last):
  File "manage-db.py", line 9, in <module>
    main()
  File "/data/genericrhel6-stage/src/treestatus.allizom.org/tree-status/vendor/lib/python/migrate/versioning/shell.py", line 207, in main
    ret = command_func(**kwargs)
  File "<string>", line 2, in version_control
  File "/data/genericrhel6-stage/src/treestatus.allizom.org/tree-status/vendor/lib/python/migrate/versioning/util/__init__.py", line 159, in with_engine
    return f(*a, **kw)
  File "/data/genericrhel6-stage/src/treestatus.allizom.org/tree-status/vendor/lib/python/migrate/versioning/api.py", line 250, in version_control
    ControlledSchema.create(engine, repository, version)
  File "/data/genericrhel6-stage/src/treestatus.allizom.org/tree-status/vendor/lib/python/migrate/versioning/schema.py", line 139, in create
    table = cls._create_table_version(engine, repository, version)
  File "/data/genericrhel6-stage/src/treestatus.allizom.org/tree-status/vendor/lib/python/migrate/versioning/schema.py", line 187, in _create_table_version
    raise exceptions.DatabaseAlreadyControlledError
migrate.exceptions.DatabaseAlreadyControlledError


> what's the URL for the staging instance?

  https://treestatus.allizom.org

Comment 4

[Chris AtLee [:catlee]]

Can you double-check what the audience is set to in who.ini? I'm having problems logging in. It should be treestatus.allizom.org.

Also, can you verify that [e-mail] and [e-mail] are in the users table with is_admin=1 and is_sheriff=1

Comment 5

[Chris Turra [:cturra]]

(In reply to Chris AtLee [:catlee] from comment #4)
> Can you double-check what the audience is set to in who.ini? I'm having
> problems logging in. It should be treestatus.allizom.org.

looks like the who.ini file was overwritten during the last pull from github :( the audiences was set to '127.0.0.1:5000'. i have now updated this to:

  audiences = treestatus.allizom.org


> Also, can you verify that [e-mail] and [e-mail] are in
> the users table with is_admin=1 and is_sheriff=1

mysql> select * from users;
+----+---------------------+----------+------------+
| id | name                | is_admin | is_sheriff |
+----+---------------------+----------+------------+
|  1 | [e-mail]  |        1 |          1 |
|  2 | [e-mail] |        1 |          1 |
+----+---------------------+----------+------------+
2 rows in set (0.02 sec)

Comment 6

[Chris AtLee [:catlee]]

Looks like it's working:
https://treestatus.allizom.org/mozilla-central

Ed, if this looks ok, can we schedule a push to production?

Comment 7

[Ed Morley [:emorley]]

Looks good to me - ready for push :-)

Comment 8

[Chris Turra [:cturra]]

push to production complete.

Comment 9

[Ed Morley [:emorley]]

For posterity, these were the changes pushed:
https://github.com/catlee/treestatus/compare/257a811e8ef1e05e97eda144247b94cb62403015...41fb79d69f1e362ba008fc32d48255fcbc36e8ff

Notably:
* Add "Message of the day" field to trees (click through to the individual tree)
* Make "approval required" orange
* Pre-fill reason in per-tree page

Ryan, Phil: I've migrated most of the MOTDs - which will hopefully reduce the number of times they get overwritten due to forgetting the "save state". In fact, the save/restore state feature is almost redundant now (or at least not worth the tradeoff, given it's a hard UX to solve for changing subsets of trees). Thoughts?