847585 - Paris binding for UIEvent

Status: RESOLVED FIXED

(Core :: DOM: Events, defect)

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

This includes various classes in content/event/src and SVGZoomEvent

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Attachment: uievent

Perhaps other bugs for other UI events.

https://tbpl.mozilla.org/?tree=Try&rev=21c05465a3db

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Attachment: up-to-date

Comment 4

[Peter Van der Beken [:peterv]]

Comment on attachment 722834 [details] [diff] [review]
up-to-date

Review of attachment 722834 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/events/src/nsDOMEvent.h
@@ +95,5 @@
>                                  JSContext* aCx, jsval* aVal);
>  
>    void InitPresContextData(nsPresContext* aPresContext);
>  
> +  bool Init(mozilla::dom::EventTarget* aGlobal);

Add a comment that this returns if the event should be trusted.

::: content/events/src/nsDOMUIEvent.h
@@ +93,5 @@
> +                                                    mozilla::ErrorResult& aRv);
> +
> +  virtual JSObject* WrapObject(JSContext* aCx, JSObject* aScope, bool* aTriedToWrap)
> +  {
> +    return mozilla::dom::UIEventBinding::Wrap(aCx, aScope, this, aTriedToWrap);

Note: the aTriedToWrap argument was removed in bug 848339.

::: dom/webidl/UIEvent.webidl
@@ +1,4 @@
> +/* -*- Mode: IDL; tab-width: 2; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
> +/* This Source Code Form is subject to the terms of the Mozilla Public
> + * License, v. 2.0. If a copy of the MPL was not distributed with this
> + * file, You can obtain one at http://mozilla.org/MPL/2.0/. 

Trailing whitespace.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Attachment: patch

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e8e539fc6d56

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/e8e539fc6d56

Comment 8

[Masatoshi Kimura [:emk]]

> > +  virtual JSObject* WrapObject(JSContext* aCx, JSObject* aScope, bool* aTriedToWrap)
> > +  {
> > +    return mozilla::dom::UIEventBinding::Wrap(aCx, aScope, this, aTriedToWrap);
> 
> Note: the aTriedToWrap argument was removed in bug 848339.

The compiler would have caught this if MOZ_OVERRIDE was used.

Comment 9

[Olli Pettay [:smaug][[e-mail]]]

compiler caught it even without MOZ_OVERRIDE