847589 - Paris binding for AnimationEvent

Status: RESOLVED FIXED

(Core :: DOM: Events, defect)

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Attachment: patch

https://tbpl.mozilla.org/?tree=Try&rev=47d6748852ed

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 721388 [details] [diff] [review]
patch

Bug 848293 is a followup.

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 721388 [details] [diff] [review]
patch

Review of attachment 721388 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/events/src/nsDOMAnimationEvent.h
@@ +27,5 @@
>  
> +  virtual JSObject* WrapObject(JSContext* aCx, JSObject* aScope,
> +                               bool* aTriedToWrap)
> +  {
> +    return mozilla::dom::AnimationEventBinding::Wrap(aCx, aScope, this,

I'd prefer moving this into the .cpp, and not including *Binding.h in the header.

@@ +30,5 @@
> +  {
> +    return mozilla::dom::AnimationEventBinding::Wrap(aCx, aScope, this,
> +                                                     aTriedToWrap);
> +  }
> +

Please add a comment that you're using the XPCOM GetAnimationName.

@@ +33,5 @@
> +  }
> +
> +  float ElapsedTime()
> +  {
> +    return AnimationEvent()->elapsedTime;

Make XPCOM GetElapsedTime call this to make sure they don't get out of sync.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

(In reply to :Ms2ger from comment #3)

> ::: content/events/src/nsDOMAnimationEvent.h
> @@ +27,5 @@
> >  
> > +  virtual JSObject* WrapObject(JSContext* aCx, JSObject* aScope,
> > +                               bool* aTriedToWrap)
> > +  {
> > +    return mozilla::dom::AnimationEventBinding::Wrap(aCx, aScope, this,
> 
> I'd prefer moving this into the .cpp, and not including *Binding.h in the
> header.
Why exactly. Especially once we have ctor support, including Binding.h just makes the code a tiny bit simpler.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

The header for this kind of event classes is inherited only by the .cpp file and *Binding.cpp so
it really shouldn't matter whether #include is in .h, and having it in .h is just simpler.

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

Attachment: v2

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

Attachment: patch

Comment 8

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 723114 [details] [diff] [review]
patch

Review of attachment 723114 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/events/src/nsDOMAnimationEvent.h
@@ +28,5 @@
> +  virtual JSObject* WrapObject(JSContext* aCx, JSObject* aScope,
> +                               bool* aTriedToWrap)
> +  {
> +    return mozilla::dom::AnimationEventBinding::Wrap(aCx, aScope, this,
> +                                                     aTriedToWrap);

aTriedToWrap is gone now

Comment 9

[Olli Pettay [:smaug][[e-mail]]]

Attachment: patch

Comment 10

[Olli Pettay [:smaug][[e-mail]]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/46ba7eb77ae1

Comment 11

[Olli Pettay [:smaug][[e-mail]]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c3a84e883c3d

Comment 12

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/c3a84e883c3d