Closed Bug 848293 Opened 7 years ago Closed 7 years ago

Update AnimationEvent to be compatible with the spec

Categories

(Core :: Layout, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla23

People

(Reporter: smaug, Assigned: smaug)

References

Details

(Keywords: dev-doc-complete)

Attachments

(2 files)

Better to do this after webidl-fication.
Assignee: nobody → bugs
Blocks: 868769
Comment on attachment 745567 [details] [diff] [review]
patch

Could you add an assertion at the start of 
ElementAnimations::GetPositionInIteration that
!aAnimation == !aEa && !aAnimation == !aEventsToDispatch.


>+is(e.elapsedTime, "0.5");

I'm surprised the 0.5 is in quotes.  Does that work?



And again, it would be good to remove initAnimationEvent in a followup patch.

r=dbaron
Attachment #745567 - Flags: review?(dbaron) → review+
Attached patch patchSplinter Review
https://hg.mozilla.org/mozilla-central/rev/cdc859533b8d
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in before you can comment on or make changes to this bug.