Last Comment Bug 848293 - Update AnimationEvent to be compatible with the spec
: Update AnimationEvent to be compatible with the spec
Status: RESOLVED FIXED
: dev-doc-complete
Product: Core
Classification: Components
Component: Layout (show other bugs)
: unspecified
: x86_64 Linux
: -- normal (vote)
: mozilla23
Assigned To: Olli Pettay [:smaug] (way behind * queues, especially ni? queue)
:
:
Mentors:
Depends on: 847589
Blocks: 868769
  Show dependency treegraph
 
Reported: 2013-03-06 03:57 PST by Olli Pettay [:smaug] (way behind * queues, especially ni? queue)
Modified: 2013-08-28 01:58 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (26.08 KB, patch)
2013-05-04 10:56 PDT, Olli Pettay [:smaug] (way behind * queues, especially ni? queue)
dbaron: review+
Details | Diff | Splinter Review
patch (26.15 KB, patch)
2013-05-05 06:22 PDT, Olli Pettay [:smaug] (way behind * queues, especially ni? queue)
no flags Details | Diff | Splinter Review

Description Olli Pettay [:smaug] (way behind * queues, especially ni? queue) 2013-03-06 03:57:31 PST
Better to do this after webidl-fication.
Comment 1 Olli Pettay [:smaug] (way behind * queues, especially ni? queue) 2013-05-04 10:56:33 PDT
Created attachment 745567 [details] [diff] [review]
patch

https://tbpl.mozilla.org/?tree=Try&rev=3a808680861b
Comment 2 David Baron :dbaron: ⌚️UTC-7 (busy September 14-25) 2013-05-04 11:10:45 PDT
Comment on attachment 745567 [details] [diff] [review]
patch

Could you add an assertion at the start of 
ElementAnimations::GetPositionInIteration that
!aAnimation == !aEa && !aAnimation == !aEventsToDispatch.


>+is(e.elapsedTime, "0.5");

I'm surprised the 0.5 is in quotes.  Does that work?



And again, it would be good to remove initAnimationEvent in a followup patch.

r=dbaron
Comment 3 Olli Pettay [:smaug] (way behind * queues, especially ni? queue) 2013-05-05 06:22:06 PDT
Created attachment 745639 [details] [diff] [review]
patch
Comment 4 Olli Pettay [:smaug] (way behind * queues, especially ni? queue) 2013-05-05 06:31:29 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/cdc859533b8d
Comment 5 Phil Ringnalda (:philor) 2013-05-05 17:18:20 PDT
https://hg.mozilla.org/mozilla-central/rev/cdc859533b8d

Note You need to log in before you can comment on or make changes to this bug.