848293 - Update AnimationEvent to be compatible with the spec

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

Better to do this after webidl-fication.

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Attachment: patch

https://tbpl.mozilla.org/?tree=Try&rev=3a808680861b

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 745567 [details] [diff] [review]
patch

Could you add an assertion at the start of 
ElementAnimations::GetPositionInIteration that
!aAnimation == !aEa && !aAnimation == !aEventsToDispatch.


>+is(e.elapsedTime, "0.5");

I'm surprised the 0.5 is in quotes.  Does that work?



And again, it would be good to remove initAnimationEvent in a followup patch.

r=dbaron

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Attachment: patch

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/cdc859533b8d

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/cdc859533b8d

Comment 6

[Jean-Yves Perrier [:teoli]]

Doc updated/created:
https://developer.mozilla.org/en-US/docs/Web/API/AnimationEvent
https://developer.mozilla.org/en-US/docs/Web/API/AnimationEvent.AnimationEvent
https://developer.mozilla.org/en-US/docs/Web/API/AnimationEvent.pseudoElement
https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/23

I didn't changed:
https://developer.mozilla.org/en-US/docs/Web/API/AnimationEvent.initAnimationEvent
because the new fourth optional arguments never went into a release as the method has been removed by bug 868751 (that is still in progress to be documented).