Update AnimationEvent to be compatible with the spec

RESOLVED FIXED in mozilla23

Status

()

Core
Layout
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: smaug, Assigned: smaug)

Tracking

({dev-doc-complete})

unspecified
mozilla23
x86_64
Linux
dev-doc-complete
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

4 years ago
Better to do this after webidl-fication.
(Assignee)

Updated

4 years ago
Assignee: nobody → bugs
(Assignee)

Updated

4 years ago
Blocks: 868769
(Assignee)

Comment 1

4 years ago
Created attachment 745567 [details] [diff] [review]
patch

https://tbpl.mozilla.org/?tree=Try&rev=3a808680861b
Attachment #745567 - Flags: review?(dbaron)
Comment on attachment 745567 [details] [diff] [review]
patch

Could you add an assertion at the start of 
ElementAnimations::GetPositionInIteration that
!aAnimation == !aEa && !aAnimation == !aEventsToDispatch.


>+is(e.elapsedTime, "0.5");

I'm surprised the 0.5 is in quotes.  Does that work?



And again, it would be good to remove initAnimationEvent in a followup patch.

r=dbaron
Attachment #745567 - Flags: review?(dbaron) → review+
(Assignee)

Comment 3

4 years ago
Created attachment 745639 [details] [diff] [review]
patch
(Assignee)

Comment 4

4 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/cdc859533b8d
https://hg.mozilla.org/mozilla-central/rev/cdc859533b8d
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
Doc updated/created:
https://developer.mozilla.org/en-US/docs/Web/API/AnimationEvent
https://developer.mozilla.org/en-US/docs/Web/API/AnimationEvent.AnimationEvent
https://developer.mozilla.org/en-US/docs/Web/API/AnimationEvent.pseudoElement
https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/23

I didn't changed:
https://developer.mozilla.org/en-US/docs/Web/API/AnimationEvent.initAnimationEvent
because the new fourth optional arguments never went into a release as the method has been removed by bug 868751 (that is still in progress to be documented).
Keywords: dev-doc-complete
You need to log in before you can comment on or make changes to this bug.