Closed
Bug 847599
Opened 12 years ago
Closed 12 years ago
Paris binding for TransitionEvent
Categories
(Core :: DOM: Events, defect)
Tracking
()
RESOLVED
FIXED
mozilla22
People
(Reporter: smaug, Assigned: smaug)
References
Details
Attachments
(2 files, 1 obsolete file)
5.36 KB,
patch
|
Ms2ger
:
review+
|
Details | Diff | Splinter Review |
5.25 KB,
patch
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•12 years ago
|
||
Assignee: nobody → bugs
Assignee | ||
Comment 2•12 years ago
|
||
Attachment #721449 -
Flags: review?(Ms2ger)
Assignee | ||
Comment 3•12 years ago
|
||
Attachment #721449 -
Attachment is obsolete: true
Attachment #721449 -
Flags: review?(Ms2ger)
Attachment #723116 -
Flags: review?(Ms2ger)
Comment 4•12 years ago
|
||
Comment on attachment 723116 [details] [diff] [review]
patch
Review of attachment 723116 [details] [diff] [review]:
-----------------------------------------------------------------
::: content/events/src/nsDOMTransitionEvent.h
@@ +25,5 @@
> NS_FORWARD_TO_NSDOMEVENT
> NS_DECL_NSIDOMTRANSITIONEVENT
>
> + virtual JSObject* WrapObject(JSContext* aCx, JSObject* aScope,
> + bool* aTriedToWrap)
.
::: dom/webidl/TransitionEvent.webidl
@@ +9,5 @@
> + *
> + * Copyright © 2012 W3C® (MIT, ERCIM, Keio), All Rights Reserved. W3C
> + * liability, trademark and document use rules apply.
> + */
> +
Trailing whitespace
Attachment #723116 -
Flags: review?(Ms2ger) → review+
Assignee | ||
Comment 5•12 years ago
|
||
Assignee | ||
Comment 6•12 years ago
|
||
Comment 7•12 years ago
|
||
Push backed out for crashes, eg:
https://tbpl.mozilla.org/php/getParsedLog.php?id=20644254&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=20644682&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=20644913&tree=Mozilla-Inbound
https://hg.mozilla.org/integration/mozilla-inbound/rev/630d841daf46
https://hg.mozilla.org/integration/mozilla-inbound/rev/44810fa6c312
https://hg.mozilla.org/integration/mozilla-inbound/rev/9f128f1af706
Assignee | ||
Comment 8•12 years ago
|
||
Fun, totally unreproduceable crash here.
Assignee | ||
Comment 9•12 years ago
|
||
Can't reproduce on tryserver either. Could this require a clobber?
Comment 10•12 years ago
|
||
(In reply to Olli Pettay [:smaug] from comment #9)
> Can't reproduce on tryserver either. Could this require a clobber?
It's not immediately obvious to me how this could require a clobber, but you're welcome to reland with a change to the CLOBBER file...
Assignee | ||
Comment 11•12 years ago
|
||
I'll try to reland tomorrow.
https://tbpl.mozilla.org/?tree=Try&rev=85dfda2d314c doesn't show problems on windows.
Assignee | ||
Comment 12•12 years ago
|
||
Crossing fingers
https://hg.mozilla.org/integration/mozilla-inbound/rev/cceb495a89d6
I run the tests several times on try and no crashes.
Comment 13•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/cceb495a89d6
https://hg.mozilla.org/mozilla-central/rev/a1b34cb6b77e
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
You need to log in
before you can comment on or make changes to this bug.
Description
•