847599 - Paris binding for TransitionEvent

Status: RESOLVED FIXED

(Core :: DOM: Events, defect)

Comment 1

[Olli Pettay [:smaug]]

Attachment: patch

https://tbpl.mozilla.org/?tree=Try&rev=3a5e7b7cf253

Comment 2

[Olli Pettay [:smaug]]

Comment on attachment 721449 [details] [diff] [review]
patch

Bug 848291 is a followup.

Comment 3

[Olli Pettay [:smaug]]

Attachment: patch

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 723116 [details] [diff] [review]
patch

Review of attachment 723116 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/events/src/nsDOMTransitionEvent.h
@@ +25,5 @@
>    NS_FORWARD_TO_NSDOMEVENT
>    NS_DECL_NSIDOMTRANSITIONEVENT
>  
> +  virtual JSObject* WrapObject(JSContext* aCx, JSObject* aScope,
> +                               bool* aTriedToWrap)

.

::: dom/webidl/TransitionEvent.webidl
@@ +9,5 @@
> + *
> + * Copyright © 2012 W3C® (MIT, ERCIM, Keio), All Rights Reserved. W3C
> + * liability, trademark and document use rules apply.
> + */
> + 

Trailing whitespace

Comment 5

[Olli Pettay [:smaug]]

Attachment: patch

Comment 6

[Olli Pettay [:smaug]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6ab8497cb00f

Comment 7

[Ed Morley [:emorley]]

Push backed out for crashes, eg:
https://tbpl.mozilla.org/php/getParsedLog.php?id=20644254&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=20644682&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=20644913&tree=Mozilla-Inbound

https://hg.mozilla.org/integration/mozilla-inbound/rev/630d841daf46
https://hg.mozilla.org/integration/mozilla-inbound/rev/44810fa6c312
https://hg.mozilla.org/integration/mozilla-inbound/rev/9f128f1af706

Comment 8

[Olli Pettay [:smaug]]

Fun, totally unreproduceable crash here.

Comment 9

[Olli Pettay [:smaug]]

Can't reproduce on tryserver either. Could this require a clobber?

Comment 10

[:ehsan akhgari]

(In reply to Olli Pettay [:smaug] from comment #9)
> Can't reproduce on tryserver either. Could this require a clobber?

It's not immediately obvious to me how this could require a clobber, but you're welcome to reland with a change to the CLOBBER file...

Comment 11

[Olli Pettay [:smaug]]

I'll try to reland tomorrow.
https://tbpl.mozilla.org/?tree=Try&rev=85dfda2d314c doesn't show problems on windows.

Comment 12

[Olli Pettay [:smaug]]

Crossing fingers
https://hg.mozilla.org/integration/mozilla-inbound/rev/cceb495a89d6

I run the tests several times on try and no crashes.

Comment 13

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/cceb495a89d6
https://hg.mozilla.org/mozilla-central/rev/a1b34cb6b77e