848317 - Screen corruption on dismissal of Android action-bar

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

Description

[Aaron Train [:aaronmt]]

Attachment: Nightly (03.06) - Screenshot

On dismissal of the address-bar's action-bar there is a quick graphical glitch; see screenshot. 

--
Nightly (03.06)
LG Nexus 4 (Android 4.2.2)

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Looks like another one of those GL state corruption bugs.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Same issue that Lucas is working on

Comment 4

[Aaron Train [:aaronmt]]

Fixed on Nightly (03/22)

Comment 5

[Aaron Train [:aaronmt]]

I still see this on Nightly (03/27) on my Nexus 4.

Comment 6

[Aaron Train [:aaronmt]]

Attachment: Nightly (03/27) - Screenshot

Comment 7

[Chris Lord [:cwiiis]]

bnicholson commented that this is an entirely different activity to the main app that bug 716403 affects, so this may well be unrelated - removing blocker status.

Comment 9

[Aaron Train [:aaronmt]]

This looks terrible on Honeycomb http://youtu.be/7rzLDM4ui4E

Comment 10

[Kartikaya Gupta (email:[e-mail])]

I can also reproduce on a Galaxy Tab.

Comment 11

[Teodora Vermesan (:TeoVermesan)]

The regression window for this issue is:

good build: 27.02.2013  
bad build:  28.02.2013 

possible pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=e7632ab657e5&tochange=b0e08db3bc2a

Comment 12

[Aaron Train [:aaronmt]]

http://hg.mozilla.org/mozilla-central/rev/29de190ac31c ?

Comment 13

[Sriram Ramasubramanian [:sriram]]

(In reply to Aaron Train [:aaronmt] from comment #12)
> http://hg.mozilla.org/mozilla-central/rev/29de190ac31c ?

Yup. That removed the background for the window. Which might have caused this problem. The easiest way is to add the background back (and we will be breaking the AwesomeBar soon). However, we might face the same problem in BrowserApp, as BrowserApp too doesn't have a background.

Comment 14

[Brad Lassey [:blassey] (use needinfo?)]

Sriram, do you know how to proceed here?

Comment 15

[Sriram Ramasubramanian [:sriram]]

This was fixed. However Aaron reported that this breaks in Nexus 4.

Comment 16

[Aaron Train [:aaronmt]]

Actually you're in luck; testing on 04/11 this seems fixed for me on my Nexus 4. Something recent fixed this.

Comment 17

[Aaron Train [:aaronmt]]

Nevermind, I still see this on 04/15.

STR: Long tap on the URL bar, see action bar, tap selected text and see action-bar glitch off

Comment 18

[Aaron Train [:aaronmt]]

This was never fixed.

Comment 19

[Mark Finkle (:mfinkle) (use needinfo?)]

Lucas - Can you take a look at this?

Comment 20

[Mark Finkle (:mfinkle) (use needinfo?)]

Back to Sriram. This is on beta, can you take a look soon?

Comment 21

[Aaron Train [:aaronmt]]

^

Comment 22

[Sriram Ramasubramanian [:sriram]]

I have two options in hand:
1. Set a color to window background before hiding action bar so that it wouldn't cause corruption
  - I highly doubt that the window invalidates itself to change the color before the animation starts. This might/might not work.
2. Forget about overdraw and add a color for window-background.
  - This will ensure that there is no corruption. And anyways AwesomeBar is going to go away.

Comment 23

[Aaron Train [:aaronmt]]

(In reply to Sriram Ramasubramanian [:sriram] from comment #22)
> I have two options in hand:
> 1. Set a color to window background before hiding action bar so that it
> wouldn't cause corruption
>   - I highly doubt that the window invalidates itself to change the color
> before the animation starts. This might/might not work.

Options 1 → Failure: http://cl.ly/image/1W3o2t1v1L1o

Comment 24

[Aaron Train [:aaronmt]]

Option 2 → Success!

Comment 25

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch

This is patch for option 2.

(Sorry romainguy, we can't make you happy all the time!)

Comment 26

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 754994 [details] [diff] [review]
Patch

Prepare for uplift!

Comment 27

[Sriram Ramasubramanian [:sriram]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/760499cbe81d

Comment 28

[Sriram Ramasubramanian [:sriram]]

Comment on attachment 754994 [details] [diff] [review]
Patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Removing overdraw for AwesomeBar.
User impact if declined: Screen corruption.
Testing completed (on m-c, etc.): Landed in m-i on 05/28
Risk to taking this patch (and alternatives if risky): None. This adds the windowBackground which none would see. It's the same color as url-bar.
String or IDL/UUID changes made by this patch: None.

Comment 29

[Ryan VanderMeulen [:RyanVM]]

Backed out because something in this push was causing frequent robocop-2 failures.
https://hg.mozilla.org/integration/mozilla-inbound/rev/d1b1b018a383

https://tbpl.mozilla.org/php/getParsedLog.php?id=23509945&tree=Mozilla-Inbound

Comment 30

[Sriram Ramasubramanian [:sriram]]

Re-landing as the failure is not due to this one-liner:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c381730a8bbf

Comment 31

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c381730a8bbf

Comment 32

[Ryan VanderMeulen [:RyanVM]]

This applies fine to aurora but needs help for beta.

Comment 33

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/392aa014b528

Comment 34

[Sriram Ramasubramanian [:sriram]]

Is this required in beta? We never fixed overdraw for Awesomebar in beta.
AwesomeBar should have a white background (as it inherits from Light theme) and hence shouldn't be corrupted.

Comment 35

[Alex Keybl [:akeybl]]

(In reply to Sriram Ramasubramanian [:sriram] from comment #34)
> Is this required in beta? We never fixed overdraw for Awesomebar in beta.
> AwesomeBar should have a white background (as it inherits from Light theme)
> and hence shouldn't be corrupted.

Who's this a question for? Can you check?

Comment 36

[Adrian Tamas (:AdrianT)]

I am unable to reproduce the issue on the the Samsung Galaxy S2 (Android 4.0.4) or LG Nexus 4 (Android 4.2.2) on the Firefox Mobile 22 beta 4. However on the Acer Iconia A500 (Android 3.2) the area of the copy/paste UI remains white when the bar is dismissed, but I believe this was covered in another bug.

Videocapture on Honeycomb: http://youtu.be/Vx930E2R3Io

Comment 37

[Sriram Ramasubramanian [:sriram]]

(In reply to Alex Keybl [:akeybl] (out till 6/10) from comment #35)
> (In reply to Sriram Ramasubramanian [:sriram] from comment #34)
> > Is this required in beta? We never fixed overdraw for Awesomebar in beta.
> > AwesomeBar should have a white background (as it inherits from Light theme)
> > and hence shouldn't be corrupted.
> 
> Who's this a question for? Can you check?

This was for Aaron :)
But this issue is not seen in Beta. We don't have to track this bug for beta.

Comment 38

[Aaron Train [:aaronmt]]

Fx22 is not affected.