848491 - [Skia] Rebase again (Q1 2013)

Status: RESOLVED FIXED

(Core :: Graphics, defect, P3)

Description

[George Wright (:gw280) (needinfo me!)]

I'd like to aim for a rebase every quarter until we come up with a better solution for pulling in upstream Skia.. This bug will track the Q1 2013 rebase.

Comment 1

[George Wright (:gw280) (needinfo me!)]

Attachment: fuzz redGradientBlueSolid a little bit

We fail the redGradientBlueSolid test with Skia/SW. I think the conditionals should be >= and <= based on the gradient stop values, which fixes the failure.

Comment 2

[George Wright (:gw280) (needinfo me!)]

Attachment: update drawtarget

Comment 3

[George Wright (:gw280) (needinfo me!)]

Attachment: update skia-npapi

Comment 4

[George Wright (:gw280) (needinfo me!)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8bde774bdb36
https://hg.mozilla.org/integration/mozilla-inbound/rev/3e1ed95df35a
https://hg.mozilla.org/integration/mozilla-inbound/rev/3c73557ee12a
https://hg.mozilla.org/integration/mozilla-inbound/rev/538f8d1e0e82
https://hg.mozilla.org/integration/mozilla-inbound/rev/72a20c253b78
https://hg.mozilla.org/integration/mozilla-inbound/rev/4f06aed35515
https://hg.mozilla.org/integration/mozilla-inbound/rev/28957db0a941
https://hg.mozilla.org/integration/mozilla-inbound/rev/e644f700f7c1
https://hg.mozilla.org/integration/mozilla-inbound/rev/88d7e8dbb2aa
https://hg.mozilla.org/integration/mozilla-inbound/rev/9b46df23d1fe
https://hg.mozilla.org/integration/mozilla-inbound/rev/ab576a03025e
https://hg.mozilla.org/integration/mozilla-inbound/rev/b3e5868f2540

Comment 5

[Ryan VanderMeulen [:RyanVM]]

And a CLOBBER touch.
http://hg.mozilla.org/integration/mozilla-inbound/rev/73da858ef7ab

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b3e5868f2540
https://hg.mozilla.org/mozilla-central/rev/ab576a03025e
https://hg.mozilla.org/mozilla-central/rev/9b46df23d1fe
https://hg.mozilla.org/mozilla-central/rev/88d7e8dbb2aa
https://hg.mozilla.org/mozilla-central/rev/e644f700f7c1
https://hg.mozilla.org/mozilla-central/rev/28957db0a941
https://hg.mozilla.org/mozilla-central/rev/4f06aed35515
https://hg.mozilla.org/mozilla-central/rev/72a20c253b78
https://hg.mozilla.org/mozilla-central/rev/538f8d1e0e82
https://hg.mozilla.org/mozilla-central/rev/3c73557ee12a
https://hg.mozilla.org/mozilla-central/rev/8bde774bdb36
https://hg.mozilla.org/mozilla-central/rev/3e1ed95df35a
https://hg.mozilla.org/mozilla-central/rev/73da858ef7ab

Comment 7

[Landry Breuil (:gaston)]

Fwiw, this broke the build on all BSDs:

gfx/skia/src/utils/SkThreadUtils_pthread_linux.cpp:17:40: error: unknown type name 'cpu_set_t'

etc etc

http://buildbot.rhaalovely.net/builders/mozilla-central-amd64/builds/807/steps/build/logs/stdio

Comment 8

[Jacek Caban]

I landed a trivial fix for cross compiling from case-sensitive OSes:

https://hg.mozilla.org/integration/mozilla-inbound/rev/8f4eaade578e

I fixed it upstream first:

https://codereview.chromium.org/99173003/

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8f4eaade578e

Comment 10

[Tapas[:tkundu on #b2g/gaia/memshrink/gfx] (always NI me)]

Can anyone please tell me when we are planning to rebase skia again for 1.4 ?

Comment 11

[George Wright (:gw280) (needinfo me!)]

Within the next few days; final blocking bug got fixed last night.