[Skia] Rebase again (Q1 2013)

RESOLVED FIXED in mozilla25

Status

()

P3
normal
RESOLVED FIXED
6 years ago
3 years ago

People

(Reporter: gw280, Assigned: gw280)

Tracking

unspecified
mozilla25
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

I'd like to aim for a rebase every quarter until we come up with a better solution for pulling in upstream Skia.. This bug will track the Q1 2013 rebase.
Priority: -- → P3
No longer blocks: 874768
Created attachment 768472 [details] [diff] [review]
fuzz redGradientBlueSolid a little bit

We fail the redGradientBlueSolid test with Skia/SW. I think the conditionals should be >= and <= based on the gradient stop values, which fixes the failure.
Attachment #768472 - Flags: review?(mnoorenberghe+bmo)
Attachment #768472 - Flags: review?(mnoorenberghe+bmo) → review+
Created attachment 770280 [details] [diff] [review]
update drawtarget
Attachment #770280 - Flags: review?(matt.woodrow)
Created attachment 770281 [details] [diff] [review]
update skia-npapi
Attachment #770281 - Flags: review?(matt.woodrow)
Attachment #770280 - Flags: review?(matt.woodrow) → review+
Attachment #770281 - Flags: review?(matt.woodrow) → review+
Fwiw, this broke the build on all BSDs:

gfx/skia/src/utils/SkThreadUtils_pthread_linux.cpp:17:40: error: unknown type name 'cpu_set_t'

etc etc

http://buildbot.rhaalovely.net/builders/mozilla-central-amd64/builds/807/steps/build/logs/stdio

Updated

6 years ago
Depends on: 890240
Depends on: 890539

Updated

6 years ago
Depends on: 891123
Depends on: 921670

Comment 8

5 years ago
I landed a trivial fix for cross compiling from case-sensitive OSes:

https://hg.mozilla.org/integration/mozilla-inbound/rev/8f4eaade578e

I fixed it upstream first:

https://codereview.chromium.org/99173003/
Can anyone please tell me when we are planning to rebase skia again for 1.4 ?
Flags: needinfo?(gwright)
Within the next few days; final blocking bug got fixed last night.
Flags: needinfo?(gwright)

Updated

3 years ago
Depends on: 1249875
You need to log in before you can comment on or make changes to this bug.