Closed Bug 848491 Opened 10 years ago Closed 10 years ago

[Skia] Rebase again (Q1 2013)


(Core :: Graphics, defect, P3)






(Reporter: gw280, Assigned: gw280)




(3 files)

I'd like to aim for a rebase every quarter until we come up with a better solution for pulling in upstream Skia.. This bug will track the Q1 2013 rebase.
Priority: -- → P3
No longer blocks: 874768
We fail the redGradientBlueSolid test with Skia/SW. I think the conditionals should be >= and <= based on the gradient stop values, which fixes the failure.
Attachment #768472 - Flags: review?(mnoorenberghe+bmo)
Attachment #768472 - Flags: review?(mnoorenberghe+bmo) → review+
Attachment #770280 - Flags: review?(matt.woodrow)
Attachment #770281 - Flags: review?(matt.woodrow)
Attachment #770280 - Flags: review?(matt.woodrow) → review+
Attachment #770281 - Flags: review?(matt.woodrow) → review+
Fwiw, this broke the build on all BSDs:

gfx/skia/src/utils/SkThreadUtils_pthread_linux.cpp:17:40: error: unknown type name 'cpu_set_t'

etc etc
Depends on: 890240
Depends on: 890539
Depends on: 891123
Depends on: 921670
I landed a trivial fix for cross compiling from case-sensitive OSes:

I fixed it upstream first:
Can anyone please tell me when we are planning to rebase skia again for 1.4 ?
Flags: needinfo?(gwright)
Within the next few days; final blocking bug got fixed last night.
Flags: needinfo?(gwright)
Depends on: 1249875
You need to log in before you can comment on or make changes to this bug.