848497 - [socorro-crashstats] version still isn't always passed correctly to report/list, part deux

Status: VERIFIED FIXED

(Socorro Graveyard :: Middleware, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

STR:

1. Load https://crash-stats-django.allizom.org/query/?product=Firefox&range_value=1&range_unit=weeks&date=03/06/2013+19:43:17&query_search=signature&query_type=is_exactly&query=&reason=&build_id=&process_type=any&hang_type=any&plugin_field=filename&plugin_query_type=contains&plugin_query=
2. Click on any of the signatures
3. The default in the UI is "7 days"
4. Now, click on any of the other "days" options: 3, 14, or 28

Actual Results:

https://crash-stats-django.allizom.org/report/list?product=Firefox&version=ALL&query_search=signature&query_type=contains&reason_type=contains&date=2013-03-06&range_value=3&range_unit=days&hang_type=any&process_type=any&signature=TlsGetValue loads and you get:

version

    Select a valid choice. ALL is not one of the available choices.

Comment 1

[Robert Kaiser]

I couldn't load the URL from step 1 here. This works though:

1) Load https://crash-stats-django.mozilla.org/report/list?signature=js%3A%3Amjit%3A%3AJITChunk%3A%3ApurgeCaches%28%29&product=Firefox&query_type=contains&range_unit=weeks&process_type=any&hang_type=any&date=2013-03-25+19%3A56%3A33&range_value=1
2) Click on any of the other "days" options: 3, 14, or 28

Comment 2

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to Robert Kaiser (:[e-mail]) from comment #1)
> I couldn't load the URL from step 1 here. This works though:
> 
> 1) Load
> https://crash-stats-django.mozilla.org/report/
> list?signature=js%3A%3Amjit%3A%3AJITChunk%3A%3ApurgeCaches%28%29&product=Fire
> fox&query_type=contains&range_unit=weeks&process_type=any&hang_type=any&date=
> 2013-03-25+19%3A56%3A33&range_value=1
> 2) Click on any of the other "days" options: 3, 14, or 28

http://screencast.com/t/gTL4l3XSwu

Comment 3

[Robert Kaiser]

(In reply to Stephen Donner [:stephend] from comment #2)
> http://screencast.com/t/gTL4l3XSwu

OK, I believe you. So both your and my derived steps work to reproduce the problem. :)

I've asked for this getting fixed to actually block the deployment of socorro-crashstats as the new UI, as search, followed by clicking on a signature, is something we are doing a lot, and looking at other ranges from there probably enough that it work break our workflow.

Comment 4

[Robert Helmer [:rhelmer]]

r? https://github.com/mozilla/socorro-crashstats/pull/323

Comment 5

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro-crashstats

https://github.com/mozilla/socorro-crashstats/commit/53ddcf6d7a356c13a077570c80ee380dbd61d556
bug 848497 - pass ALL:ALL for no version specified, not ALL

https://github.com/mozilla/socorro-crashstats/commit/b71a70e5dccb47b75bc5340d20a0fa90ee99ed0a
Merge pull request #323 from rhelmer/bug848497-report-list-missing-version

bug 848497 - pass ALL:ALL for no version specified, not ALL

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on prod (since we shipped the Django app today, w00t!):

https://crash-stats.mozilla.com/report/list?signature=RtlpAllocateHeap+|+RtlpAllocateHeap+|+CContext%3A%3ARestorePipelineStateImpl%3Cint%3E%28SAPIPipelineState*%29&product=Firefox&query_type=is_exactly&range_unit=weeks&process_type=any&hang_type=any&date=2013-03-06+19%3A43%3A17&range_value=1

https://crash-stats.mozilla.com/report/list?product=Firefox&query_search=signature&query_type=contains&reason_type=contains&date=2013-03-06&range_value=14&range_unit=days&hang_type=any&process_type=any&signature=RtlpAllocateHeap+|+RtlpAllocateHeap+|+CContext%3A%3ARestorePipelineStateImpl%3Cint%3E%28SAPIPipelineState*%29

etc.