885868 - [socorro-crashstats][traceback] RequiredParameterError: versions

Status: VERIFIED DUPLICATE of bug 880087

(Socorro Graveyard :: Middleware, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

Found this one while testing bug 848497.

STR:

1. Load https://crash-stats-django.allizom.org/query/?product=Firefox&range_value=1&range_unit=weeks&date=03/06/2013+19:43:17&query_search=signature&query_type=is_exactly&query=&reason=&build_id=&process_type=any&hang_type=any&plugin_field=filename&plugin_query_type=contains&plugin_query
2. Click #2, which yields https://crash-stats-django.allizom.org/report/list?signature=hang+|+WaitForMultipleObjectsEx+|+RealMsgWaitForMultipleObjectsEx+|+MsgWaitForMultipleObjects+|+F_1152915508___________________________________&product=Firefox&query_type=is_exactly&range_unit=weeks&process_type=any&hang_type=any&date=2013-03-06+19%3A43%3A17&range_value=1
3. Look in the Web Console and the UI, which seems to hang/keep polling

Actual:

[13:45:21.547] GET https://crash-stats-django.allizom.org/signature_summary/json_data?range_value=7&range_unit=days&signature=hang+%7C+WaitForMultipleObjectsEx+%7C+RealMsgWaitForMultipleObjectsEx+%7C+MsgWaitForMultipleObjects+%7C+F_1152915508___________________________________&date=2013-03-06 [HTTP/1.1 500 INTERNAL SERVER ERROR 191ms]

RequiredParameterError: versions

Stacktrace (most recent call last):

  File "django/core/handlers/base.py", line 111, in get_response
    response = callback(request, *callback_args, **callback_kwargs)
  File "crashstats/crashstats/utils.py", line 53, in wrapper
    response = f(request, *args, **kw)
  File "crashstats/crashstats/views.py", line 1535, in signature_summary
    versions=version,
  File "crashstats/crashstats/models.py", line 221, in get
    raise RequiredParameterError(param)

Comment 1

[Robert Helmer [:rhelmer]]

The problem here seems to be with links from /query to /report/list - it's missing something that /report/list expects and hands off to signature summary, I think the version param.

Comment 2

[Stephen Donner [:stephend] Not actively reading bugmail]

This might help?

UnboundLocalError: local variable 'version' referenced before assignment

Stacktrace (most recent call last):

  File "django/core/handlers/base.py", line 111, in get_response
    response = callback(request, *callback_args, **callback_kwargs)
  File "crashstats/crashstats/decorators.py", line 48, in inner
    return view(request, *args, **kwargs)
  File "crashstats/crashstats/views.py", line 1608, in crash_trends
    context['version'] = version

Seen when hitting https://crash-stats-django.allizom.org/crash_trends/products/Firefox, after selecting it from https://crash-stats-django.allizom.org/home/products/Firefox

Comment 3

[Robert Helmer [:rhelmer]]

Fix for this is the same as bug 880087 so duping.

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED (and therefore a dupe, too).