Closed Bug 849440 Opened 7 years ago Closed 7 years ago

Private downloads don't update

Categories

(SeaMonkey :: Download & File Handling, defect)

defect
Not set

Tracking

(seamonkey2.18 fixed, seamonkey2.19 fixed)

RESOLVED FIXED
seamonkey2.19
Tracking Status
seamonkey2.18 --- fixed
seamonkey2.19 --- fixed

People

(Reporter: neil, Assigned: neil)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Although starting a private download opens a progress dialog, the dialog never updates. Also when it does update it will automatically close when done, which is inconvenient as there is no way to reopen it.
Attached patch Proposed patchSplinter Review
The addPrivacyAwareListener is the change that makes the dialog update correctly.

I opted to hide the checkbox if the download is private.

If properties for an already finished download are opened from the download manager then the dialog will not close automatically. If you think this is outside the scope of the bug then I will remove that part of the patch.
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #723008 - Flags: review?(iann_bugzilla)
Attachment #723008 - Flags: feedback?(philip.chee)
Hm. Should we even open a progress dialog for a PB download?
(In reply to Philip Chee from comment #2)
> Should we even open a progress dialog for a PB download?

They don't appear in the Download Manager, so what choice do we have?
Comment on attachment 723008 [details] [diff] [review]
Proposed patch

Works if I save a web page. If I use the context menu "Save Link Target As..." the Download Manager opens and the download is not private. Need to fix nsContextMenu.js

See Bug 792517 and:
http://hg.mozilla.org/mozilla-central/rev/cb64683950d9
Attachment #723008 - Flags: feedback?(philip.chee) → feedback-
Comment on attachment 723008 [details] [diff] [review]
Proposed patch

f=me any remaining issues to be fixed in Bug 851304
Attachment #723008 - Flags: feedback- → feedback+
Attachment #723008 - Flags: review?(iann_bugzilla) → review+
Pushed comm-central changeset 386c0f15fcd6.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.19
Comment on attachment 723008 [details] [diff] [review]
Proposed patch

[Approval Request Comment]
Regression caused by (bug #): 
User impact if declined: Unable to monitor the progress of a private download
Testing completed (on m-c, etc.): Merged to c-a
Risk to taking this patch (and alternatives if risky): 
String changes made by this patch: None
Attachment #723008 - Flags: approval-comm-beta?
Attachment #723008 - Flags: approval-comm-beta? → approval-comm-beta+
Blocks: 460895
You need to log in before you can comment on or make changes to this bug.