Closed Bug 851304 Opened 7 years ago Closed 7 years ago

nsContextMenu.js save as handler creates a channel without regard for privacy status

Categories

(SeaMonkey :: Download & File Handling, defect)

defect
Not set

Tracking

(seamonkey2.18 fixed, seamonkey2.19 fixed)

RESOLVED FIXED
seamonkey2.19
Tracking Status
seamonkey2.18 --- fixed
seamonkey2.19 --- fixed

People

(Reporter: neil, Assigned: neil)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

1003 bytes, patch
iann_bugzilla
: review+
philip.chee
: feedback+
iann_bugzilla
: approval-comm-beta+
Details | Diff | Splinter Review
+++ This bug was initially created as a clone of Bug #792517 +++

Ratty spotted this while reviewing bug 849440.
Attached patch Proposed patchSplinter Review
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #725123 - Flags: review?(iann_bugzilla)
Attachment #725123 - Flags: feedback?(philip.chee)
Comment on attachment 725123 [details] [diff] [review]
Proposed patch

f=me
Attachment #725123 - Flags: feedback?(philip.chee) → feedback+
Attachment #725123 - Flags: review?(iann_bugzilla) → review+
Pushed comm-central changeset 808981a7dd77.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.19
Comment on attachment 725123 [details] [diff] [review]
Proposed patch

[Approval Request Comment]
Regression caused by (bug #): 
User impact if declined: Potential information leak
Testing completed (on m-c, etc.): Uplifted to c-a
Risk to taking this patch (and alternatives if risky): Low
String changes made by this patch: None
Attachment #725123 - Flags: approval-comm-aurora?
Comment on attachment 725123 [details] [diff] [review]
Proposed patch

[Approval Request Comment]
Regression caused by (bug #): 
User impact if declined: Potential information leak
Testing completed (on m-c, etc.): Uplifted to c-a
Risk to taking this patch (and alternatives if risky): Low
String changes made by this patch: None
Attachment #725123 - Flags: approval-comm-aurora? → approval-comm-beta?
Attachment #725123 - Flags: approval-comm-beta? → approval-comm-beta+
Blocks: 460895
You need to log in before you can comment on or make changes to this bug.