850724 - Regression: Missing or transparent tab address bar when tab menu is open

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Aaron Train [:aaronmt]]

Attachment: Nightly (03/13) - Screenshot

See screenshot

STR

i) Open the tab menu over any content

The address-bar vanishes or is semi-transparent.

--
Nightly (03/13)
LG Nexus 4 (Android 4.2.2)

Comment 1

[Aaron Train [:aaronmt]]

Attachment: Nightly (03/13) - Screenshot (Landscape)

Landscape orientation makes the tab number area and menu transparent

Comment 2

[Aaron Train [:aaronmt]]

Attachment: Nightly (03/13) - Screenshot (Private Tab)

Underlying canvas I believe in new private tabs

Comment 3

[Aaron Train [:aaronmt]]

Attachment: Nightly (03/13) - Screenshot (Content)

Content shot

Comment 4

[Lucas Rocha (:lucasr)]

Maybe just implementing bug 848719 will "fix" this issue?

Comment 5

[Chris Lord [:cwiiis]]

Attachment: Don't pin or hide the toolbar in response to loading

This decision was made by UX team and implementing it handily fixes this bug :)

Comment 6

[Chris Lord [:cwiiis]]

I think comment #4 was meant to be on bug #849573

Comment 7

[Chris Lord [:cwiiis]]

Sorry, I take comment #6 back - my patch only fixes when the bar is missing, not it being transparent - bug #849573 would indeed fix that, as we wouldn't need to hide the right area of the toolbar.

Comment 8

[Chris Lord [:cwiiis]]

erk, I mean bug #848719. Sorry for the spam.

Comment 9

[Chris Lord [:cwiiis]]

Pushed to inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/2bf29458cd13

Comment 11

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/2bf29458cd13

Comment 12

[Aaron Train [:aaronmt]]

Early verified fixed on the toolbar fix (Nightly 03/20)

Comment 13

[Chris Lord [:cwiiis]]

The rest of this bug will likely be fixed by its dependents, but someone from front-end should take responsibility so that we don't lose track. needinfo'ing mfinkle to nominate someone, or just leave unassigned if that won't cause problems.

Comment 14

[Lucas Rocha (:lucasr)]

I'd say this bug can be resolved-fixed. The rest of the issues is covered by bug  	848719.

Comment 15

[Chris Lord [:cwiiis]]

This is fixed in the last couple of Nightlys - I guess sriram added a background to the transparent area? Marking as fixed wrt comment #14 anyway.

Comment 16

[Andreea Pod]

Verified fixed on:
-build: Firefox for Android 22.0a1 (2013-03-27)
-device: LG Nexus4
-OS: Android 4.2.2

Comment 17

[Cristina Madaras, QA [:CristinaM]]

Based on Comment 16, I will mark this bug as verified.