851793 - Nightly l10n fail to start <menu id="context-media-playbackrate" label="&mediaPlaybackRate.label;" accesskey="&mediaPlaybackRate.accesskey;"> ------^

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P1)

Description

[Semtex]

Attachment: Bez tytułu.png

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:22.0) Gecko/20130315 Firefox/22.0
Build ID: 20130315030943

Steps to reproduce:

Install latest Nightly l10n from here: http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/latest-mozilla-central-l10n/
Make first run (possible normal start)
Close Browser
Try run one more time


Actual results:

Nightly fail  to start with info (see screenshot)



Expected results:

Nightly suppose start without problem.

Possible regression range:
Good: http://hg.mozilla.org/mozilla-central/pushloghtml?startdate=1+day+ago&enddate=now
Bad: http://hg.mozilla.org/mozilla-central/pushloghtml?startdate=1+day+ago&enddate=now

Comment 1

[Semtex]

I've made some mistake in good build, good one is from 13.02.2013

Comment 2

[wojtekka]

I can confirm this. BTW the last good one is from 13.03.2013

Comment 3

[Scoobidiver (away)]

You was saying the regression was:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=c1a5c44ae3d8&tochange=b672877ed046
The offending line was modified in bug 840745 six builds earlier.
I think it's related to the localization in Polish of those video context menu strings:
search_type=entities&recherche=mediaPlaybackRate
http://transvision.mozfr.org/?sourcelocale=en-US&locale=pl&repo=central&

Note that I don't experience a failure on startup in French Nightly but video context menu strings are localized differently:
http://transvision.mozfr.org/?sourcelocale=en-US&locale=fr&repo=central&search_type=entities&recherche=mediaPlaybackRate

Comment 4

[Scoobidiver (away)]

(In reply to Scoobidiver from comment #3)
> search_type=entities&recherche=mediaPlaybackRate
> http://transvision.mozfr.org/?sourcelocale=en-US&locale=pl&repo=central&
Right link: http://transvision.mozfr.org/?sourcelocale=en-US&locale=pl&repo=central&search_type=entities&recherche=mediaPlaybackRate

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

A couple of locales have been started to fail with this XML parsing error. Axel, not sure what the right component is but pl may not be the right one.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Here a link to all locales which have this DTD entity localized:
http://mxr.mozilla.org/l10n-central/search?string=mediaPlaybackRate.label

Those are 9 out of all. And I believe that any locale which doesn't have this entry localized is currently busted.

I'm on PTO so someone should test this.

Comment 7

[Axel Hecht [:Pike]]

This is a releng issue, $PWD isn't escaped right. It ends up as

:\builds\moz2_slave\m-cen-w32-l10n-ntly-0000000000\build\mozilla-central\config\rules.mk:1533:0$ e:/builds/moz2_slave/m-cen-w32-l10n-ntly-0000000000/build/mozilla-central/obj-firefox/_virtualenv/Scripts/python.exe e:/builds/moz2_slave/m-cen-w32-l10n-ntly-0000000000/build/mozilla-central/config/JarMaker.py \
   -j ../../dist/xpi-stage/locale-pl/chrome \
  -t e:/builds/moz2_slave/m-cen-w32-l10n-ntly-0000000000/build/mozilla-central -f flat  --relativesrcdir=netwerk/locales --locale-mergedir=WD/merged --l10n-base=e:/builds/moz2_slave/m-cen-w32-l10n-ntly-0000000000/build/l10n-central/pl -DNDEBUG -DTRIMMED -DAB_CD=pl -DXPI_NAME=locale-pl -DNO_NSPR_10_SUPPORT -DMOZ_METRO=1 -D_CRT_SECURE_NO_WARNINGS=1 -D_CRT_NONSTDC_NO_WARNINGS=1 -DHAVE_SEH_EXCEPTIONS=1 -DHAVE_WINSDKVER_H=1 -DMOZ_MSVC_STL_WRAP__RAISE=1 -DWINVER=0x502 -D_WIN32_WINNT=0x502 -D_WIN32_IE=0x0603 -DMOZ_WINSDK_TARGETVER=0x06010000 -DMOZ_NTDDI_WIN7=0x06010000 -DHAVE_IO_H=1 -DHAVE_SETBUF=1 -DHAVE_ISATTY=1 -DX_DISPLAY_MISSING=1 -DJSGC_INCREMENTAL=1 -DMOZ_ENABLE_PROFILER_SPS=1 -DMOZILLA_VERSION=\"22.0a1\" -DMOZILLA_VERSION_U=22.0a1 -DMOZILLA_UAVERSION=\"22.0\" -DHAVE_SNPRINTF=1 -D_WINDOWS=1 -DWIN32=1 -DXP_WIN=1 -DXP_WIN32=1 -DHW_THREADS=1 -DSTDC_HEADERS=1 -DWIN32_LEAN_AND_MEAN=1 -DNO_X11=1 -DHAVE_STDCALL=1 -D_X86_=1 -DD_INO=d_ino -DNS_ATTR_MALLOC= -DNS_WARN_UNUSED_RESULT= -DMALLOC_H=\<malloc.h\> -DHAVE_FORCEINLINE=1 -DHAVE_LOCALECONV=1 -DNS_ENABLE_TSF=1 -DMOZ_UPDATE_CHANNEL=nightly -DMOZ_PHOENIX=1 -DMOZ_BUILD_APP=browser -DMOZ_PDF_PRINTING=1 -DMOZ_INSTRUMENT_EVENT_LOOP=1 -DMOZ_DISTRIBUTION_ID=\"org.mozilla\" -DIBMBIDI=1 -DACCESSIBILITY=1 -DNS_PRINTING=1 -DNS_PRINT_PREVIEW=1 -DMOZ_WEBRTC=1 -DMOZ_WEBRTC_SIGNALING=1 -DMOZ_PEERCONNECTION=1 -DMOZ_SCTP=1 -DMOZ_SRTP=1 -DMOZ_SAMPLE_TYPE_FLOAT32=1 -DMOZ_RAW=1 -DMOZ_OGG=1 -DMOZ_WEBM=1 -DMOZ_DASH=1 -DMOZ_WMF=1 -DMOZ_MEDIA_NAVIGATOR=1 -DMOZ_VP8=1 -DMOZ_VP8_ERROR_CONCEALMENT=1 -DMOZ_VP8_ENCODER=1 -DVPX_X86_ASM=1 -DMOZ_WAVE=1 -DMOZ_SYDNEYAUDIO=1 -DMOZ_SPEEX_RESAMPLER=1 -DMOZ_SOUNDTOUCH=1 -DMOZ_CUBEB=1 -DMOZ_MEDIA=1 -DMOZ_VORBIS=1 -DMOZ_OPUS=1 -DMOZ_WEBVTT=1 -DENABLE_SYSTEM_EXTENSION_DIRS=1 -DMOZ_CRASHREPORTER=1 -DBREAKPAD_CUSTOM_STDINT_H=\"mozilla/StandardInteger.h\" -DMOZ_CRASHREPORTER_INJECTOR=1 -DMOZ_CRASHREPORTER_ENABLE_PERCENT=100 -DLIBJPEG_TURBO_X86_ASM=1 -DMOZ_FLEXBOX=1 -DMOZ_WEBAPP_RUNTIME=1 -DMOZ_SIGNING=1 -DMOZ_MAINTENANCE_SERVICE=1 -DMOZ_VERIFY_MAR_SIGNATURE=1 -DMOZ_UPDATER=1 -DMOZ_FEEDS=1 -DMOZ_SAFE_BROWSING=1 -DMOZ_URL_CLASSIFIER=1 -DGL_PROVIDER_=1 -DMOZ_DEBUG_SYMBOLS=1 -DMOZ_LOGGING=1 -DJSGC_INCREMENTAL=1 -DJS_DEFAULT_JITREPORT_GRANULARITY=3 -DMOZ_OMNIJAR=1 -DMOZ_USER_DIR=\"Mozilla\" -DMOZ_TREE_PIXMAN=1 -DHAVE_STDINT_H=1 -DMOZ_TREE_CAIRO=1 -DHAVE_UINT64_T=1 -DMOZ_ENABLE_SKIA=1 -DUSE_SKIA=1 -DSKIA_DLL=1 -DGR_DLL=1 -DMOZ_XUL=1 -DMOZ_PROFILELOCKING=1 -DBUILD_CTYPES=1 -DMOZ_PLACES=1 -DMOZ_SERVICES_COMMON=1 -DMOZ_SERVICES_CRYPTO=1 -DMOZ_SERVICES_HEALTHREPORT=1 -DMOZ_SERVICES_METRICS=1 -DMOZ_SERVICES_SYNC=1 -DMOZ_MACBUNDLE_ID=org.mozilla.nightly -DMOZ_B2G_VERSION=\"1.0.0\" -DMOZ_B2G_OS_NAME=\"\" -DMOZ_APP_UA_NAME=\"\" -DMOZ_APP_UA_VERSION=\"22.0a1\" -DFIREFOX_VERSION=22.0a1 -DMOZ_UA_BUILDID=\"\" -DMOZ_TELEMETRY_DISPLAY_REV=2 -DMOZ_DATA_REPORTING=1 -DMOZ_DLL_SUFFIX=\".dll\" \
  e:/builds/moz2_slave/m-cen-w32-l10n-ntly-0000000000/build/mozilla-central/netwerk/locales/jar.mn


--locale-mergedir=WD/merge

Possibly a regression from the win64 slaves?

Comment 8

[Justin Wood (:Callek)]

So, I hit something similar in SeaMonkey 2.16.1 and fixed it in 2.16.2, though luckily Firefox uses different codepaths for release repacks so this won't affect any betas or our chemspills/finals.

The issue is at http://mxr.mozilla.org/build/source/buildbotcustom/process/factory.py#3899
specifically,
http://hg.mozilla.org/build/buildbotcustom/rev/8222831a86e5#l2.544

The reason this hits us is not because of an "improperly escaped..." but because PWD is not part of the environ of this command anymore. It was when we used the subshell (sh -c) but when invoking python directly the only environ is what we pass in self.env

Untested solution is to replace

command=self.makeCmd + [WithProperties('installers-%(locale)s'), 'LOCALE_MERGEDIR=$PWD/merged'],
with
command=self.makeCmd + [WithProperties('installers-%(locale)s'),
                        '%s/%s/locales/merged' % (self.absObjDir, self.appName)]

Comment 9

[Chris Cooper [:coop] (he/him)]

Attachment: Use full path to merged dir for l10n

We were relying too much on relative paths for the l10n merged dir with compare-locales, which made it very easy to get the level of indirection wrong and not notice that we weren't actually merging strings.

I've moved the merged dir under the baseWorkDir (build) and reference it by its full path everywhere.

Patch also fixes two nits I noticed:
1) Extends CLOBBER file removal to Firefox. Since we're not building anything as part of the repack process any more, we care less about in-tree CLOBBER and certainly don't want to be blocked on it.
2) Fixes the workdir for repack_installers_pretty. This would have been broken for Thunderbird if it ever ran there.

Comment 10

[Chris Cooper [:coop] (he/him)]

Comment on attachment 726250 [details] [diff] [review]
Use full path to merged dir for l10n

This passed for mozilla-central, comm-central, and comm-aurora in staging (mozilla-aurora still needs the approval in bug 851720).

Still not sure that compare-locales is generating valid merged output for Thunderbird, but I'll follow up with Axel about that.

Comment 11

[Chris Cooper [:coop] (he/him)]

Comment on attachment 726250 [details] [diff] [review]
Use full path to merged dir for l10n

https://hg.mozilla.org/build/buildbotcustom/rev/3c45e39ee027

Comment 12

[Chris Cooper [:coop] (he/him)]

This is in production now.