85200 - Enable In-line Bookmarks Editing for Bookmark Manager

Status: RESOLVED FIXED

(SeaMonkey :: Bookmarks & History, enhancement, P3)

Description

[David Hallowell]

Build: 2001061106
Platform: Win32, Linux x86

Steps to reproduce:
1. Press ctrl-b to open bookmarks window.
2. Select a bookmark
3. Click rename (toolbar or context menu)
4. Dismiss dialog (click OK)
5. Click properties

What happens:
The same dialog pops up (the properties dialog)

What should happen:
Either rename should bring back inline renaming (but I assume that was removed
for a reason), or the rename button should be removed as it is currently
redundant UI.

Other info:
Happens with the context menu on the personal toolbar.

Comment 1

[Ben Goodger (use ben at mozilla dot org for email)]

Inline editing will be back. This is just a placeholder for now. 

Comment 2

[Ben Goodger (use ben at mozilla dot org for email)]

Inline edit work. 

Comment 3

[Ben Goodger (use ben at mozilla dot org for email)]

Paul Chen is now taking Bookmarks bugs. For your convenience, you can filter 
email notifications caused by this by searching for 'ilikegoats'.

Comment 4

[Chris Lyon]

*** Bug 110351 has been marked as a duplicate of this bug. ***

Comment 5

[Paul Chen]

I'm not going to get to inline editing anytime soon, marking mozilla1.1

Comment 6

[Peter Trudelle]

mass reassign of pchen bookmark bugs to ben

Comment 7

[Chris Lyon]

Resolving this as duplicate of tracking bug 114431.

*** This bug has been marked as a duplicate of 114431 ***

Comment 8

[Daniel Wang]

bug 114431 is for a different issue

Comment 9

[Daniel Wang]

*** Bug 161406 has been marked as a duplicate of this bug. ***

Comment 10

[David Catmull]

It would also be good if the user could initiate in-line editing by clicking a
bookmark's name and waiting a moment (maybe with the mouse held still).

Comment 11

[Daniel B.]

> It would also be good if the user could initiate in-line editing by clicking 
> a bookmark's name and waiting a moment (maybe with the mouse held still).

Ugh.  No! Please!  Time-sensitive behavior is a real pain:  If you stop to 
think for a moment, things you didn't intend happen, and when you do want to 
do something you keep having to wait.

Do it somewhat as Netscape 4.x on Unix did:  

To edit the first bookmark, you issued a menu command that popped up a 
properties dialog box, and edited the bookmark's title, URL, etc. in the 
properties box.

To edit an additional bookmark, you clicked on the new bookmark (in the
bookmarks list), its data was entered into the properties box, and you 
edited its data.

Specifically, note that you did not need to close and re-open the 
properties box for each bookmark.  All you had to do was click on the
next bookmark to edit (in the bookmarks list) and move the mouse back
to the properties window (and click if you don't use focus-follows-mouse
mode).  (Clicking on a new bookmark saved changes to the previous one,
so you didn't even need to click on a Okay button.)


This wouldn't have to be done with a separate properties window.  
Another option would be have a bulk-editing mode that added text boxes
to the bookmarks list window.  Clicking on a bookmark would put its
properties in the text boxes.  Accidental editing would be unlikely
because you'd have to move the mouse cursor some to get to the edit
box.  Editing would clearly be a lot more convenient than having to
keep opening and closing dialog boxes.

 

Comment 12

[timeless]

[e-mail]: that's nice, but some of us are windows users (where explorer
[and fileman before it] naturally supports ILE), some of us are mac users (where
finder naturally supports ILE), and some of us are BeOS users (where tracker
naturally supports ILE). It's probably even the case for some *nix apps (nautilus?).

Comment 13

[Daniel B.]

> [e-mail]: that's nice, but some of us are windows users 

So what?  I am too.

> (where explorer [and fileman before it] naturally supports ILE),

Naturally?  Not quite.  It is quite unnatural to have to wait for 
the text to change state (from non-editable to editable).  That 
time-dependent behavior is a royal pain in the butt. 

It might support in-line editing, but it does not support it
well and does not support efficient editing of file names. 
You have to wait before you can edit the text, and if you go
too quickly, it ends up doing something completely different
from what you want (it opens the file).

Editing bookmarks with the same mechanism would cause the same
problems:  an inefficient UI and occasional accidental openings
of bookmarks.

Mozilla should do better.  

If you and others like time-dependent ILE, Mozilla should support 
it too, but Mozilla should also support some mechansim with the 
efficiency that Netscape 4 on X11 had.


Daniel

Comment 14

[Ray Booysen]

Reassigning as per Bug #32644

Comment 15

[Philip Chee]

with the places based three pane bookmark manager, we now have inline bookmarks editing.