Closed Bug 852588 Opened 10 years ago Closed 6 years ago
Santa's workshop delivers few presents per minute
In Chrome 25 or IE 10, Santa's workshop delivers around 53-67 presents per minute while only 5 in Nightly/20130318.
Component: Graphics → SVG
Whiteboard: [ietestdrive][parity-chrome][parity-ie10] → [ietestdrive]
Now it's 70 presents per minute and drop off back to 5 once you resize the window.
Whiteboard: [ietestdrive] → [ietestdrive][jwatt:invalidation]
Comment 1 is still applicable.
Win7 with HWA. I got 131 presents per minute, even after resizing the window. But the elves have didn't have a body! Even the one that appears explaining the benchmark. Chrome 29 hit 159 presents per minute, but the elves didn't have body and the boxes were black sometimes. IE 10 only hit 122 presentes per minute, but there were no glitches.
bug 871172 tracks the missing bodies.
Whiteboard: [ietestdrive][jwatt:invalidation] → [ietestdrive][jwatt:invalidation] [in-the-wild]
roc, do you have any thoughts on comment 5?
I think this is worth fixing. Storing layer activity on the element means we would have to know which frame was active. But I suppose we could say that only the primary frame, or the outermost frame, can be active, and that would work well enough. Maybe we could do that, and keep using the NS_FRAME_HAS_LAYER_ACTIVITY_PROPERTY bit on frames, but store LayerActivityProperty on the content node? And, when constructing a frame for a node, if the node has a LayerActivityProperty then add the NS_FRAME_HAS_LAYER_ACTIVITY_PROPERTY bit to the frame if it's the outermost? That would avoid requiring a new content state bit. I guess LayerActivity would hold an content node reference in this case.
I've attached a patch for keeping layer activity alive across reframes of an element to bug 1009478. It's not enough to prevent the tree from repainting after a call to zSortElves(), unfortunately, but it looks like better ThebesLayer recycling (bug 913443) fixes that. After that, the remaining unnecessary repaints are: - The elves themselves are repainted whenever they are reframed - The presents are repainted after they appear because they start out inactive - Sometimes some snow flakes are repainted, I haven't tracked down the cause for that yet.
Depends on: 913443
testcase is gone now.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.