852594 - ReferenceError: mw is not defined @ https://wiki.allizom.org/skins/common/wikibits.js:118

Status: VERIFIED FIXED

(Infrastructure & Operations Graveyard :: WebOps: Other, task)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

Given the below, this might not block bug 707181, but setting just in case.

Just FYI: this is pre-existing on prod, but if we can fix it, we probably should.

STR:

1. Load https://wiki.allizom.org/index.php?title=Special:Search&search=&fulltext=Search&profile=advanced&redirs=1
2. Click on either the "all" or "none" buttons

Actual Results:

Nothing happens

Note that when you load the page, you get:

[10:36:35.518] ReferenceError: mw is not defined @ https://wiki.allizom.org/skins/common/wikibits.js:118

Comment 1

[Mark A. Hershberger (hexmode)]

Adding &debug=1 to the URL results in a ton of 404s for missing js files.

Comment 2

[Mark A. Hershberger (hexmode)]

In prod, the following file is missing: https://wiki.mozilla.org/Resources/mediawiki/mediawiki.user.js

Comment 3

[Jason Crowe [:jd]]

I verified that the files which are generating the 404s are actually on the filesystem. I also found a rewrite that should have included resources (it was getting rewritten to Resources). Now the 404 errors are gone but it looks like the issue remains.

Note that I only deployed this change to dev and stage right now. I will promote the changes to prod after I am reasonably sure it wont break anything.

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to Jason Crowe [:jd] from comment #3)
> I verified that the files which are generating the 404s are actually on the
> filesystem. I also found a rewrite that should have included resources (it
> was getting rewritten to Resources). Now the 404 errors are gone but it
> looks like the issue remains.
> 
> Note that I only deployed this change to dev and stage right now. I will
> promote the changes to prod after I am reasonably sure it wont break
> anything.

http://qa-selenium.mv.mozilla.com:8080/view/Wiki/job/wiki.stage/ - staging looks fine, here (automation passes), if that helps?

Comment 5

[Mark A. Hershberger (hexmode)]

Not seeing the 404s, but I still see the following JS error: "ReferenceError: mw is not defined".

Additionally Chrome complains:

  Resource interpreted as Font but transferred with MIME type application/octet-stream:
  "https://www.mozilla.org/img/fonts/MetaWebPro-Bold.woff". Main_Page:237

Asked for help: https://www.mediawiki.org/wiki/Thread:Project:Support_desk/ReferenceError:_mw_is_not_defined

Comment 6

[Mark A. Hershberger (hexmode)]

Think the js error was caused by improper loading of wikibits left over from the old skin.

New commit should fix this:

https://github.com/mozilla/mediawiki-skins-gmo/commit/0e9a414d98bab1af44b6ba5882b7fa155a47f8ff

Comment 7

[Jason Crowe [:jd]]

I pulled the update to dev and the js error seems to be gone. The issue with the function of the page remains however. Not sure what I need to do at this point to help further... Please advise?

Comment 8

[Mark A. Hershberger (hexmode)]

I still see the JS error.  If you're sure you pulled the latest changes, I'll have to investigate some more.

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Screenshot showing issue is still on dev

Comment 10

[Jason Crowe [:jd]]

I got the correct hash checked out on dev. The ReferenceError is gone. Also I do not see anything but 200s on page load. The issue with the all/none buttons seems to remain, but that may just be my session or browser or something.

Please let me know what you need me to do from here.

Comment 11

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to Jason Crowe [:jd] from comment #10)
> I got the correct hash checked out on dev. The ReferenceError is gone. Also
> I do not see anything but 200s on page load. The issue with the all/none
> buttons seems to remain, but that may just be my session or browser or
> something.
> 
> Please let me know what you need me to do from here.

OK, I can confirm that the JavaScript exception is gone, but the All/None-button issue remains -- sorry that I lumped two bugs in here; Jason, Mark, how should we proceed?

Just file a new, separate bug for the All/None issue?

Comment 12

[Jason Crowe [:jd]]

For my part I am happy to have it in this bug, however I will leave that up to hexmode.

Comment 13

[Jason Crowe [:jd]]

Also FYI I ran this ReferenceError fix through to prod.

Comment 14

[Jason Crowe [:jd]]

After pushing through the fixes that hexmode made today this issue appears to be resolved based on my limited testing, I will close this for now but feel free to reopen or verify as needed.

Thanks everybody.

Comment 15

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED; thanks!