Closed Bug 852967 Opened 9 years ago Closed 9 years ago

Simplify marker selection in text inputs

Categories

(Firefox for Metro Graveyard :: Input, defect)

Product:
Firefox for Metro Graveyard
Component:
Input
Platform:
x86_64
Windows 8.1
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox 22

People

(Reporter: jimm, Assigned: jimm)

References

Details

(Whiteboard: [selection])

Attachments

(2 files)

use selection indexes v.1
2.28 KB, patch
mbrubeck
: review+
Details | Diff | Splinter Review
updated patch to land
9.48 KB, patch
Details | Diff | Splinter Review 
Spun off from bug 848594. This solves bug 852089 for text inputs.
Attachment #727204 - Attachment description: use selection idexes v.1 → use selection indexes v.1
Comment on attachment 727204 [details] [diff] [review]
use selection indexes v.1

Replacing 16 lines of code with 2!
Attachment #727204 - Flags: review?(mbrubeck)
Blocks: 852088
No longer blocks: 852088
Depends on: 852088
Comment on attachment 727204 [details] [diff] [review]
use selection indexes v.1

Review of attachment 727204 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/metro/base/content/contenthandlers/SelectionHandler.js
@@ +800,5 @@
>  
>    /*
>     * Selection control call wrapper
>     */
>    _addEditStartSelection: function _addEditStartSelection() {

Could you give both of these functions better descriptive comments?  A one-liner would be fine.  I just had trouble figuring out what they were for.
Attachment #727204 - Flags: review?(mbrubeck) → review+
absolutely, will do.
I coalesced those two into a single call that takes a param. Also did some additional code re-org and zapped an unused method.
Assignee: nobody → jmathies
Whiteboard: [selection]
https://hg.mozilla.org/mozilla-central/rev/33db8e5b18ef
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 22
OS: Windows 8 Metro → Windows 8.1
You need to log in before you can comment on or make changes to this bug.