852967 - Simplify marker selection in text inputs

Status: RESOLVED FIXED

(Firefox for Metro Graveyard :: Input, defect)

Description

[Jim Mathies [:jimm]]

Attachment: use selection indexes v.1

Spun off from bug 848594. This solves bug 852089 for text inputs.

Comment 1

[Jim Mathies [:jimm]]

Comment on attachment 727204 [details] [diff] [review]
use selection indexes v.1

Replacing 16 lines of code with 2!

Comment 2

[Matt Brubeck (:mbrubeck)]

Comment on attachment 727204 [details] [diff] [review]
use selection indexes v.1

Review of attachment 727204 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/metro/base/content/contenthandlers/SelectionHandler.js
@@ +800,5 @@
>  
>    /*
>     * Selection control call wrapper
>     */
>    _addEditStartSelection: function _addEditStartSelection() {

Could you give both of these functions better descriptive comments?  A one-liner would be fine.  I just had trouble figuring out what they were for.

Comment 3

[Jim Mathies [:jimm]]

absolutely, will do.

Comment 4

[Jim Mathies [:jimm]]

Attachment: updated patch to land

I coalesced those two into a single call that takes a param. Also did some additional code re-org and zapped an unused method.

Comment 5

[Jim Mathies [:jimm]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/33db8e5b18ef

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/33db8e5b18ef