Simplify marker selection in text inputs

RESOLVED FIXED in Firefox 22

Status

Firefox for Metro
Input
RESOLVED FIXED
5 years ago
3 years ago

People

(Reporter: jimm, Assigned: jimm)

Tracking

Trunk
Firefox 22
x86_64
Windows 8.1
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [selection])

Attachments

(2 attachments)

(Assignee)

Description

5 years ago
Created attachment 727204 [details] [diff] [review]
use selection indexes v.1

Spun off from bug 848594. This solves bug 852089 for text inputs.
(Assignee)

Updated

5 years ago
Attachment #727204 - Attachment description: use selection idexes v.1 → use selection indexes v.1
(Assignee)

Comment 1

5 years ago
Comment on attachment 727204 [details] [diff] [review]
use selection indexes v.1

Replacing 16 lines of code with 2!
Attachment #727204 - Flags: review?(mbrubeck)
(Assignee)

Updated

5 years ago
Blocks: 852088
(Assignee)

Updated

5 years ago
No longer blocks: 852088
Depends on: 852088
Comment on attachment 727204 [details] [diff] [review]
use selection indexes v.1

Review of attachment 727204 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/metro/base/content/contenthandlers/SelectionHandler.js
@@ +800,5 @@
>  
>    /*
>     * Selection control call wrapper
>     */
>    _addEditStartSelection: function _addEditStartSelection() {

Could you give both of these functions better descriptive comments?  A one-liner would be fine.  I just had trouble figuring out what they were for.
Attachment #727204 - Flags: review?(mbrubeck) → review+
(Assignee)

Comment 3

5 years ago
absolutely, will do.
(Assignee)

Comment 4

5 years ago
Created attachment 727270 [details] [diff] [review]
updated patch to land

I coalesced those two into a single call that takes a param. Also did some additional code re-org and zapped an unused method.
Assignee: nobody → jmathies
(Assignee)

Updated

5 years ago
Whiteboard: [selection]
(Assignee)

Comment 5

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/33db8e5b18ef
https://hg.mozilla.org/mozilla-central/rev/33db8e5b18ef
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 22
OS: Windows 8 Metro → Windows 8.1
You need to log in before you can comment on or make changes to this bug.