Closed Bug 853337 Opened 12 years ago Closed 12 years ago

Many pictures or even favicons aren't loaded fully after landing patches from bug #716140

Categories

(Core :: Graphics: ImageLib, defect)

Product:
Core
Component:
Graphics: ImageLib
Version:
22 Branch
Platform:
x86_64
Windows 7
Type:
defect
Priority:
Not set
Severity:
major

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla22

People

(Reporter: Virtual, Assigned: joe)

References

Details

(Keywords: nightly-community, regression)

Attachments

(6 files, 1 obsolete file)

many favicons aren't loaded fully in bookmarks bar.png
69.20 KB, image/png
Details
not fully loaded picture.png
357.37 KB, image/png
Details
not fully loaded picture (after some time).png
612.33 KB, image/png
Details
Missing icons
65.25 KB, image/png
Details
Fx (rev-3c2e1408a3c0).png
551.49 KB, image/png
Details
Flush and MarkDirty when we finish a piece of decoding v2
5.17 KB, patch
seth
: review+
Details | Diff | Splinter Review
Assignee: nobody → joe
Just so I'm clear: you're running tinderbox builds?
Oh, also: what happens? "This image cannot be displayed, because it contains errors"? It seems to load properly but doesn't display? Something else entirely?
Flags: needinfo?(BernesB)
I can't reproduce this, even using precisely the build you mentioned, with or without hardware acceleration. :(
(In reply to Joe Drew (:JOEDREW! \o/) from comment #1) > Just so I'm clear: you're running tinderbox builds? Yep I'm using the build I mentioned in first post https://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/mozilla-inbound-win32-pgo/1363784751/firefox-22.0a1.en-US.win32.installer.exe and https://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/mozilla-inbound-win32-pgo/1363795529/firefox-22.0a1.en-US.win32.installer.exe I also tested latest https://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/mozilla-inbound-win32-pgo/1363860342/firefox-22.0a1.en-US.win32.installer.exe (In reply to Joe Drew (:JOEDREW! \o/) from comment #2) > Oh, also: what happens? "This image cannot be displayed, because it contains > errors"? It seems to load properly but doesn't display? Something else > entirely? I attaching screenshots how it looks on my end. Error Console shows nothing.
Flags: needinfo?(BernesB)
Does (after some time) mean leaving the Firefox instance open for a while? Or coming back to the tab after some time?
I minimized Nightly to taskbar, pasting first screenshot to Paint and after about 0,5min I maximize Nightly and this big image painted some more. Oddly small image can be forced to reload properly on switching tabs, but it doesn't work for bug picture. Very very odd bug... ;)
>doesn't work for bug picture. doesn't work for big picture.
Confirmed with cset:a73a2b5c423b http://www.abload.de/img/1ztkua.png http://www.abload.de/img/2gjj5h.png after awhile some images disappear.
(In reply to SpeciesX from comment #11) > Confirmed with cset:a73a2b5c423b > > http://www.abload.de/img/1ztkua.png > http://www.abload.de/img/2gjj5h.png > > after awhile some images disappear. I can't even see my first link. http://www.abload.de/img/3earak.png and after reload with Ctrl+F5 http://www.abload.de/img/4o2o5g.png
Not liking the scaled up icons in the bookmark toolbar and in the sidebars I wrote come css code to reduce them. This code seems to trigger the disappearance of these icons pretty consistently. I run my OS at 120dpi. #bookmarks-view :-moz-tree-image{width: 13px !important;height: 13px !important;} I also get missing or incomplete graphics in web pages. This might be due to using the add-on NoSquint to default all web pages to a full page zoom of 80% and text to 125% to make Fx look like it did before the HiDPI patch. Leaving Fx alone I don't seem to get any missinging icons or graphics. Perhaps what I mentioned will help you recreate the problem.
Attached image Missing icons —
I still can't reproduce this, unfortunately, but I do have at least one theory that I'm testing on Try. Once the build is done, it'll appear here: http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/jdrew@mozilla.com-c5326aa2ca1c Can those affected give it a shot?
(In reply to Joe Drew (:JOEDREW! \o/) from comment #15) > I still can't reproduce this, unfortunately, but I do have at least one > theory that I'm testing on Try. Once the build is done, it'll appear here: > http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/jdrew@mozilla.com- > c5326aa2ca1c > > Can those affected give it a shot? Sure.
(In reply to Joe Drew (:JOEDREW! \o/) from comment #15) > I still can't reproduce this, unfortunately, but I do have at least one > theory that I'm testing on Try. Once the build is done, it'll appear here: > http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/jdrew@mozilla.com- > c5326aa2ca1c > > Can those affected give it a shot? Unfortunately the bug still exist even with this build. http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/jdrew@mozilla.com-c5326aa2ca1c/try-win32/firefox-22.0a1.en-US.win32.installer.exe
and bug didn't occur when I disable hardware acceleration
Can you post your about:support graphics section?
Sure Graphics Adapter Description - NVIDIA GeForce GTX 460 v2 Adapter Drivers - nvd3dumx,nvwgf2umx,nvwgf2umx nvd3dum,nvwgf2um,nvwgf2um Adapter RAM - 1023 Device ID - 0x1205 Direct2D Enabled - true DirectWrite Enabled - true (6.2.9200.16492) Driver Date - 3-14-2013 Driver Version - 9.18.13.1421 GPU #2 Active - false GPU Accelerated Windows - 0/1 Basic Vendor ID - 0x10de WebGL RendererGoogle Inc. -- ANGLE (NVIDIA GeForce GTX 460 v2) AzureCanvasBackend - direct2d AzureContentBackend - none AzureFallbackCanvasBackend - cairo P.S. It's nightmare to stylish properly sth like this... ;) Graphics Adapter DescriptionNVIDIA GeForce GTX 460 v2Adapter Driversnvd3dumx,nvwgf2umx,nvwgf2umx nvd3dum,nvwgf2um,nvwgf2umAdapter RAM1023Device ID0x1205Direct2D EnabledtrueDirectWrite Enabledtrue (6.2.9200.16492)Driver Date3-14-2013Driver Version9.18.13.1421GPU #2 ActivefalseGPU Accelerated Windows0/1 Basic Vendor ID0x10deWebGL RendererGoogle Inc. -- ANGLE (NVIDIA GeForce GTX 460 v2) AzureCanvasBackenddirect2dAzureContentBackendnoneAzureFallbackCanvasBackendcairo
Thanks. With D3D10 I can now reproduce no favicons, though I still can't reproduce any problems in loading regular images.
New build also doesn't work for me. Disabling azure corrects the problem also. Specs Adapter Description AMD Radeon HD 7900 Series Adapter Drivers aticfx64 aticfx64 aticfx64 aticfx32 aticfx32 aticfx32 atiumd64 atidxx64 atidxx64 atiumdag atidxx32 atidxx32 atiumdva atiumd6a atitmm64 Adapter RAM 3072 ClearType Parameters DISPLAY1 [ Gamma: 2200 Pixel Structure: RGB ClearType Level: 100 Enhanced Contrast: 50 ] DISPLAY2 [ Gamma: 2200 Pixel Structure: RGB ClearType Level: 100 Enhanced Contrast: 50 ] Device ID 0x6798 Direct2D Enabled true DirectWrite Enabled true (6.2.9200.16433) Driver Date 3-18-2013 Driver Version 12.100.17.0 GPU #2 Active false GPU Accelerated Windows1/1 Direct3D 10 Vendor ID0x1002 WebGL RendererGoogle Inc. -- ANGLE (AMD Radeon HD 7900 Series) AzureCanvasBackend direct2d AzureContentBackend direct2 AzureFallbackCanvasBackend cairo
http://www.howtogeek.com/ produces missing graphics pretty often for me.
I can easy repo this on this img http://i.imgur.com/a279BpR.jpg (posted in first bug comment) As said, just hit few times Ctrl F5 and img don't load properly. When img. hangs to load and I switch to other tab and back to img. then it is OK again. Looks like something with cache.
(In reply to Semtex from comment #24) > I can easy repo this on this img http://i.imgur.com/a279BpR.jpg (posted in > first bug comment) > As said, just hit few times Ctrl F5 and img don't load properly. > > When img. hangs to load and I switch to other tab and back to img. then it > is OK again. Looks like something with cache. I get the same thing even with azure off so it might be a different problem than missing favicons and web page graphics.
(In reply to Virtual_ManPL [:Virtual] from comment #20) > AzureCanvasBackend - direct2d > AzureContentBackend - none > AzureFallbackCanvasBackend - cairo Awww, sorry, it should be AzureCanvasBackend - direct2d AzureContentBackend - direct2d AzureFallbackCanvasBackend - cairo oddly in my case with Azure disabled it was still reproducible, only with full disabled HW images properly loads
I cannot repo the partial loading of the images listed so far in this bug, all load fully and instantly. Graphics Adapter Description ATI Radeon HD 3200 Graphics Adapter Drivers aticfx64 aticfx64 aticfx32 aticfx32 atiumd64 atidxx64 atiumdag atidxx32 atiumdva atiumd6a atitmm64 Adapter RAM 256 ClearType Parameters DISPLAY1 [ Gamma: 2200 Pixel Structure: RGB ClearType Level: 100 Enhanced Contrast: 300 ] DISPLAY4 [ Gamma: 2200 Pixel Structure: RGB ClearType Level: 100 Enhanced Contrast: 50 ] Device ID 0x9610 Direct2D Enabled true DirectWrite Enabled true (6.2.9200.16492) Driver Date 7-28-2011 Driver Version 8.881.0.0 GPU #2 Active false GPU Accelerated Windows 1/1 Direct3D 10 Vendor ID 0x1002 WebGL Renderer Google Inc. -- ANGLE (ATI Radeon HD 3200 Graphics) AzureCanvasBackend direct2d AzureContentBackend none AzureFallbackCanvasBackend cairo NOTE: I do have azure.content 'disabled'
This site always has tons of images per page, all loaded here without issue: http://englishrussia.com/2013/02/25/army-of-belarus/
(In reply to Jim Jeffery not reading bug-mail 1/2/11 from comment #28) > This site always has tons of images per page, all loaded here without issue: > > http://englishrussia.com/2013/02/25/army-of-belarus/ Seems that only the first image get's partially loaded while all the others are all complete. Could be I need to test longer. So in my case disabling azure fixed the problem of missing icons in the chrome, like bookmarks on the toolbar and bookmarks in the sidebar. History also in the sidebar. Images not appearing at all is also fixed by disabling azure. The partial loading of pictures and such within the content could be another issue. I've also been having the problem mentioned in this bug https://bugzilla.mozilla.org/show_bug.cgi?id=837489 which also disappears if I disable azure. Could this be related?
Bas, it seems like some of the time D2D-Azure (combined with latest mozilla-central) is making images show up blank or partially blank. I can definitely reproduce the blank behaviour on favicons in the search bar, but it happens all over the place. Do you have any suggestions on where I should look? Disabling imgFrame::Optimize made no difference.
Flags: needinfo?(bas)
Status: UNCONFIRMED → NEW
Ever confirmed: true
I should mention that we're at least trying to draw; I traced down into moz2d code and everything looked normal.
FWIW, I can repro the Issue (corrupt Content Images) reliably by loading this Webcam URL: http://217.70.192.23:8090/cgi-bin/image.jpg?&date=5 If you switch forth and back between Tabs the Content Image gets rendered correctly. After some Playing with Prefs (layers, gfx, azure) only gfx.direct2d.disabled;true made the Issue go away. Using a ATI Radeon HD 4850 on Win 7 x64.
There seems to be two flavors of what's going on. 1. Disappearing icons from the bookmarks toolbar and the bookmarks/history sidebar. Also some graphics on web pages do not display at all. 2. Partial loading of graphics. Sometimes they have black where the rest of the picture should be. Sometimes they load in pieces given enough time. #1 can be fixed by turning off azure. #2 can be fixed by disabling d2d which of course disables HWA. I think disabling d2d also fixes #1. These are my observations.
I'm able to reproduce on http://www.ctvnews.ca/video below the video, you will see thumbnails. Below that, you will also see links by which you can page through for more videos. Some of the thumbnails will be either partially or not rendered at all. It's not so bad with the first page of thumbnails but is worse with the others.
This was actually worse after the respin, all images won't load. Avatars on Forums , even toolbar Icons on forums. If HWA is turned off The Problem goes away. This needs to be fixed.
Flags: needinfo?(bas)
Please never touch needinfo if you're not providing that information.
Flags: needinfo?(bas)
FWIW, I tried the Tryserver Build of Bug 853628 you spun (http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/jdrew@mozilla.com-fc8231ce13e1/try-win32/) and the Image Issue remains. Maybe others (Gary?) with the Chrome Icons Issue can try too and report over there so this can get separated?!
(In reply to XtC4UaLL [:xtc4uall] from comment #37) > FWIW, I tried the Tryserver Build of Bug 853628 you spun > (http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/jdrew@mozilla.com- > fc8231ce13e1/try-win32/) and the Image Issue remains. > > Maybe others (Gary?) with the Chrome Icons Issue can try too and report over > there so this can get separated?! Bug 853628 is about Cocoa widget code, which is Mac only.
Image scaling seems to be involved somehow. I had a page with tiny invisible images. I right-clicked on one and chose "view image" to open it in a new tab. It was blank (white box). Then I zoomed it in, it appeared. When I reset the zoom, it disappeared. It was consistent - at some scaling levels (including but not limited to 100%) it was always invisible, at some other scaling levels it was always visible. Hopefully this gives some clue as to what's going on...
I've found the following simpler way to make the image appear, which makes me suspect it may be a bad interaction with dlbi: Simply grap the affected tab and drag it even the slightest amount along the tab bar. The images render immediately.
Seems I posted too soon. Comment 40 does not work in the case of the CTV News page of comment 34 (not sure if it's being affected by the Flash or the JavaScript), but it does work for most other pages I've tried.
Matt: Any ideas what may be going on here? My experiences look similar to what I've seen before (i.e bug 795722) after dlbi landed.
Flags: needinfo?(matt.woodrow)
http://www.sevenforums.com/ Images and Avatars, signatures do not open or they only open 1/2 way. A page refresh does nothing. Even at Mozzillazine Avatars and buttons do not display.
This has nothing to do with DLBI. We aren't marking frames as dirty like we used to. That turns out to be easy to fix; a tryserver build will appear at http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/jdrew@mozilla.com-3c2e1408a3c0 in a couple of hours.
Flags: needinfo?(matt.woodrow)
Flags: needinfo?(bas)
We used to lock and unlock frames whenever we did pieces of decoding, which implicitly Flush and MarkDirty on the surfaces. That's no longer the case, so we need to do the Flush and MarkDirty manually. This patch does that.
Attachment #728211 - Flags: review?(seth)
Sad to report, that the issue remains, just installed the try-build win32 running on win7 x64 and I can still repo the partial loaded images.
(In reply to Jim Jeffery not reading bug-mail 1/2/11 from comment #47) > Sad to report, that the issue remains, just installed the try-build win32 > running on win7 x64 and I can still repo the partial loaded images. For me it's fixed with that Build.
Seems that pref gfx.content.azure.enabled set to 'false' is contributing some to this issue. I have it set to 'false' as a work-around for bug 812695 (MS pre-req patch for IE10) to clear up the font problem that seems to affect ATI/AMD cards. Setting gfx.content.azure.enabled back to default, I can't seem to repo the partial paints. *sigh*
I've just discovered, perhaps late to the party if already mentioned, but once you hit an image that is partial loaded switching away from the tab for 15secs or so and then back the image will be filled and display properly. Is something with image-discard coming into play here perhaps ? I know while back there was a patch to 'unload' images after a period of time and reload on revisit or some such.
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:22.0) Gecko/20130322 Firefox/22.0 ID:20130322072742 CSet: 3c2e1408a3c0 The trybuild doesn't work fix the bug for me either. Graphics Adapter Description AMD Radeon HD 6800 Series Adapter Drivers aticfx64 aticfx64 aticfx64 aticfx32 aticfx32 aticfx32 atiumd64 atidxx64 atidxx64 atiumdag atidxx32 atidxx32 atiumdva atiumd6a atitmm64 Adapter RAM 1024 ClearType Parameters Gamma: 2200 Pixel Structure: RGB ClearType Level: 100 Enhanced Contrast: 100 Device ID 0x6739 Direct2D Enabled true DirectWrite Enabled true (6.2.9200.16492) Driver Date 12-19-2012 Driver Version 9.12.0.0 GPU #2 Active false GPU Accelerated Windows 1/1 Direct3D 10 Vendor ID 0x1002 WebGL Renderer Google Inc. -- ANGLE (AMD Radeon HD 6800 Series) AzureCanvasBackend direct2d AzureContentBackend direct2d AzureFallbackCanvasBackend cairo
No luck with the try build here either. I -think- it improved matters a little during the loading of large images, but the final redraw doesn't get triggered or something. At least, I've seen a few progressive JPEGs get stuck on the penultimate pass (until moving the tab as someone suggested). However, I've also seen images be completely black after loading them in a background tab. I didn't play with the discard timeout yet. Adapter Description: NVIDIA GeForce GTX 580 Adapter Drivers: nvd3dumx,nvwgf2umx,nvwgf2umx nvd3dum,nvwgf2um,nvwgf2um Adapter RAM: 1535 Device ID: 0x1080 Direct2D Enabled: true DirectWrite Enabled: true (6.2.9200.16492) Driver Date: 2-9-2013 Driver Version: 9.18.13.1407 GPU #2 Active: false GPU Accelerated Windows: 1/1 Direct3D 10 Vendor ID: 0x10de WebGL Renderer: Google Inc. -- ANGLE (NVIDIA GeForce GTX 580) AzureCanvasBackend: direct2d AzureContentBackend: direct2d AzureFallbackCanvasBackend: cairo
Can anyone comment on whether changing the pref image.high_quality_downscaling.enabled to false affects things at all?
Not for me.
This bug have also impact on toolbar addons icons, I use Gmail Watcher with changed default icon, Stylish code, so when HWA On I don't see icon, HWA off icon appear as usual. Screen: http://wstaw.org/m/2013/03/22/hwa.png Problem touch also other extensions, mention here: http://forums.mozillazine.org/viewtopic.php?f=23&t=2682101&start=45 posted by: @smsmith at Posted 22 Mar 2013, 17:25 (In reply to Joe Drew (:JOEDREW! \o/) from comment #53) > Can anyone comment on whether changing the pref > image.high_quality_downscaling.enabled to false affects things at all? Not helping
(In reply to Joe Drew (:JOEDREW! \o/) from comment #45) > That turns out to be easy > to fix; a tryserver build will appear at > http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/jdrew@mozilla.com- > 3c2e1408a3c0 in a couple of hours. Bug still remains with this test try-build. (In reply to Joe Drew (:JOEDREW! \o/) from comment #53) > Can anyone comment on whether changing the pref > image.high_quality_downscaling.enabled to false affects things at all? Nope, it not helps at all.
Slight modification of this patch was needed; we didn't have an mCurrentFrame to mark dirty in a lot of cases.
Attachment #728211 - Attachment is obsolete: true
Attachment #728211 - Flags: review?(seth)
Attachment #728391 - Flags: review?(seth)
Comment on attachment 728391 [details] [diff] [review] Flush and MarkDirty when we finish a piece of decoding v2 Review of attachment 728391 [details] [diff] [review]: ----------------------------------------------------------------- Looks good. In a perfect world it'd be nice if either Decoder or RasterImage was responsible for calling MarkFrameDirty all the time, instead of the work being divided between the two of them.
Attachment #728391 - Flags: review?(seth) → review+
(In reply to Joe Drew (:JOEDREW! \o/) from comment #59) > Try run: > http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/jdrew@mozilla.com- > c3ff25a2d480 For me it's fixed with that Build.
It's sort of fixed for me. Sometimes the favicons will not appear until a second or so until Fx loads. Sometimes it is right away. Also if I refresh a picture you can sometimes see black appear at the bottom of the picture for a split second. I guess this is the same black that was seen when a picture was partially loaded.
Here's a picture that does what I mentioned above: http://upload.wikimedia.org/wikipedia/commons/2/23/Drymoreomys_albimaculatus_002.jpg Make sure you do the refresh that doesn't get the picture from the cache.
The picture loading is definitely better than before this patch. I'm wondering if what I am seeing now is the way it worked before the patch that started all of this.
The latest try build fixed the problems I was seeing. (AMD HD6000 series, Win8 x86, D2D/D3D10, Azure)
(In reply to Joe Drew (:JOEDREW! \o/) from comment #59) > Try run: > http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/jdrew@mozilla.com- > c3ff25a2d480 Looks fixed with this try-build I can also confirm this issue, but for me was only on some first Fx runs, but after clearing cache and removing cache folder it didn't occur anymore. Odd... (In reply to Gary [:streetwolf] from comment #62) > Sometimes the favicons will not appear until a second or so until Fx loads. > Sometimes it is right away.
Cleared my cache and folder and started with a new one. Things seem smoother now.
Just read this was backed out of m-i.
https://hg.mozilla.org/mozilla-central/rev/550cbc825042
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Thanks! Verified with latest hourly Nightly
Status: RESOLVED → VERIFIED
Potential dupe : bug 854156
OK, I can assume from what I'm reading, the fix has been backed out, which is why I'm seeing this issue on my current Nightly?
Incorrect. This bug's status is VERIFIED FIXED, which means a patch was checked in has been confirmed to fix this issue. (You're right that it was backed out, but then an improved fix was checked in, and there haven't been any backouts since then.) If you're seeing something like this issue on current nightly, please file a new bug here: https://bugzilla.mozilla.org/enter_bug.cgi?product=Core&component=ImageLib and please include the contents of the "User Agent" field from Help | Troubleshooting Information.
Well, I found a new update waiting to be restarted, and the problem seems to be fixed again, at least in this new build. So, I was correct on the version that I was using when I posted my comment (and there were no updates waiting for me, I specifically checked), but the improved fix is in now that I did receive an update, and from now on, hopefully, I shouldn't see the problem again. ;)
Mozilla/5.0 (X11; Linux i686; rv:22.0) Gecko/20130404 Firefox/22.0 If I Ctrl+F5 fast enough several times I can sometimes see the message from comment 2 displayed on screen while the page is loading (but the picture is always displayed in the end). Used a image from comment 0. It's not anything major or actually discoverable by a regular user, but I'm wondering if the error might still occur in some cases given that.
Depends on: 932277
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: