The default bug view has changed. See this FAQ.

Use a nicer icon for the new "New Mail" notification.

RESOLVED FIXED in Thunderbird 23.0

Status

Thunderbird
Theme
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: Paenglab, Assigned: Paenglab)

Tracking

(Blocks: 1 bug)

unspecified
Thunderbird 23.0

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments, 2 obsolete attachments)

(Assignee)

Description

4 years ago
On OS X TB is now using the new notifications. The actual icon is looking a little bit out of place.

This bug is to replace it with a better looking one.
(Assignee)

Comment 1

4 years ago
Created attachment 727780 [details] [diff] [review]
patch

Nicer icon

Andreas, I took you because bwinton liked the new icon already and he wants someone without bias to review it :)
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #727780 - Flags: ui-review?(bugs)
Attachment #727780 - Flags: review?(bugs)
(Assignee)

Comment 2

4 years ago
Created attachment 727781 [details]
screenshot

Screenshot for easier ui-r
(Assignee)

Comment 3

4 years ago
Created attachment 727785 [details]
SVG file

SVG file for the repository.

Or if you think it needs some tweaking, you have the file to change it.

Updated

4 years ago
Blocks: 856759
Slightly skeptical of the tilting, but I like the flat colors.
How would it look straight on?
(Assignee)

Comment 5

4 years ago
Created attachment 738905 [details] [diff] [review]
Use the application icons

Over IRC we decided to use the application icons like it's system standard.

This patch copies the branding icon to new-mail-alert.png which is then used for the toolkit notification.
I copy the icon in branding jar.mn because I see no way how to reference the icon in theme jar.mn. For nightly it's in /mail/branding/nightly, for Aurora in /mail/branding/aurora and for Release (and Beta?) it's in /other-licenses/branding/thunderbird. If it would be always on the same position during build I could use this position.
Attachment #727780 - Attachment is obsolete: true
Attachment #727780 - Flags: ui-review?(bugs)
Attachment #727780 - Flags: review?(bugs)
Attachment #738905 - Flags: ui-review?(bwinton)
Attachment #738905 - Flags: review?(bwinton)
(Assignee)

Comment 6

4 years ago
Created attachment 738906 [details]
screenshot with application icons

This screenshot shows the notification with the three application icons.
Attachment #727781 - Attachment is obsolete: true
(Assignee)

Comment 7

4 years ago
A try build is available here: http://ftp.mozilla.org/pub/mozilla.org/thunderbird/try-builds/richard.marti@gmail.com-1847e11e8f95
Looks great!
Comment on attachment 738905 [details] [diff] [review]
Use the application icons

Looks good!  r=me, ui-r=me.

Thanks,
Blake.
Attachment #738905 - Flags: ui-review?(bwinton)
Attachment #738905 - Flags: ui-review+
Attachment #738905 - Flags: review?(bwinton)
Attachment #738905 - Flags: review+
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
OS: Mac OS X → All
https://hg.mozilla.org/comm-central/rev/1ae201906fed
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 24.0
Target Milestone: Thunderbird 24.0 → Thunderbird 23.0
You need to log in before you can comment on or make changes to this bug.