853609 - (Win8 and Win2k8 machines) Please deploy _dumbwin32proc.py to the right place

Status: RESOLVED FIXED

(Infrastructure & Operations :: RelOps: General, task)

Description

[Armen [:armenzg]]

Recently, in bug 798170 we have deployed _dumbwin32proc.py to the right places on our win7, winxp and win64 machines. This allows buildbot to kill jobs when stopped through web UI.

We need to deploy this to the win8 machines as well and I would like to use GPO to deploy it rather than having to manually log in into all machines (besides we need it for future re-imaging).

These are the steps taken as Administrator:
cd C:\mozilla-build\buildbotve\Lib\site-packages\twisted\internet
del _dumbwin32proc.pyc
move _dumbwin32proc.py _dumbwin32proc.py.bak
C:\mozilla-build\wget\wget.exe -q --no-check-certificate https://hg.mozilla.org/build/opsi-package-sources/raw-file/e55c081cb8cf/twisted_dumbwin32proc/CLIENT_DATA/_dumbwin32proc.py

We also need the same change to be added to the task sequence for our Win64-ix builders.

Thanks in advance!

Comment 1

[Q]

Replaced on the WDS server so we should be set for the next re-image. I will set the file to go out to the Win 8 machines on Monday.

Comment 2

[Armen [:armenzg]]

(In reply to Q from comment #1)
> Replaced on the WDS server so we should be set for the next re-image. I will
> set the file to go out to the Win 8 machines on Monday.

Q++!! Thanks!

Comment 3

[Q]

File going out to win 8 boxes!

Comment 4

[Q]

All set.

Comment 5

[Armen [:armenzg]]

You rock! Thanks!

Comment 6

[Armen [:armenzg]]

I've found that t-w864-ix-001 does not have this change. Is it because it is on the loaner DC? (was DC the correct term?)

t-w84-ix-003 seems to be fine.

On another note, I noticed that I can't ssh into t-w864-ix-002.


C:\Users\cltbld.T-W864-IX-001>cd C:\mozilla-build\buildbotve\Lib\site-packages\twisted\internet

C:\mozilla-build\buildbotve\Lib\site-packages\twisted\internet>C:\mozilla-build\wget\wget.exe -q --no-check-certificate https://hg.mozilla.org/build/opsi-package-sources/raw-file/e55c081cb8cf/twisted_dumbwin32proc/CLIENT_DATA/_dumbwin32proc.py

C:\mozilla-build\buildbotve\Lib\site-packages\twisted\internet>diff -pU 8 _dumbwin32proc.py _dumbwin32proc.py.1
--- _dumbwin32proc.py   2013-01-17 15:02:07 -0800
+++ _dumbwin32proc.py.1 2013-05-09 15:15:36 -0700
@@ -233,18 +233,17 @@ class Process(_pollingfile._PollingTimer

         self._addPollableResource(_Reaper(self))


     def signalProcess(self, signalID):
         if self.pid is None:
             raise error.ProcessExitedAlready()
         if signalID in ("INT", "TERM", "KILL"):
-            win32process.TerminateProcess(self.hProcess, 1)
-
+            os.popen('taskkill /T /F /PID %s' % self.pid)

     def _getReason(self, status):
         if status == 0:
             return error.ProcessDone(status)
         return error.ProcessTerminated(status)


     def write(self, data):

Comment 7

[Q]

Fixed for the Loaner OU

Comment 8

[Q]

This is now covered in both GPO and in the install TS for all OSes