Closed Bug 855073 Opened 7 years ago Closed 7 years ago
Add information to needinfo email
Currently the emails generated by needinfo flags say something like this: >>> David Lawrence [:dkl] <email@example.com> has asked Liz Henry :lizzard <firstname.lastname@example.org> for needinfo: Bug 851196: Add options to My Dashboard dropdown: to review, to nag, to check in https://bugzilla.mozilla.org/show_bug.cgi?id=851196 ------- Additional Comments from David Lawrence [:dkl] <email@example.com> need more information from lizzard <<< I would like to add something like this to that message, probably at the end: >>> This request has set a needinfo flag on the bug. You can clear it by logging in and replying in a comment at https://bugzilla.mozilla.org/show_bug.cgi?id=851196 . <<< The point of that is to explain, in the email, to a new-to-Bugzilla user how they can stop getting these reminders (which they can get even after the bug is closed). It says it at the bottom of the show_bug form, but it bears repeating in email.
Assignee: nobody → glob
OS: Mac OS X → All
Hardware: x86 → All
i used the existing hook, so the placement of the message is slightly different from liz's request: > Byron Jones ‹:glob› <firstname.lastname@example.org> has asked Test Account > <email@example.com> for needinfo: > Bug 675544: Current 6.0 beta is on "default" channel update > http://fedora/855073/show_bug.cgi?id=675544 > --- > --- This request has set a needinfo flag on the bug. > --- You can clear it by logging in and replying in a comment. > --- > > ------- Additional Comments from Byron Jones ‹:glob› <firstname.lastname@example.org> > i need more info!
Attachment #730007 - Flags: review?(dkl)
Comment on attachment 730007 [details] [diff] [review] patch v1 Review of attachment 730007 [details] [diff] [review]: ----------------------------------------------------------------- I would really have liked to see an extra newline above the new text but I fell short of figuring out the best way to accomplish that when I was also hacking a patch for this yesterday. The [%- Hook.process('after_summary') -%] kept removing my new line no matter what I tried. If you know how to do the same, fix on commit, otherwise it is not a big deal. Also fix the conditional suggestion on commit. r=dkl ::: extensions/BMO/template/en/default/hook/request/email-after_summary.txt.tmpl @@ +5,5 @@ > + # This Source Code Form is "Incompatible With Secondary Licenses", as > + # defined by the Mozilla Public License, v. 2.0. > + #%] > + > +[% RETURN UNLESS flagtype_name == 'needinfo' %] We should only display if the status == '?' as this comment doesn't apply when the needinfo flag is being cleared or granted. [% RETURN UNLESS flagtype.name == 'needinfo' && flag.status == '?' %]
Attachment #730007 - Flags: review?(dkl) → review+
because bugzilla uses PRE_CHOMP, you can't insert blank lines at the start of a template :( Committing to: bzr+ssh://email@example.com/bmo/4.2/ added extensions/Needinfo/template/en/default/hook/request added extensions/Needinfo/template/en/default/hook/request/email-after_summary.txt.tmpl Committed revision 8701.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.