855513 - WIFI is not re-enabled when internet sharing is getting stopped and WIFI was enabled before

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Wifi, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 10/02 - 10/06)]

We do not re-enable WIFI when the user stops internet sharing, and wifi was enabled before. That will force you to always have to go back into the wifi settings to turn on wifi again. We should only do this when wifi was turned on before.

Steps:
1. Turn on WIFI and connect to a network
2. Enable internet sharing
3. Disable internet sharing

After step 3 we do not automatically connect to the WIFI network used before. This is done by Android, and probably other platforms.

Comment 1

[Vincent Liu[:vliu]]

I think we should have more control behavior betweeen handleWifiEnabled and handleWifiTetheringEnabled. I can come out a patch to ask for more info.

Comment 2

[Daniel Coloma:dcoloma]

I don't think we should hold the release because of that as user has all the information to detect the issue and activate WiFi manually

Comment 3

[Vincent Liu[:vliu]]

Attachment: Patch V1

Hi vchang,

I created a patch to fix this bug. Can you please review it? Thanks.

Comment 4

[Vincent Chang[:vchang][changyihsin]]

Comment on attachment 732210 [details] [diff] [review]
Patch V1

Review of attachment 732210 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.

Please remove trail blank before commit the patch. r=me with that fixed. 
Please also help to test if there is any side effect if we turn on/off Wifi and Wifi Hotspot repeatedly.

Comment 5

[Vincent Liu[:vliu]]

Attachment: Patch V2

(In reply to Vincent Chang[:vchang] from comment #4)
> Comment on attachment 732210 [details] [diff] [review]
> Patch V1
> 
> Review of attachment 732210 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Looks good.
> 
> Please remove trail blank before commit the patch. r=me with that fixed. 
> Please also help to test if there is any side effect if we turn on/off Wifi
> and Wifi Hotspot repeatedly.

Thanks for the review. Removed trail blank for the patch. r=me.

Comment 6

[Vincent Liu[:vliu]]

try result:

https://tbpl.mozilla.org/?tree=Try&rev=8bbada6952d7
https://tbpl.mozilla.org/?tree=Try&rev=51d72dcdc09b

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/312ea5e42aef

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/312ea5e42aef

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 10/02 - 10/06)]

Can we ask to get this backported to b2g18? It's a kinda annoying issue and already fixed about 2 month on master.

Comment 12

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 10/02 - 10/06)]

It will be too late for leo, but could we get this feature into koi?

Comment 13

[Ray REN]

Hi Vincent, 
For your patch https://hg.mozilla.org/mozilla-central/rev/312ea5e42aef, there are something we don't think is write behavior, please help check, thanks.

1. turn on hotspot,
2. turn on WiFi, the hotspot turn off.
3. turn off WiFi,  the hotspot turn on.------->KO.

We don't think step 3 is OK, maybe you could check android's behavior.

Comment 14

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

(In reply to Ray REN from comment #13)
> Hi Vincent, 
> For your patch https://hg.mozilla.org/mozilla-central/rev/312ea5e42aef,
> there are something we don't think is write behavior, please help check,
> thanks.
> 
> 1. turn on hotspot,
> 2. turn on WiFi, the hotspot turn off.
> 3. turn off WiFi,  the hotspot turn on.------->KO.
> 
> We don't think step 3 is OK, maybe you could check android's behavior.

I think the patch is fine.
The cause of your problem might be sync issue of request queue, as same as bug 906631.

Comment 15

[Ray REN]

(In reply to Chuck Lee [:chucklee] from comment #14)
> I think the patch is fine.
> The cause of your problem might be sync issue of request queue, as same as
> bug 906631.

I don't mean the patch has something error.
I want to know why you turn on hotspot when turn off wifi ? Is your spec design or by your ideas? For android's behavior,the hotspot doesn't turn on itself.

Comment 16

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

(In reply to Ray REN from comment #15)
> (In reply to Chuck Lee [:chucklee] from comment #14)
> > I think the patch is fine.
> > The cause of your problem might be sync issue of request queue, as same as
> > bug 906631.
> 
> I don't mean the patch has something error.
> I want to know why you turn on hotspot when turn off wifi ? Is your spec
> design or by your ideas? For android's behavior,the hotspot doesn't turn on
> itself.

I think it's designed to do so, to restore previous wifi status.

Comment 17

[Ray REN]

(In reply to Chuck Lee [:chucklee] from comment #16)

> I think it's designed to do so, to restore previous wifi status.

We also think wifi status should been restored, but we dosen't think hotspot status  need to restored, it is not useful

Comment 18

[Ray REN]

dear Vincent and Chuck，

For this patch, we don't know who(wifi/airplane/hotspot) turn on/off wifi,when we setWifiEnabled in gecko, So it cause new problems as follows, please help check. Thanks
The reproduce step:
1.turn on wifi
2.turn on hotspot
3.turn on airlpane model via systembar, find wifi will turn on itself-----> KO.

Comment 19

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Airplane mode is controlled by Gaia, and it seems the wifi state doesn't sync between Gaia and Gecko.
I'll look into this, please also report a new bug for this issue instead of discussing in a closed bug, thanks.

Comment 20

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

(In reply to Ray REN from comment #18)
> dear Vincent and Chuck，
> 
> For this patch, we don't know who(wifi/airplane/hotspot) turn on/off
> wifi,when we setWifiEnabled in gecko, So it cause new problems as follows,
> please help check. Thanks
> The reproduce step:
> 1.turn on wifi
> 2.turn on hotspot
> 3.turn on airlpane model via systembar, find wifi will turn on itself----->
> KO.

Reported as Bug 917097.

Comment 21

[Jason Smith [:jsmith]]

This already landed in time for 1.2, so no need to nominate for koi at this point.