855900 - Change Profiler shortcut to Shift-F5 in Aurora

Status: RESOLVED FIXED

(DevTools :: Performance Tools (Profiler/Timeline), defect, P3)

Description

[Anton Kovalyov (:anton)]

Profiler shortcut had been changed to Shift-F5 in Nightlies but is still Ctrl-Shift-Y in Aurora which means that Linux users in Aurora won't be able to use it (it opens Library). This bug is to land the change directly into the Aurora channel.

Comment 1

[Anton Kovalyov (:anton)]

Attachment: Change Profiler shortcut to Shift-F5

Patch from bug 843559 (applied to the Aurora tree and made sure it works and all tests pass).

Comment 2

[Dave Camp (:dcamp)]

Comment on attachment 730965 [details] [diff] [review]
Change Profiler shortcut to Shift-F5

I'm OK with this, although localization might have a different opinion.

Comment 3

[Anton Kovalyov (:anton)]

Comment on attachment 730965 [details] [diff] [review]
Change Profiler shortcut to Shift-F5

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 830668
User impact if declined: Linux users won't be able to use keyboard shortcut to toggle the Profiler (it will open the Library instead).
Testing completed (on m-c, etc.): Local. Basic smoke-tests and unit tests.
Risk to taking this patch (and alternatives if risky): None as I can see. Shift-F5 is not used by Firefox on any platforms we tested (OS X, Linux and Windows).
String or IDL/UUID changes made by this patch:

Comment 4

[Dave Camp (:dcamp)]

(In reply to Anton Kovalyov (:anton) from comment #3)
> [Approval Request Comment]
> String or IDL/UUID changes made by this patch:

There's a keycode-value string change here.

Comment 5

[Anton Kovalyov (:anton)]

String or IDL/UUID changes made by this patch: profiler.commandkey

Comment 6

[:Gavin Sharp [email: [e-mail]]]

Localizers aren't likely to notice the change unless you also change the entity name (though I guess that only matters for localizers tracking aurora - a minority, I think). A better option might be to avoid making this shortcut localizable, at least for this cycle.

Comment 7

[Anton Kovalyov (:anton)]

Attachment: Change Profiler shortcut to Shift-F5

Updated the patch to hard-code new shortcut in Aurora.

Comment 8

[Axel Hecht [:Pike]]

Not localizing this should be fine.

For the record, most locales are tracking aurora as their primary localization target.

Comment 9

[:Gavin Sharp [email: [e-mail]]]

Given that we're merging today, we need to uplift this further, right?

Comment 10

[Anton Kovalyov (:anton)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/1f391ee6d07e

Comment 11

[j.j.]

Needs documentation!
The profiler shortcut is now Shift-F5 on all platforms, starting with Firefox 21, right?

Comment 12

[Mihaela Velimiroviciu (:mihaelav)]

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:21.0) Gecko/20100101 Firefox/21.0
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:21.0) Gecko/20100101 Firefox/21.0
Mozilla/5.0 (X11; Linux i686; rv:21.0) Gecko/20100101 Firefox/21.0
BuildID: 20130401192816 

Verified on latest Firefox 21 build 1: Shift-F5 open/closes JS Profiler.

Comment 13

[Ioana (away)]

Verified as fixed on Windows 7 64bit, Mac OSX 10.7 and Ubuntu 13.04 32bit, using Firefox 22b2 (20130521223249).

Comment 14

[Will Bamberg [:wbamberg]]

Documented:
https://developer.mozilla.org/en-US/docs/Tools/Keyboard_shortcuts#Opening_and_closing_tools
https://developer.mozilla.org/en-US/docs/Tools/Performance#Opening_the_Performance_tool

...so marking as dev-doc-complete