Change Profiler shortcut to Shift-F5 in Aurora

RESOLVED FIXED

Status

defect
P3
normal
RESOLVED FIXED
6 years ago
Last year

People

(Reporter: anton, Assigned: anton)

Tracking

({dev-doc-complete})

21 Branch

Firefox Tracking Flags

(firefox21 verified, firefox22+ verified)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Assignee

Description

6 years ago
Profiler shortcut had been changed to Shift-F5 in Nightlies but is still Ctrl-Shift-Y in Aurora which means that Linux users in Aurora won't be able to use it (it opens Library). This bug is to land the change directly into the Aurora channel.
Assignee

Comment 1

6 years ago
Patch from bug 843559 (applied to the Aurora tree and made sure it works and all tests pass).
Assignee: nobody → anton
Status: NEW → ASSIGNED
Attachment #730965 - Flags: review?(past)
Attachment #730965 - Flags: review?(dcamp)
Comment on attachment 730965 [details] [diff] [review]
Change Profiler shortcut to Shift-F5

I'm OK with this, although localization might have a different opinion.
Attachment #730965 - Flags: review?(dcamp) → review+
Assignee

Comment 3

6 years ago
Comment on attachment 730965 [details] [diff] [review]
Change Profiler shortcut to Shift-F5

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 830668
User impact if declined: Linux users won't be able to use keyboard shortcut to toggle the Profiler (it will open the Library instead).
Testing completed (on m-c, etc.): Local. Basic smoke-tests and unit tests.
Risk to taking this patch (and alternatives if risky): None as I can see. Shift-F5 is not used by Firefox on any platforms we tested (OS X, Linux and Windows).
String or IDL/UUID changes made by this patch:
Attachment #730965 - Flags: review?(past) → approval-mozilla-aurora?
(In reply to Anton Kovalyov (:anton) from comment #3)
> [Approval Request Comment]
> String or IDL/UUID changes made by this patch:

There's a keycode-value string change here.
Assignee

Comment 5

6 years ago
String or IDL/UUID changes made by this patch: profiler.commandkey
Localizers aren't likely to notice the change unless you also change the entity name (though I guess that only matters for localizers tracking aurora - a minority, I think). A better option might be to avoid making this shortcut localizable, at least for this cycle.
Assignee

Comment 7

6 years ago
Updated the patch to hard-code new shortcut in Aurora.
Attachment #730965 - Attachment is obsolete: true
Attachment #730965 - Flags: approval-mozilla-aurora?
Attachment #731377 - Flags: review?(gavin.sharp)
Attachment #731377 - Flags: review?(dcamp)
Not localizing this should be fine.

For the record, most locales are tracking aurora as their primary localization target.

Updated

6 years ago
Attachment #731377 - Flags: review?(dcamp) → review+
Attachment #731377 - Flags: review?(gavin.sharp) → review+
Given that we're merging today, we need to uplift this further, right?
Summary: Change Profiler shortcut to Shift-F5 in Aurora → Change Profiler shortcut to Shift-F5 in Beta/Aurora
Attachment #731377 - Flags: approval-mozilla-aurora+
Assignee

Comment 10

6 years ago
https://hg.mozilla.org/releases/mozilla-aurora/rev/1f391ee6d07e
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Assignee

Updated

6 years ago
Summary: Change Profiler shortcut to Shift-F5 in Beta/Aurora → Change Profiler shortcut to Shift-F5 in Aurora
Assignee

Updated

6 years ago

Comment 11

6 years ago
Needs documentation!
The profiler shortcut is now Shift-F5 on all platforms, starting with Firefox 21, right?
Keywords: dev-doc-needed
OS: Mac OS X → All
Hardware: x86 → All
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:21.0) Gecko/20100101 Firefox/21.0
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:21.0) Gecko/20100101 Firefox/21.0
Mozilla/5.0 (X11; Linux i686; rv:21.0) Gecko/20100101 Firefox/21.0
BuildID: 20130401192816 

Verified on latest Firefox 21 build 1: Shift-F5 open/closes JS Profiler.

Comment 13

6 years ago
Verified as fixed on Windows 7 64bit, Mac OSX 10.7 and Ubuntu 13.04 32bit, using Firefox 22b2 (20130521223249).

Updated

Last year
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.