856049 - Defect - Lower border of "Pair a device" input box is missing

Status: VERIFIED FIXED

(Firefox for Metro Graveyard :: Sync, defect, P1)

Description

[Virgil Dicu [:virgil] [QA]]

Attachment: Lower border of the 3rd input box is missing.

Mozilla/5.0 (Windows NT 6.2; WOW64; rv:22.0) Gecko/20130328 Firefox/22.0
http://hg.mozilla.org/mozilla-central/rev/962f5293f87f

1. Start Firefox Metro
2. Swipe in the charm bar and click Settings | Sync | Connect
3. Click on "I'm not near my computer" in "Connect to sync" menu
4. Enter your Sync account information Username and Password, enter a valid Recovery key
5. After you are connected click on "Pair a device"

Actual result:
Lower border of the 3rd input box is missing. 

Found while testing following story:
https://bugzilla.mozilla.org/show_bug.cgi?id=831614

Comment 1

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

My guess is that we just need to change a height in some xul.  If that turns out to be right, then p=1

Comment 2

[Allison Naaktgeboren :ally]

still on nightly.yoink!

Comment 3

[Allison Naaktgeboren :ally]

Attachment: part 1/1 changing box type

We don't actually want a scroll box here and the separator isn't actually helping us in this metro modal dialog.

Comment 4

[Allison Naaktgeboren :ally]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3ae3077baa08

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/3ae3077baa08

Comment 7

[Marco Mucci [:MarcoM]]

For testing and verification.

Comment 8

[Virgil Dicu [:virgil] [QA]]

Attachment: pair a device - fixed

Mozilla/5.0 (Windows NT 6.2; rv:23.0) Gecko/20130507 Firefox/23.0

Looks great now! Latest build.

Comment 9

[Kamil Jozwiak [:kjozwiak]]

Went through the following "Defect" for iteration #9 testing without any issues. Used the following build:

http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-06-25-03-12-38-mozilla-central/

- Went through the original test case from comment 0 without any issues
- Checked two different machines and ensured that the lower border was not being cut off
- Ensured that both the "Cancel" & "Add Device" buttons where visible
- Ensured that the "Show me how" link worked without any issues