Closed
Bug 856432
Opened 11 years ago
Closed 11 years ago
Modernize the New Mail alert appearance
Categories
(Thunderbird :: Theme, defect)
Thunderbird
Theme
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 23.0
People
(Reporter: Paenglab, Assigned: Paenglab)
References
(Blocks 1 open bug)
Details
Attachments
(3 files, 3 obsolete files)
4.52 KB,
patch
|
mconley
:
review+
mconley
:
ui-review+
|
Details | Diff | Splinter Review |
27.85 KB,
image/png
|
Details | |
7.49 KB,
image/png
|
Details |
The new mail alert looks a little bit outdated with his thick blue 3D border. This bug is to modernize this alert and make it equal to the toolkit notification alerts.
Assignee | ||
Comment 1•11 years ago
|
||
This patch implements the styles from toolkit's alert.css.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #731662 -
Flags: ui-review?(mconley)
Attachment #731662 -
Flags: review?(mconley)
Assignee | ||
Comment 2•11 years ago
|
||
Assignee | ||
Comment 3•11 years ago
|
||
Comment 4•11 years ago
|
||
Is there any way we could use the toolkit's CSS directly, instead of copying it?
Assignee | ||
Comment 5•11 years ago
|
||
(In reply to Blake Winton (:bwinton) from comment #4) > Is there any way we could use the toolkit's CSS directly, instead of copying > it? This could be possible with @import. But almost all items in alarm are classes which are in newmailalert IDs. I could change this but is it worth to do it? It's only a small CSS file.
Comment 6•11 years ago
|
||
Perhaps not. I wonder more about what we'ld do when toolkit changes their style next time. In the end, I'll be happy with whatever you and Mike decide is best. :)
Updated•11 years ago
|
OS: Windows 7 → All
Comment 7•11 years ago
|
||
Comment on attachment 731662 [details] [diff] [review] proposed fix First off, it's really cool that we're cleaning up this little popup. Now that I'm seeing it in isolation, I think my major beef with this is that I find the alignment a little screwy. The "Bluewin received 1 new message" is not lined up with the separator line below it, and the lines below that. Can that be fixed here?
Attachment #731662 -
Flags: ui-review?(mconley)
Attachment #731662 -
Flags: review?(mconley)
Assignee | ||
Comment 8•11 years ago
|
||
Now with aligned content. I've also removed a hard coded color (.folderSummary-previewText) from 'color: grey' to 'opacity: 0.6' to work better on every theme.
Attachment #731662 -
Attachment is obsolete: true
Attachment #731663 -
Attachment is obsolete: true
Attachment #731664 -
Attachment is obsolete: true
Attachment #735071 -
Flags: ui-review?(mconley)
Attachment #735071 -
Flags: review?(mconley)
Assignee | ||
Comment 9•11 years ago
|
||
Assignee | ||
Comment 10•11 years ago
|
||
Assignee | ||
Comment 11•11 years ago
|
||
The dark border around the alerts are my backgrounds.
Comment 12•11 years ago
|
||
Comment on attachment 735071 [details] [diff] [review] proposed fix v2 I like it! Thanks Richard.
Attachment #735071 -
Flags: ui-review?(mconley)
Attachment #735071 -
Flags: ui-review+
Attachment #735071 -
Flags: review?(mconley)
Attachment #735071 -
Flags: review+
Assignee | ||
Updated•11 years ago
|
Keywords: checkin-needed
Comment 13•11 years ago
|
||
https://hg.mozilla.org/comm-central/rev/3e3f42cceba5
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 23.0
You need to log in
before you can comment on or make changes to this bug.
Description
•