856432 - Modernize the New Mail alert appearance

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Richard Marti (:Paenglab)]

The new mail alert looks a little bit outdated with his thick blue 3D border.

This bug is to modernize this alert and make it equal to the toolkit notification alerts.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: proposed fix

This patch implements the styles from toolkit's alert.css.

Comment 2

[Richard Marti (:Paenglab)]

Attachment: screenshot on Windows

Comment 3

[Richard Marti (:Paenglab)]

Attachment: screenshot on Linux

Comment 4

[Blake Winton (:bwinton) (:☕️)]

Is there any way we could use the toolkit's CSS directly, instead of copying it?

Comment 5

[Richard Marti (:Paenglab)]

(In reply to Blake Winton (:bwinton) from comment #4)
> Is there any way we could use the toolkit's CSS directly, instead of copying
> it?

This could be possible with @import. But almost all items in alarm are classes which are in newmailalert IDs. I could change this but is it worth to do it? It's only a small CSS file.

Comment 6

[Blake Winton (:bwinton) (:☕️)]

Perhaps not.  I wonder more about what we'ld do when toolkit changes their style next time.  In the end, I'll be happy with whatever you and Mike decide is best.  :)

Comment 7

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 731662 [details] [diff] [review]
proposed fix

First off, it's really cool that we're cleaning up this little popup.

Now that I'm seeing it in isolation, I think my major beef with this is that I find the alignment a little screwy. The "Bluewin received 1 new message" is not lined up with the separator line below it, and the lines below that. Can that be fixed here?

Comment 8

[Richard Marti (:Paenglab)]

Attachment: proposed fix v2

Now with aligned content. I've also removed a hard coded color (.folderSummary-previewText) from 'color: grey' to 'opacity: 0.6' to work better on every theme.

Comment 9

[Richard Marti (:Paenglab)]

Attachment: Patch under Linux

Comment 10

[Richard Marti (:Paenglab)]

Attachment: patch under Windows

Comment 11

[Richard Marti (:Paenglab)]

The dark border around the alerts are my backgrounds.

Comment 12

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 735071 [details] [diff] [review]
proposed fix v2

I like it! Thanks Richard.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/3e3f42cceba5