The default bug view has changed. See this FAQ.

Modernize the New Mail alert appearance

RESOLVED FIXED in Thunderbird 23.0

Status

Thunderbird
Theme
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: Paenglab, Assigned: Paenglab)

Tracking

(Blocks: 1 bug)

unspecified
Thunderbird 23.0

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments, 3 obsolete attachments)

(Assignee)

Description

4 years ago
The new mail alert looks a little bit outdated with his thick blue 3D border.

This bug is to modernize this alert and make it equal to the toolkit notification alerts.
(Assignee)

Comment 1

4 years ago
Created attachment 731662 [details] [diff] [review]
proposed fix

This patch implements the styles from toolkit's alert.css.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #731662 - Flags: ui-review?(mconley)
Attachment #731662 - Flags: review?(mconley)
(Assignee)

Comment 2

4 years ago
Created attachment 731663 [details]
screenshot on Windows
(Assignee)

Comment 3

4 years ago
Created attachment 731664 [details]
screenshot on Linux
Is there any way we could use the toolkit's CSS directly, instead of copying it?
(Assignee)

Comment 5

4 years ago
(In reply to Blake Winton (:bwinton) from comment #4)
> Is there any way we could use the toolkit's CSS directly, instead of copying
> it?

This could be possible with @import. But almost all items in alarm are classes which are in newmailalert IDs. I could change this but is it worth to do it? It's only a small CSS file.
Perhaps not.  I wonder more about what we'ld do when toolkit changes their style next time.  In the end, I'll be happy with whatever you and Mike decide is best.  :)

Updated

4 years ago
OS: Windows 7 → All
Comment on attachment 731662 [details] [diff] [review]
proposed fix

First off, it's really cool that we're cleaning up this little popup.

Now that I'm seeing it in isolation, I think my major beef with this is that I find the alignment a little screwy. The "Bluewin received 1 new message" is not lined up with the separator line below it, and the lines below that. Can that be fixed here?
Attachment #731662 - Flags: ui-review?(mconley)
Attachment #731662 - Flags: review?(mconley)
(Assignee)

Comment 8

4 years ago
Created attachment 735071 [details] [diff] [review]
proposed fix v2

Now with aligned content. I've also removed a hard coded color (.folderSummary-previewText) from 'color: grey' to 'opacity: 0.6' to work better on every theme.
Attachment #731662 - Attachment is obsolete: true
Attachment #731663 - Attachment is obsolete: true
Attachment #731664 - Attachment is obsolete: true
Attachment #735071 - Flags: ui-review?(mconley)
Attachment #735071 - Flags: review?(mconley)
(Assignee)

Comment 9

4 years ago
Created attachment 735073 [details]
Patch under Linux
(Assignee)

Comment 10

4 years ago
Created attachment 735074 [details]
patch under Windows
(Assignee)

Comment 11

4 years ago
The dark border around the alerts are my backgrounds.

Updated

4 years ago
Blocks: 856759
Comment on attachment 735071 [details] [diff] [review]
proposed fix v2

I like it! Thanks Richard.
Attachment #735071 - Flags: ui-review?(mconley)
Attachment #735071 - Flags: ui-review+
Attachment #735071 - Flags: review?(mconley)
Attachment #735071 - Flags: review+
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/3e3f42cceba5
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 23.0
You need to log in before you can comment on or make changes to this bug.