856587 - [SeaMonkey] test_contextmenu.html | checking item #4 (---) name - got context-openlinkinprivatewindow, expected ---

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Description

[Frank Wein [:mcsmurf]]

The mochitest-5 test test_contextmenu.html currently fails with this (and many related) test failure:
[...]
2101 INFO TEST-PASS | /tests/suite/browser/test/test_contextmenu.html | checking item #3 (context-openlink) name
2102 INFO TEST-PASS | /tests/suite/browser/test/test_contextmenu.html | checking item #3 (context-openlink) enabled state
NEXT ERROR 2103 ERROR TEST-UNEXPECTED-FAIL | /tests/suite/browser/test/test_contextmenu.html | checking item #4 (---) name - got context-openlinkinprivatewindow, expected ---
2104 ERROR TEST-UNEXPECTED-FAIL | /tests/suite/browser/test/test_contextmenu.html | checking item #5 (context-bookmarklink) name - got ---, expected context-bookmarklink
2105 ERROR TEST-UNEXPECTED-FAIL | /tests/suite/browser/test/test_contextmenu.html | checking item #5 (context-bookmarklink) enabled state - got null, expected true
2106 ERROR TEST-UNEXPECTED-FAIL | /tests/suite/browser/test/test_contextmenu.html | checking item #6 (context-savelink) name - got context-bookmarklink, expected context-savelink
2107 INFO TEST-PASS | /tests/suite/browser/test/test_contextmenu.html | checking item #6 (context-savelink) enabled state
NEXT ERROR 2108 ERROR TEST-UNEXPECTED-FAIL | /tests/suite/browser/test/test_contextmenu.html | checking item #7 (context-sendlink) name - got context-savelink, expected context-sendlink

This is because of the new "Open in private window" link, need to fix this test.

Comment 1

[Frank Wein [:mcsmurf]]

Attachment: Patch

Neil: This fixes the test that has been broken by Bug 841230. The patch adds the private browsing menu item to the test and removes the send page item on links from the test.

Comment 2

[[e-mail]]

Comment on attachment 731849 [details] [diff] [review]
Patch

Seems reasonable, given that those are the two menuitems that I changed.

Comment 3

[Frank Wein [:mcsmurf]]

Pushed: https://hg.mozilla.org/comm-central/rev/f1db6220a939
Patch will also go to comm-aurora and comm-beta, so keeping bug open for now.

Comment 4

[Frank Wein [:mcsmurf]]

I've pushed a follow-up fix to a small test issue from Bug 807326:
https://hg.mozilla.org/comm-central/rev/2fb4295da0ac

Comment 5

[Frank Wein [:mcsmurf]]

Comment on attachment 731849 [details] [diff] [review]
Patch

[Approval Request Comment]
Regression caused by (bug #): Bug 807326, Bug 841230 
User impact if declined: -
Testing completed (on m-c, etc.): Test fix only, works fine on comm-central
Risk to taking this patch (and alternatives if risky): no risk
String changes made by this patch: -

Comment 6

[Frank Wein [:mcsmurf]]

Pushed to comm-aurora: https://hg.mozilla.org/releases/comm-aurora/rev/3f47e9178b7d
Pushed to comm-beta: https://hg.mozilla.org/releases/comm-beta/rev/6ef37899b559 (minus the fix from Comment 4 as this one did not land on beta)