Closed Bug 857199 Opened 12 years ago Closed 12 years ago

Please start offering the stub installer for English/Win32 on Beta

Categories

(www.mozilla.org :: General, defect, P3)

Product:
www.mozilla.org
Component:
General
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: akeybl, Assigned: pmac)

References

(Blocks 1 open bug)

Details

(Whiteboard: r=115546)

Attachments

(1 file)

Proposed fix
928 bytes, patch
sancus
: review+
Details | Diff | Splinter Review
Please start offering the stub installer for English/Win32 on Beta, permanently. This change should only impact https://www.mozilla.org/en-US/firefox/channel/#firefox and https://www.mozilla.org/en-US/firefox/new/, but explicitly should not impact https://www.mozilla.org/en-US/firefox/all/.
Component: Webdev → General
Product: mozilla.org → www.mozilla.org
Ben/Pmac: button logic or bouncer?
Sorry, that should have read "should only impact https://www.mozilla.org/en-US/firefox/beta/ and https://www.mozilla.org/en-US/firefox/channel/#beta, but explicitly should not impact https://www.mozilla.org/en-US/firefox/all-beta.html".
Alex: how do we differentiate between full and stub installer with button links? On https://www.mozilla.org/en-US/firefox/channel/#firefox (python bedrock), the installer is: firefox-20.0 and on http://www.mozilla.org/en-US/firefox/beta/ (legacy php), the installer is firefox-20.0b6. Should those both be the same?
This usually happens on bouncer. That's where the apache rules are setup to send a certain percentage of users the stub and others the full. We did a thing for the last one when the stub came with a funnelcake build, but I don't even know of a way to specify in the download link that we want the stub installer.
Alex: Why we would we want to put these changes on the download buttons and not in bouncer like we have previously? If we did put logic in the buttons, what different query strings would we have to pass to bouncer to serve up the right download?
As QA lead for Firefox 21 Beta I'm taking QA contact for this bug so I know when his is ready to be tested.
QA Contact: anthony.s.hughes
(In reply to Chris More [:cmore] from comment #3) > Alex: how do we differentiate between full and stub installer with button > links? > > On https://www.mozilla.org/en-US/firefox/channel/#firefox (python bedrock), > the installer is: firefox-20.0 and on > http://www.mozilla.org/en-US/firefox/beta/ (legacy php), the installer is > firefox-20.0b6. Should those both be the same? Disregard comment 0, which had release links instead of beta links. The versions for everything in comment 2 are consistent. (In reply to Chris More [:cmore] from comment #5) > Alex: Why we would we want to put these changes on the download buttons and > not in bouncer like we have previously? If we did put logic in the buttons, > what different query strings would we have to pass to bouncer to serve up > the right download? I think catlee will have a better idea of what the different bouncer products are for stub/full installers. The intent of this bug is to have A) English stub installers offered from https://www.mozilla.org/en-US/firefox/beta/ and https://www.mozilla.org/en-US/firefox/channel/#beta when the user is windows/en-US B) Full installers offered to the URLs in A for all other languages C) Full installers offered for all languages at https://www.mozilla.org/en-US/firefox/all-beta.html I believe we already have two different beta bouncer products for full/stub installers. Do we need a third product that's a mix of full/stub installers for A/B above?
Flags: needinfo?(catlee)
So there are 3 bouncer products that are relevant for this discussion: "firefox-21.0b1" - This version-specific product gets created by release automation for every beta/release build we do. AIUI the website uses data from product details to determine which version to point to. This product refers you to the full installer. "firefox-beta-latest" - Similar to above, but always gets the latest beta full installer. The stub installer uses this product to download the latest version "firefox-beta-stub" - The latest version of the beta stub installer. We don't have a product for a specific version of the stub, and I don't think that we need one. To me the simplest thing to change would be to request "firefox-beta-stub" for A above.
Flags: needinfo?(catlee)
(In reply to Alex Keybl [:akeybl] from comment #7) I think we're having a bit of a disconnect here. It seems like there's some tracking being attempted and we're not being consulted on the best way to accomplish it. What exactly is the end goal here? Updating bouncer is the best way of getting the stub installer to people. The number of downloads of en-US Windows Fx from the all-beta.html page has got to be extremely minimal. If you want to know how minimal we have some excellent ways to track clicks. If we knew the goal of these changes perhaps we could help come up with the best plan for accomplishing it. Customizing download buttons on a page-by-page basis is almost never the answer, and it's something we'd very much like to avoid.
(In reply to Chris AtLee [:catlee] from comment #8) We would LOVE to use the firefox-*-latest products, but last time I checked into them they were only valid for Windows builds. Is this still true? Having mozilla.org not need to keep track of which version is the latest would solve a lot of problems and make it much easier to ensure that people are getting the newest version as soon as possible. A central spot for version truth (bouncer) is an excellent thing to have. This would leave us more bandwidth to worry about platform and language considerations which are the province of the website. That said, our current buttons rely on the data in the SVN repo for product_details to determine the latest versions and generate download links accordingly. We can short-circuit all that logic for special cases but would very much prefer not to as it makes the buttons even more complex at a time when we're attempting to simplify them.
Priority: -- → P3
Depends on: 849199
No longer depends on: 849199
(In reply to Paul McLanahan [:pmac] from comment #9) > (In reply to Alex Keybl [:akeybl] from comment #7) > > I think we're having a bit of a disconnect here. It seems like there's some > tracking being attempted and we're not being consulted on the best way to > accomplish it. What exactly is the end goal here? The problem description is well defined in comment 2. > Updating bouncer is the > best way of getting the stub installer to people. The number of downloads of > en-US Windows Fx from the all-beta.html page has got to be extremely > minimal. If you want to know how minimal we have some excellent ways to > track clicks. If we knew the goal of these changes perhaps we could help > come up with the best plan for accomplishing it. We must still offer the full beta installers on Mozilla's website. We must offer the stub installer as the main download. > Customizing download > buttons on a page-by-page basis is almost never the answer, and it's > something we'd very much like to avoid. Given the above, what's the right solution? Also, what's the ETA here?
We're working on this now. Should be ready thursday. Is the product 'firefox-beta-stub' ready in bouncer? We'd like to push this week as pushing bedrock next week is highly unlikely.
(In reply to Paul McLanahan [:pmac] from comment #12) > We're working on this now. Should be ready thursday. Is the product > 'firefox-beta-stub' ready in bouncer? We'd like to push this week as pushing > bedrock next week is highly unlikely. I believe it is, but catlee will be able to tell us with certainty.
Flags: needinfo?(catlee)
(In reply to Chris AtLee [:catlee] from comment #14) Fantastic. That means we can roll out changes to production tomorrow and you can update that product in bouncer whenever you're ready and everything will Just Work(tm). I've made some progress on the bedrock button for the /firefox/channel/#beta page, but it turns out that /firefox/beta/ is still on the PHP codebase, and as such the buttons are a lot less flexible. I'm still investigating that one.
Assignee: nobody → pmac
Can someone confirm if beta win32+English stub installer being available on mozilla.org is needed by an exact date or just asap?
(In reply to Chris More [:cmore] from comment #16) > Can someone confirm if beta win32+English stub installer being available on > mozilla.org is needed by an exact date or just asap? Just as soon as possible.
Pmac: just to clarify, offering stub installer for beta is not related to the upcoming funnelcake test of stub on the release channel. Getting stub installer on beta is not blocking the funnelcake test and moving to the stub installer for en-US and Win32 will be the norm going forward.
Commits pushed to master at https://github.com/mozilla/bedrock https://github.com/mozilla/bedrock/commit/6d1258ab4d5032294860a1463d504b263b332b5d Bug 857199: Add ability to force a button to point to stub. Adds force_stub_installer keyword arg to button helper that will change the download product to use the firefox-*-stub product for en-US Windows download buttons. https://github.com/mozilla/bedrock/commit/cbdfa45b4d2cdcaa9e3a9091a959269a9aed72ab Merge pull request #764 from pmclanahan/bug-857199-beta-stub-installer Bug 857199: Add ability to force a button to point to stub.
(In reply to Alex Keybl [:akeybl] from comment #2) > Sorry, that should have read "should only impact > https://www.mozilla.org/en-US/firefox/beta/ Still the full installer > https://www.mozilla.org/en-US/firefox/channel/#beta Stub installer > but explicitly should > not impact https://www.mozilla.org/en-US/firefox/all-beta.html". Full installer Any thoughts?
(In reply to Paul Silaghi [QA] from comment #20) The /channel/ page is on bedrock, which we've fixed. The /beta/ page is still on the mozilla.com PHP codebase and those buttons are far more fragile and confusing. I'm in the process of fixing it, but I'm at an offsite this week, so I'm not sure when it'll get done. Early next week at the latest though.
Thanks for explaining.
(In reply to Paul McLanahan [:pmac] from comment #21) > (In reply to Paul Silaghi [QA] from comment #20) > > The /channel/ page is on bedrock, which we've fixed. The /beta/ page is > still on the mozilla.com PHP codebase and those buttons are far more fragile > and confusing. I'm in the process of fixing it, but I'm at an offsite this > week, so I'm not sure when it'll get done. Early next week at the latest > though. Any update on this?
Attached patch Proposed fix — — Splinter Review
Hopefully this is it. Once this is reviewed and merged this should fix the /firefox/beta/ page button and complete this bug.
Attachment #742537 - Flags: review?(sancus)
Committed to trunk in r115546.
Whiteboard: r=115546
Comment on attachment 742537 [details] [diff] [review] Proposed fix ~as discussed in IRC last week. This doesn't make this file any more horrific than it already is.
Attachment #742537 - Flags: review?(sancus) → review+
Committed to prod in r115610.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Paul Silaghi, can you please retest this now that we have content in prod?
QA Contact: anthony.s.hughes → paul.silaghi
Blocks: 874982
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: