858010 - Display error in TB 22 using personas

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[LEOXD]

Attachment: The Screenshot. The red marked areas are the ones which SHOULD be affected by themes.

The Mail-Toolbar is no longer affected by Personas in TB22. That should be changed.

Comment 1

[Richard Marti (:Paenglab)]

Bug 817468 regressed this. I think I need to set the background color directly on the attachment bar.

Comment 2

[Richard Marti (:Paenglab)]

Attachment: proposed fix

Sorry Mike, I forgot to check Bug 817468 with personas. This patch sets now directly a background color on attachmentBar which looks like setting the -moz-appearance: toolbox; on mailContent or messengerBox. For this I gave under Win7 the background-image.

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 734021 [details] [diff] [review]
proposed fix

Sorry for the crazy wait on this. Code looks good, and testing shows that this does indeed fix the problem. Thanks Richard!

Comment 4

[Richard Marti (:Paenglab)]

Comment on attachment 734021 [details] [diff] [review]
proposed fix

[Approval Request Comment]
Regression caused by (bug #): 817468
User impact if declined: Wrong appearance with LW-themes
Risk to taking this patch (and alternatives if risky): small, there are only CSS changes.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/ebc5dba345c4

Comment 6

[Mark Banner (:standard8)]

https://hg.mozilla.org/releases/comm-aurora/rev/a02b40a24fec