858808 - java.lang.NoSuchMethodError: java.lang.String.getBytes at org.mozilla.gecko.ANRReporter.fillPingHeader(ANRReporter.java) on Froyo

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Scoobidiver (away)]

It first showed up in 22.0a1/20130328. Here is a crash report: bp-689987de-585c-4f58-af37-b6f112130404.

java.lang.NoSuchMethodError: java.lang.String.getBytes
	at org.mozilla.gecko.ANRReporter.fillPingHeader(ANRReporter.java:316)
	at org.mozilla.gecko.ANRReporter.processTraces(ANRReporter.java:482)
	at org.mozilla.gecko.ANRReporter.processTraces(ANRReporter.java:522)
	at org.mozilla.gecko.ANRReporter.onReceive(ANRReporter.java:586)
	at android.app.ActivityThread$PackageInfo$ReceiverDispatcher$Args.run(ActivityThread.java:920)
	at android.os.Handler.handleCallback(Handler.java:587)
	at android.os.Handler.dispatchMessage(Handler.java:92)
	at android.os.Looper.loop(Looper.java:143)
	at org.mozilla.gecko.ANRReporter$1.run(ANRReporter.java:102)
	at java.lang.Thread.run(Thread.java:1096)

More reports at:
https://crash-stats.mozilla.com/report/list?signature=java.lang.NoSuchMethodError%3A+java.lang.String.getBytes+at+org.mozilla.gecko.ANRReporter.fillPingHeader%28ANRReporter.java%29

Comment 1

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Use String version of getBytes to accommodate Froyo (v1)

Froyo only has the String version of String.getBytes()

Comment 2

[(inactive) Jim Chen [:jchen] [:darchons]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4d5134b3cc6c

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4d5134b3cc6c

Comment 4

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 734755 [details] [diff] [review]
Use String version of getBytes to accommodate Froyo (v1)

[Approval Request Comment]

Bug caused by (feature/regressing bug #): N/A

User impact if declined: Crash when the App Not Responding dialog appears in Fennec

Testing completed (on m-c, etc.): Locally, m-c

Risk to taking this patch (and alternatives if risky): Very small; patch only fixes the crash case

String or IDL/UUID changes made by this patch: None

Comment 5

[Alex Keybl [:akeybl]]

Same question as https://bugzilla.mozilla.org/show_bug.cgi?id=858960#c5

Comment 6

[bhavana bajaj [:bajaj]]

setting need-info, on jim to help with comment# 5.

Comment 7

[(inactive) Jim Chen [:jchen] [:darchons]]

(In reply to Alex Keybl [:akeybl] from comment #5)
> Same question as https://bugzilla.mozilla.org/show_bug.cgi?id=858960#c5

From bug 858960,

(In reply to Alex Keybl [:akeybl] from comment #5)
> (In reply to Jim Chen [:jchen :nchen] from comment #4)
> > Bug caused by (feature/regressing bug #): N/A
> 
> Hard to believe this is n/a - 21 was unaffected.

Sorry, the crash was caused by the ANR feature introduced in 22 (tracking bug 833990) 

> > User impact if declined: Crash when the App Not Responding dialog appears in
> > Fennec
> 
> Have we confirmed that the crash volume fell off on Nightly? I don't see STR
> here that could have been verified.

There were only 2 crash reports before the fix landed, and none since then. This is difficult to reproduce because it requires Fennec hanging on Froyo devices, which is not a common scenario.

Thanks!

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/2671c422e082