[MP] Defect - Browser branding links should point to valid pages

RESOLVED FIXED in Firefox 26

Status

defect
P2
normal
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: TimAbraldes, Unassigned)

Tracking

20 Branch
Firefox 26
x86
Windows 8.1
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [preview] [leave-open] feature=defect c=Install_and_setup u=browser_user p=0)

Attachments

(1 attachment, 1 obsolete attachment)

Posted patch patch v1 (obsolete) — Splinter Review
Links on the 'about:' page are constructed using '%APP%', which means we create URLs like this:
  http://www.mozilla.org/en-US/projects/metrofirefox/

These will 404 because they are not real pages.
No longer depends on: 854271
Attachment #734720 - Attachment is patch: true
Assignee: nobody → tabraldes
Status: NEW → ASSIGNED
QA Contact: jbecerra
Comment on attachment 734720 [details] [diff] [review]
patch v1

Jimm: I'm not sure who an appropriate reviewer would be for this patch, but you seem the most likely candidate out of us metro hackers.  Let me know if I should forward this to someone else.  Thanks!
Attachment #734720 - Flags: review?(jmathies)
(In reply to Tim Abraldes (:tabraldes) (:TimAbraldes) from comment #0)
> Created attachment 734720 [details] [diff] [review]
> patch v1
> 
> Links on the 'about:' page are constructed using '%APP%', which means we
> create URLs like this:
>   http://www.mozilla.org/en-US/projects/metrofirefox/
> 
> These will 404 because they are not real pages.

I think we might want some of these to work but the pages haven't been created. We can update them to point to fx resources but we should have a bug filed on getting all of these set correctly before we roll out on the train for the first time.

Maybe the a good next step would be to file a bug and post a list of all the support related urls we use like this and cc in asa. Some of these we might want to point to existing fx pages, some we might want to custom pages for.
Comment on attachment 734720 [details] [diff] [review]
patch v1

Review of attachment 734720 [details] [diff] [review]:
-----------------------------------------------------------------

No harm in updating them to point to fx locations for now.
Attachment #734720 - Flags: review?(jmathies) → review+
Alternatively, mark this with leave-open and make sure it's blocking v1 release.
Summary: Defect - Links on 'about:' page 404 because they are pointing to URLs containing 'metrofirefox' instead of 'firefox' → Defect - Browser branding links should point to valid pages
Whiteboard: feature=defect c=Install_and_setup u=browser_user p=1 → [leave-open] feature=defect c=Install_and_setup u=browser_user p=1
Posted patch patch v2Splinter Review
This patch keeps the branding changes but doesn't include the change to metro.js.  I've filed bug 859903 for cleaning up metro.js.
Attachment #734720 - Attachment is obsolete: true
Attachment #735284 - Flags: review+
I'm running this through try:
  https://tbpl.mozilla.org/?tree=Try&rev=27c7aacc77c7

I'll test the build output, and if it works as expected I'll land the 3 patches together
Landed on inbound:
  https://hg.mozilla.org/integration/mozilla-inbound/rev/08f54c265a09


Note: This bug should remain open.  Before launch, we'll want to decide for each URL whether we actually want to use the regular Firefox page or create a new page with metro-specific content.
Blocks: metrov1defect&change
No longer blocks: metrov1it5
Whiteboard: [leave-open] feature=defect c=Install_and_setup u=browser_user p=1 → [leave-open] feature=defect c=Install_and_setup u=browser_user p=0
Unassigning myself since the desktop dev work is complete.  Any remaining work will be server-side (creating 'metrofirefox' specific pages)
Assignee: tabraldes → nobody
Priority: P1 → --
Status: ASSIGNED → NEW

Updated

6 years ago
Priority: -- → P2
Depends on: 823541

Updated

6 years ago
Whiteboard: [leave-open] feature=defect c=Install_and_setup u=browser_user p=0 → feature=defect c=Install_and_setup u=browser_user p=0 [leave-open]
Whiteboard: feature=defect c=Install_and_setup u=browser_user p=0 [leave-open] → feature=defect c=Install_and_setup u=browser_user p=0 [leave-open][preview]
Summary: Defect - Browser branding links should point to valid pages → MP Defect - Browser branding links should point to valid pages
Whiteboard: feature=defect c=Install_and_setup u=browser_user p=0 [leave-open][preview] → [leave-open] [preview] feature=defect c=Install_and_setup u=browser_user p=0
Summary: MP Defect - Browser branding links should point to valid pages → [MP] Defect - Browser branding links should point to valid pages
Whiteboard: [leave-open] [preview] feature=defect c=Install_and_setup u=browser_user p=0 → [preview] [leave-open] feature=defect c=Install_and_setup u=browser_user p=0
Blocks: metrov1backlog
No longer blocks: metrov1defect&change
Looking over the original branding links - 

not used:
startup.homepage_override_url
startup.homepage_welcome_url
app.update.url.details

used:
app.update.url.manual - https://www.mozilla.org/firefox/

I think this can be closed out. The only link left is the download link, which seems fine as is.
Current about comps don't have an update details link either - 

https://bug898843.bugzilla.mozilla.org/attachment.cgi?id=782721
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 26
No longer blocks: metrov1backlog
OS: Windows 8 Metro → Windows 8.1
You need to log in before you can comment on or make changes to this bug.