Closed Bug 898651 Opened 7 years ago Closed 7 years ago

defect - find in page option in start page is superfluous

Categories

(Firefox for Metro Graveyard :: Firefox Start, defect, P1)

x86
Windows 8.1
defect

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 25

People

(Reporter: jbecerra, Assigned: sfoster)

References

Details

(Whiteboard: feature=defect c=Find_in_page_app_bar u=metro_firefox_user p=1)

Attachments

(1 file)

Tested on 2013-07-26 using latest nightly while testing story in bug 859447 iteration #10. It feels like the "Find in page" option in the settings button doesn't do anything. We could remove that button or highlight the navigation bar to indicate that is the field that could be used for searching.

Steps:
1. Open Firefox Metro
2. Open a new tab
3. Touch the settings button on the bottom right, and then tap on "Find in page"

Expected: Some clear indication I can and I am about to look for something in the page, perhaps by highlighting the Search/URL field.

Actual: Nothing seems to happen, except the "Find in page" rectangle goes away.
Whiteboard: feature=defect c=tbd u=tbd p=0
Priority: -- → P1
We fixed this once before at bug 890751 I think. Fix it again?
Blocks: 831940
Whiteboard: feature=defect c=tbd u=tbd p=0 → feature=defect c=Find_in_page_app_bar u=metro_firefox_user p=0
OS: Mac OS X → Windows 8 Metro
Assignee: nobody → sfoster
Blocks: metrov1it12
No longer blocks: metrov1defect&change
Status: NEW → ASSIGNED
QA Contact: jbecerra
Whiteboard: feature=defect c=Find_in_page_app_bar u=metro_firefox_user p=0 → feature=defect c=Find_in_page_app_bar u=metro_firefox_user p=1
Component: General → Firefox Start
We already return from the show method in FindHelperUI when the startUI is visible, this patch only adds the menuitem when the startUI isn't visible
Attachment #783349 - Flags: review?(jmathies)
Attachment #783349 - Flags: review?(jmathies) → review+
Comment on attachment 783349 [details] [diff] [review]
Dont add the find-in-page menuitem when the StartUI is visible

Review of attachment 783349 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/metro/base/content/appbar.js
@@ +99,5 @@
>      }
>    },
>  
>    onMenuButton: function(aEvent) {
> +      var typesArray = [];

Drive-by nit: 'var' to 'let' here?
Attachment #783349 - Flags: review+ → review?(jmathies)
Oops. why would bugzilla let me undo a review?!
Attachment #783349 - Flags: review?(jmathies) → review+
Fixed a couple of var vs. let while I was in there. Didn't try to fix the whole file though. 
https://hg.mozilla.org/integration/mozilla-inbound/rev/acf95e69c5e8
https://hg.mozilla.org/mozilla-central/rev/acf95e69c5e8
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 25
Went through the following "Defect" for iteration #12 without any issues. Used the following build:

http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-08-20-03-02-06-mozilla-central/

- Went through the original test case in comment #0 without any issues
- Tapping on "Settings" -> "Find in page" will slide in the "Find in page" app bar and place a cursor in the search field without any issues (started typing right away using the physical keyboard without any issues)
- Pressing CTRL + F will slide in the "Find in page" app bar and place the cursor in the search field without any issues
- Ensured that you cannot open a "Find in page" app bar under the awesome screen
- Went through all of the above test cases in filled view without any issues

Found Bug 907520 when going through the following defect
Went through the following "Defect" for iteration #13 without any issues. Used the following build:
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-09-04-03-02-04-mozilla-central/

- Went through the original test cases in comment #0 without any issues
- Went through the test cases added in comment #7 without any issues
Went through the following defect for iteration #20 without any issues. Used the following build:
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013/03/2013-03-25-03-11-00-mozilla-central/

- Went through the original test case from comment #0 without any issues
- Double checked with the original test cases from comment # 7
- Ensured taping on the "Settings -> Find in page" slides in the Find App Bar without any issues
- Ensured that pressing "CTRL + F" slides in the Find App Bar without any issues
- Ensured that you can dismiss the Find App Bar by selecting the "X" (with and without the OSK)
- Ensured that you can dismiss the Find App Bar by pressing "ESC" (with and without the OSK)
- Ensured that you can dismiss the Find App Bar by sliding in the Navigation App Bar from the top/bottom
- Ensured that the user can't slide in the Find App Bar under the about:start screen
- Ensured that the transitions are smooth without any jank or other noticeable performance issues
- Went through all of the above test cases using filled view without any issues
Pasted the incorrect build into the above ticket (was trying to reproduce an older issue). The above test cases used the following build:
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-12-23-03-02-03-mozilla-central/
OS: Windows 8 Metro → Windows 8.1
You need to log in before you can comment on or make changes to this bug.