86014 - Offline: UI : Disk Space pref "Do not download messages locally larger than x kb" is not initially set, nor remembered if you change it

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Backend, defect, P2)

Description

[grylchan]

This occurred using 2001-06-14-09-trunk/ and on all platforms.

Initially the Disk space pref 
"Do not download messages locally larger than x kb" is not
checked. And if you check the box or change the size from the default of
50, it will not be saved the next time you view the pref.

This happens on all Mail accounts (imap,web mail,etc..) and on
Newsgroup accounts also.

I think this is a strictly a UI issue. Very simlar to compact folders
pref not being saved (bug 82984) and I don't think it's a pref
issue (see bug 85335) as the pref is working (i can't download messages
greater than 50 kb). 

Steps to reproduce:
1.Login to your imap account  
2.Go to Edit|Mail/News Account settings
3.Select Offline & Disk Space pref (for mail or newsgroup account)
4.Notice the checkbox is not marked for 
  "Do not download messages locally larger than x kb" 
5.Check the box and change the default size of 50kb to another number
6.Click Ok
7.Go back to the pref and see that the checkbox or size box was not
  saved
8.You can verify by having a mail message greater than 50kb in your inbox.
 - Select the inbox for download (either w/download & sync or bringing
   properties dialog for the inbox or using the pref make messages in my
   inbox available for download)
 - download your messages in the inbox
 - notice the message that's bigger than 50kb is not downloaded/not italic

Not sure if the big massive ui change for offline & disk space bug 81753
will affect this bug or not.

Comment 1

[Diane Sun]

This is due to two same name ids for the same checkbox in am-offline.xul 

Comment 2

[Diane Sun]

Attachment: Fix to integrate the two ids w/same name as one

Comment 3

[Diane Sun]

Attachment: POP3 screen shot with Disk Space as the title box, same as IMAP & NNTP

Comment 4

[Diane Sun]

Attachment: nntp screen shot

Comment 5

[Diane Sun]

Attachment: POP3 screen shot with Disk Space as the title box, same as IMAP & NNTP (gif file this time)

Comment 6

[grylchan]

*** Bug 88907 has been marked as a duplicate of this bug. ***

Comment 7

[Diane Sun]

Request R & SR,  Bhuvan & Seth? 

Comment 8

[racham]

r=bhuvan.

Comment 9

[Diane Sun]

Request SR again. 

Comment 10

[Diane Sun]

While for SR, please  SR the patch am-offline.xul in bug 85335 attach_id=43273 
which has integrated this bug's fix into it.  The code could be check in in bug 
85335 since 85335 depends on this bug's fix.

Comment 11

[Blake Ross]

Missed the 0.9.3 train.

Comment 12

[Diane Sun]

Attachment: old fix, new version since xul files(hbox, vbox, groupbox) have been changed

Comment 13

[Diane Sun]

Request  SR again, this bug is blocking 85335.

Comment 14

[(not reading, please use [e-mail] instead)]

sr=sspitzer on that last patch.

sorry for the delay.

Comment 15

[Diane Sun]

checked in .9.4

Comment 16

[grylchan]

*** Bug 93361 has been marked as a duplicate of this bug. ***

Comment 17

[grylchan]

Commercial builds:
2001-08-15-09-trunk/ - nt 4.0
2001-08-15-14-trunk- linux 2.2, mac 9.0.4

Hey Diane. Using these builds, i noticed when I create
a brand new profile, the pref 
"Do not download messages locally larger than x kb"
is not checked. So you would then assume you can download
messags > 50kb. Unfortunately this is not the case as
it behaves like it is checked.

I can check it/uncheck it and change the size limit fine.
And it's remembered the next time I visit the pref. So all
that stuff is fixed.

So the only problem in on initial startup:
 -the checkbox should be checked instead of unchecked

reopening bug.
 

Comment 18

[grylchan]

ps what is the expected behavior for 
   "Do not download messages locally larger than x kb"
   if it is unchecked?

   I would assume that means you can download any size message?
   If this is this case, than I might need to file a new bug
   as you can't download mesgs > 50kb.  

Comment 19

[Diane Sun]

What you mean is that the default preference for a new profile is checked? Any 
reason it should be so?

Comment 20

[grylchan]

ok. trying to answer your question Diane.

If you create brand new profile and mail account,
I noticed the pref "Do not download messages locally larger than x kb"
is not checked. So if a user tries to download messages > 50kb
they will not be able to. So since the pref is not checked
this leads to this, is it:
  -front end problem: there should be a checkmark. since it
                      behaves like it is checked.
  -back end problem: since it is unchecked, the user should be
                     be able to download mesgs > 50 kb. But they 
                     currently can not.

Hopefully yourself or David can answer this.


  

Comment 21

[Diane Sun]

I can make it default as checked. But will it solve the problem as you 
described when it is unchecked ( suppose user change it to unchecked later on), 
user still can download > 50KB  msg?    David?

Comment 22

[David :Bienvenu]

what this pref means is do not automatically download messages > 50K, either
when reading a message, or downloading the whole folder for offline use.
However, if you select or flag a message > 50K and download selected or flagged
messages, then those messages should be downloaded. Is that the current
behaviour, and if not, how does the current behaviour differ?

Comment 23

[grylchan]

That's the correct behavior you specified David.

But what happens when the pref is not checked?
I'm thinking since it's not checked, we should
be able to download any message size.

In 4.x, the wording is different. The pref is under disk space:
"Do not store messages locally that are larger than x kb". By
default it's 50kb. So I downloaded a folder with a message greater
than 50kb and I did not check that pref. The result was
all messages were downloaded including the one > 50 kb.
I then checked the pref and the result was messages that were
> 50kb were not downloaded.



Is the purpose of the checkbox:
  - to only specify what size you want to limit messages
    (you check it in order to change the default size)
  - or to turn on/off whether you want to limit your download
    message size
  - or both of the above

Comment 24

[grylchan]

Anyone have any new thoughts/opinions on this?
Make it like 4.x? leave as is?

Comment 25

[David :Bienvenu]

if the checkbox is not checked, we should not pay attention to the limit when
automatically downloading messages for offline use.

Comment 26

[Diane Sun]

I agree.
The purpose of the checkbox is to turn on/off the preference. If checked, the 
limit in the text field takes effect.

Comment 27

[grylchan]

Ok. I filed a new bug on this problem, bug 96335.

I am assuming it's back end issue and not a front end.
Since this bug was originally filed because the front
end gui wasn't remembered/couldn't be set (which
is working now except for this one case).

Marking as resolved. Won't verify until David and/or
Diane look into the other bug to see whether it's
a front or back end issue.

Comment 28

[grylchan]

Using commercial trunk builds
2001083103 NT 4.0
2001083108 linux 2.2
2001083110 mac os 9.1

Verified that you can now check/uncheck and edit the text field
box for the preference 'Do not download messages locally larger than
x kb' and it will be saved.


Marking as verified.