860524 - Regression painting some gaia controls

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, defect)

Description

[[:fabrice] Fabrice Desré]

Attachment: gaia toggle

I'm not sure which CSS is used there, but what was nice rounded corners are now more square.

Comment 1

[[:fabrice] Fabrice Desré]

Attachment: gaia checkbox

They look fine, but should be circles...

Comment 2

[Nick Cameron [:nrc]]

mask layers regression? I'll look into this once I've finished the Android bug I'm looking at...

Comment 3

[Jeff Muizelaar [:jrmuizel]]

This also happens on OS X nightly:
http://buildingfirefoxos.com/building-blocks/switches/

Comment 4

[[:fabrice] Fabrice Desré]

(In reply to Jeff Muizelaar [:jrmuizel] from comment #3)
> This also happens on OS X nightly:
> http://buildingfirefoxos.com/building-blocks/switches/

and also on linux nightly for the switches (but the checkboxes and radio buttons are ok).

Comment 5

[Jeff Muizelaar [:jrmuizel]]

I can also reproduce this in a Nightly from 8th before the layers refactoring.

Comment 6

[Nick Cameron [:nrc]]

Good: http://hg.mozilla.org/mozilla-central/rev/905671d954c5
Bad: http://hg.mozilla.org/mozilla-central/rev/1e958f7224a7

I blame bug 841192, and this is logically feasible because this looks like a rounded rect clipping issue (see comment 2, although it turns out this is a layout, not mask layers issue).

Comment 7

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4a55715677d7

Comment 9

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Er, I mean https://hg.mozilla.org/integration/mozilla-inbound/rev/dc2ced1dd175

Comment 10

[Ed Morley [:emorley]]

Backed out for reftest failures:
https://tbpl.mozilla.org/php/getParsedLog.php?id=22006344&tree=Mozilla-Inbound

http://hg.mozilla.org/integration/mozilla-inbound/rev/33ba06eba4bb

Comment 11

[Robert O'Callahan (:roc) (email my personal email if necessary)]

https://tbpl.mozilla.org/?tree=Try&rev=a6ec1ec079fe with test tweaked

Comment 12

[Robert O'Callahan (:roc) (email my personal email if necessary)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d13fc07e67af

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d13fc07e67af