Closed Bug 861867 Opened 7 years ago Closed 7 years ago
Add new Toolbar Icons for Thunderbird
704.84 KB, image/png
402.23 KB, image/png
138.30 KB, patch
|Details | Diff | Splinter Review|
1.40 MB, image/jpeg
As seen from the mockup linked in the URL field, it's time to redo some icons. I have the icons and will throw together the new toolbar later.
New toolbar.png. I'll have a screenshot up in a second, and builds a little later. Requesting ui-review from Richard. Richard: Since all this patch contains is a new image, review = ui-review. So you have both flags. Now here's the dilemma. The icons I was provided look very good, but are capable of only modifying toolbar.png, not toolbar.png@2x. So the question is: Should I just scale up the image, and we can have a better graphic artist optimize the image? Or, do we have separate images for the Retina and non-retina modes and still get someone to make new ones. Resolution or consistency is the issue.
Whoops. Fixed a bug related to the "New Message" button.
Comment on attachment 737612 [details] [diff] [review] New Toolbar Icons - toolbar.png Review of attachment 737612 [details] [diff] [review]: ----------------------------------------------------------------- I like this icons. Please add the new icons also to the AB- and Compozer-toolbar-icons to have a consistent icon logic. I'm thinking at the icons for AB, Write, Delete and File (and maybe more). For me it looks like the Back- and Forward-icons aren't horizontally centered. We should now always ship both versions of LoDPI and HiDPI icons and I'm giving only ui-r+ with both versions to be consistent for people using TB on both resolutions. For this I'm giving ui-r- now but I am sure you find a solution for the HiDPI icons. r+ because the patch applies without problems ;)
Alrighty. Updated patch fixes an accidental pixel in another icon for the toolbar.png. (Back/forward buttons where perfectly aligned, though I was kind of doubting it for a second as well) More importantly, this adds new icons to the address book. The compose window is not changed at all, simply because I would need completely new icons, and, although I can edit and use graphic tools. I can't create things from scratch for the life of me. So for now, I am just going to leave that be. Now, I was a little confused by your comment, but it sounds to me like the ui-review+ was for the style and look of everything, and the ui-review- is for the lack of consistency on the retina mode. Is this correct? I will still need to deal with the retina mode later... Screenshots coming in a second.
Screenshot of the Address book's icons.
Josiah, if this bug covers the Mac OSX icons only, can you set the platform flags respectively? Otherwise it's confusing.
(In reply to rsx11m from comment #7) > Josiah, if this bug covers the Mac OSX icons only, can you set the platform > flags respectively? Otherwise it's confusing. Thanks for the reminder! At first I was planning on changing the icons for all platforms, but discovered icons aren't consistent anyway. So I completely forgot about changing the flags.
Comment on attachment 737713 [details] [diff] [review] New Toolbar Icons - toolbar.png, Address book Review of attachment 737713 [details] [diff] [review]: ----------------------------------------------------------------- I'm okay now with the icons. Also for the AB. UI-r- for the lack of HiDPI icons but you are already on it to organize them.
Attachment #737713 - Flags: ui-review?(richard.marti) → ui-review-
Updated patch. Adds retina mode. ui-review+ because it previously passed ui-review, with the exception of missing retina. No need to bother Richard with another review. Carrying review+ flag as well.
UI demonstration with HiDPI icons.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 23.0
You need to log in before you can comment on or make changes to this bug.