Adjust the viewPicker and locationFolders appearance with bug 814041 and bug 853431 in toolkit

RESOLVED FIXED in Thunderbird 24.0

Status

Thunderbird
Theme
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: Paenglab, Assigned: Paenglab)

Tracking

Trunk
Thunderbird 24.0
All
Windows 7

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

4 years ago
This are only some slight adjustments and removes of now doubled code after the landing of bug 814041 and bug 853431.
(Assignee)

Comment 1

4 years ago
Created attachment 737539 [details] [diff] [review]
proposed fix

This patch removes the styles which are now in toolkit. I added code to make both menulists the same height. One has icons in it, the other not and we are using -moz-appearance: none to make them look like the toolbar-buttons. This makes them not the same height without my changes.

On #locationFolders the icon was to near to the text, I added 1px of space.

On #viewPickerLabel the menus had a big indentation. With this patch the menus are aligned with the menuitems.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #737539 - Flags: ui-review?(mconley)
Attachment #737539 - Flags: review?(mconley)
Hey Richard,

I'm not likely to be near my Windows machine this weekend. Could you please post before and after pictures with this patch so I can ui-r?

-Mike
Flags: needinfo?(richard.marti)
(Assignee)

Comment 3

4 years ago
Created attachment 751367 [details] [diff] [review]
proposed fix v2

At making the comparison I saw a need to remove also a margin of 2px on #viewPickerPopup > menu > .menu-text to align the menu correctly with the menuitems.
Attachment #737539 - Attachment is obsolete: true
Attachment #737539 - Flags: ui-review?(mconley)
Attachment #737539 - Flags: review?(mconley)
Attachment #751367 - Flags: ui-review?(mconley)
Attachment #751367 - Flags: review?(mconley)
Flags: needinfo?(richard.marti)
(Assignee)

Comment 4

4 years ago
Created attachment 751368 [details]
comparison of before and after the patch
Hm...not sure if the separators are supposed to start 1/4 of the way across the popup. Can that be corrected here too? Or is this that something better suited to a follow-up?
(Assignee)

Comment 6

4 years ago
I tried this. The only possibility is -moz-appearance: none, but this draws then a black separator. It wouldn't be easy to find the correct color for the native separator.

I could try it in a follow-up bug.
Comment on attachment 751367 [details] [diff] [review]
proposed fix v2

I'd say the indented menuitems are less desirable than the partially completed separators, so let's go with this patch for now.

But please file a follow-up bug to do something about those separators, if you haven't already.
Attachment #751367 - Flags: ui-review?(mconley)
Attachment #751367 - Flags: ui-review+
Attachment #751367 - Flags: review?(mconley)
Attachment #751367 - Flags: review+
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
(Assignee)

Updated

4 years ago
Blocks: 876222
(Assignee)

Comment 8

4 years ago
Bug 876222 filed.
https://hg.mozilla.org/comm-central/rev/a33b78472f55
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 24.0

Comment 10

4 years ago
Did you make the "View" dropdown and the preceding folder picker the same height? It looks like that is also needed on other platforms (at least I see it on Win XP).
(Assignee)

Comment 11

4 years ago
Yes. Please can you file a bug for this under XP? Then the issue you wrote in bug 876222 can also be fixed there.
You need to log in before you can comment on or make changes to this bug.