862701 - Update SeaMonkey installer package-manifest.in

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect)

Description

[Frank Wein [:mcsmurf]]

The package-manifest.in file in suite/installer/package-manifest.in is currently not up-to-date. A few changes need to be ported to fix test errors (and possibly other problems, too?).

Comment 1

[Frank Wein [:mcsmurf]]

Attachment: Patch

This patch fixes a few bugs (adds/removes files from those bugs):
Bug 859601 Proper implementation when mozContacts API is not implemented
Bug 525444 SpeechSynthesis files (#ifdef MOZ_WEBSPEECH)
Bug 648407 Allow folding of NSPR, NSS and sqlite library (should be considered for SeaMonkey, too)

Comment 2

[Frank Wein [:mcsmurf]]

Attachment: Patch v2

Added Bug 767944 (quota handling of integrated storage)

Comment 3

[Frank Wein [:mcsmurf]]

Landed patch as bustage fix (after all I think quite a few tests are broken by missing files): https://hg.mozilla.org/comm-central/rev/56d6207a6bf5 I also included the dom_gamepad.xpt change from Bug 858639

Comment 4

[Philip Chee]

Other possible packaging:

Package captivedetect.xpt
(From Bug 752982 - Part 1, implement captive portal detection service)

Bug 604039 - Add DOM Gamepad APIs

Bug 854468 - Part 2: Package command line recording code

Include AppProtocolHandler in desktop Firefox packages (bug 850421)
This allows the JavaScript debugger to properly present script URLs when remotely debugging Firefox OS.

... optional? ...
Bug 808219 - Firefox Health Reporter service
Bug 828829 - Refactor Health Report policy out of services/healthreport.
Bug 830626 - Add HealthReportComponents.manifest to package manifest.

Package PageThumbs.jsm (from  Bug 811548 - Move PageThumbs.jsm)

Comment 5

[Philip Chee]

Comment on attachment 738402 [details] [diff] [review]
Patch v2

rs=me :P

Comment 6

[Frank Wein [:mcsmurf]]

Attachment: comm-aurora version of Patch

[Approval Request Comment]
Regression caused by (bug #): Various new files added by mozilla-central
User impact if declined: Broken tests on comm-aurora tree, possibly also broken interfaces (as in code interfaces)
Testing completed (on m-c, etc.): More tests pass than before
Risk to taking this patch (and alternatives if risky): I think rather low risk, but hard to tell
String changes made by this patch: -

Comment 7

[Frank Wein [:mcsmurf]]

Actually we would also need to port the MOZ_GAMEPAD configure.in changes to comm-aurora, too :/ (was not required for comm-central as the comm-central configure.in system fixed this via Bug 846540).

Comment 8

[Frank Wein [:mcsmurf]]

(In reply to Philip Chee from comment #4)
> Package PageThumbs.jsm (from  Bug 811548 - Move PageThumbs.jsm)

For reference: PageThumbs.jsm is in modules/, that directory already gets packaged. What does net get packaged is PageThumbsProtocol.js and BrowserPageThumbs.manifest. Currently a few page thumb tests fail, but that is because the heads.js file for these tests imports a Firefox-only file:
Cu.import("resource:///modules/sessionstore/SessionStore.jsm", tmp);

Comment 9

[Frank Wein [:mcsmurf]]

Comment on attachment 739312 [details] [diff] [review]
comm-aurora version of Patch

Pushed to comm-aurora: https://hg.mozilla.org/releases/comm-aurora/rev/35b2907e98c3

Comment 10

[Frank Wein [:mcsmurf]]

Attachment: comm-aurora patch, part 2

It turned out dom_webspeech.xpt was missing in the aurora patch, on comm-central dom_webspeech.xpt does not exist anymore, it has another name there. And in Bug 863672 I actually ported the MOZ_WEBSPEECH configure.in changes for this patch... landing this with original review and approval as it basically should have belonged to that patch :)

Comment 11

[Frank Wein [:mcsmurf]]

Comment on attachment 747321 [details] [diff] [review]
comm-aurora patch, part 2

Pushed: https://hg.mozilla.org/releases/comm-aurora/rev/6f3e04b408ba

Comment 12

[Serge Gautherie (:sgautherie)]

(In reply to Frank Wein [:mcsmurf] from comment #2)
> Created attachment 738402 [details] [diff] [review]
> Patch v2

Isn't this patch missing its related part in
http://mxr.mozilla.org/comm-central/source/suite/installer/removed-files.in
?

Comment 13

[Frank Wein [:mcsmurf]]

Only when we decide to actually define MOZ_FOLD_LIBS... ;) good catch, I forgot about that. I'll write a patch to fix this. And also file a bug to possibly define this then if everything is working.

Comment 14

[Frank Wein [:mcsmurf]]

Attachment: Fix removed-files.in

Comment 15

[Frank Wein [:mcsmurf]]

Comment on attachment 795194 [details] [diff] [review]
Fix removed-files.in

Pushed: https://hg.mozilla.org/comm-central/rev/8ffd4465dc50
Pushed to aurora: https://hg.mozilla.org/releases/comm-aurora/rev/e1a3449c4048
Pushed to beta: https://hg.mozilla.org/releases/comm-beta/rev/486eb9b8cd30

Comment 16

[Frank Wein [:mcsmurf]]

Closing this bug now, if other package issues appear, we can open new bugs for this (I won't this to become some kind of meta-bug :).

Comment 17

[Serge Gautherie (:sgautherie)]

Comment on attachment 795194 [details] [diff] [review]
Fix removed-files.in

Review of attachment 795194 [details] [diff] [review]:
-----------------------------------------------------------------

Yes, and NavigatorPropertyHelper.js should be added to MOZ_OMNIJAR case.

::: suite/installer/removed-files.in
@@ +325,5 @@
> +@DLL_PREFIX@plc4@DLL_SUFFIX@
> +@DLL_PREFIX@ssl3@DLL_SUFFIX@
> +@DLL_PREFIX@smime3@DLL_SUFFIX@
> +@DLL_PREFIX@nssutil3@DLL_SUFFIX@
> +@DLL_PREFIX@mozsqlite3@DLL_SUFFIX@

Nit: I would have liked them to be alpha. sorted. Next time...

Comment 18

[Frank Wein [:mcsmurf]]

Serge: At least my opinion here is that installer manifest/removed-files.in only needs to support the default build config as used by the releases. And in this case there is no need to add NavigatorPropertyHelper.js to the removed-files.in as we build with omnijar for quite some time now. So I'm calling this fixed.