The default bug view has changed. See this FAQ.

Build failure in nsMsgStatusFeedback.cpp: "error: 'class nsIXULBrowserWindow' has no member named 'SetJSDefaultStatus'"

RESOLVED FIXED in Thunderbird 23.0

Status

MailNews Core
Backend
--
blocker
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: mcsmurf, Assigned: neil@parkwaycc.co.uk)

Tracking

({regression})

Trunk
Thunderbird 23.0
regression

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

4 years ago
Since Bug 862917 landed on mozilla-central, the Thunderbird and SeaMonkey builds fail with this error:
../../../../mailnews/base/src/nsMsgStatusFeedback.cpp: In member function 'virtual nsresult nsMsgStatusFeedback::SetStatusString(const nsAString_internal&)':
../../../../mailnews/base/src/nsMsgStatusFeedback.cpp:202:23: error: 'class nsIXULBrowserWindow' has no member named 'SetJSDefaultStatus'
make[8]: *** [nsMsgStatusFeedback.o] Error 1

I'm not really sure how to fix this.
(Reporter)

Updated

4 years ago
OS: Windows 8 → All
Hardware: x86_64 → All

Comment 1

4 years ago
q.v.
  Bug 862917 - Remove window.defaultStatus.
  Bug 842017 - Remove broken support for displaying window.status / window.defaultStatus.
  Bug 862540 - window.status can no longer be set to anything, ever.
  Bug 863339 - remove unneeded code that supports setting window.status.

> I'm not really sure how to fix this.
Dunno. If Bug 863339 lands then I suppose we could replace "SetJSDefaultStatus" with "SetOverLink"
The default status is just a fallback for if we're not displaying any status text. We should be able to write some code to take account for that and just replace what was there I believe.

I'm not going to get time for this over the next week, though you might be able to ping me on irc if you want ideas. This code has felt a bit messy in the past, so a tidy up wouldn't hurt.
Or we could restore nsIXULBrowserWindow::SetJSDefaultStatus, if it actually has a consumer and an implementation in Thunderbird...
(Assignee)

Comment 4

4 years ago
I think we can work around this by renaming the JS method name to setStatusString, which will allow us to call it on the nsIMsgStatusFeedback interface. (But my build is busted right now for other reasons which is why I don't have a patch ready yet.)
(Assignee)

Comment 5

4 years ago
Created attachment 740689 [details] [diff] [review]
Possible patch
(Assignee)

Comment 6

4 years ago
Comment on attachment 740689 [details] [diff] [review]
Possible patch

(Autocomplete fail...)
Attachment #740689 - Attachment description: Poss → Possible patch

Comment 7

4 years ago
Comment on attachment 740689 [details] [diff] [review]
Possible patch

WORKSFORME. f=Ratty
Attachment #740689 - Flags: feedback+

Comment 8

4 years ago
A build with Possible patch shows a non-stopping progress bar on MailNews. A subsequent build without this patch, instead with a backout of the patch of Bug 864256, does not show this unpleasant behavior.

SM Linux x86_64, Modern

Comment 9

4 years ago
As a check yet another build with Proposed patch. The progress bar in MailNews again doesn't stop to spin.

Comment 10

4 years ago
(In reply to Hartmut Figge from comment #9)
> As a check yet another build with Proposed patch. The progress bar in
> MailNews again doesn't stop to spin.

Probably due to
Error: ReferenceError: defaultStatus is not defined
Source File: chrome://messenger/content/mailWindow.js
Line: 388
(Assignee)

Comment 11

4 years ago
(In reply to Hartmut Figge from comment #10)
> (In reply to Hartmut Figge from comment #9)
> > As a check yet another build with Proposed patch. The progress bar in
> > MailNews again doesn't stop to spin.
> 
> Probably due to
> Error: ReferenceError: defaultStatus is not defined
> Source File: chrome://messenger/content/mailWindow.js
> Line: 388

Ah, that must have been accidentally using window.defaultStatus which was also removed as part of bug 862917...

Comment 12

4 years ago
That reminds me of the C&P error in comment 8. Should have been 'backout of the patch of Bug 862917'. Sigh.

Comment 13

4 years ago
> Ah, that must have been accidentally using window.defaultStatus which was also removed
> as part of bug 862917...
I wonder if Bienvenu meant to use "myDefaultStatus" instead in Bug 181627

http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/mailnews/base/resources/content/mailWindow.js&rev=1.100.2.6&mark=426#418
(Assignee)

Comment 14

4 years ago
Created attachment 742083 [details] [diff] [review]
Proposed patch

Seems reasonable.
Assignee: nobody → neil
Attachment #740689 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #742083 - Flags: feedback?

Comment 15

4 years ago
(In reply to neil@parkwaycc.co.uk from comment #14)
> Created attachment 742083 [details] [diff] [review]

WFM on SM Linux x86_64
(Reporter)

Comment 16

4 years ago
Comment on attachment 742083 [details] [diff] [review]
Proposed patch

Tested the patch locally, status bar updates seem to work fine, progress bar also works fine. No errors are visible in JS Console.
Attachment #742083 - Flags: feedback? → feedback+
(Assignee)

Updated

4 years ago
Attachment #742083 - Flags: review?(mbanner)

Comment 17

4 years ago
TB builds OK as well:
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:23.0) Gecko/20100101 Thunderbird/23.0a1 ID:20130426174337 CSet: 3267f9ecf52c
Comment on attachment 742083 [details] [diff] [review]
Proposed patch

Review of attachment 742083 [details] [diff] [review]:
-----------------------------------------------------------------

I can't test this at the moment, but given others have, and the code looks fine, r=me.
Attachment #742083 - Flags: review?(mbanner) → review+
https://hg.mozilla.org/comm-central/rev/dabe938d0e09
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 23.0
You need to log in before you can comment on or make changes to this bug.