Closed Bug 863379 Opened 9 years ago Closed 9 years ago

Update tab counter icon

Categories

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

x86
macOS
defect
Not set
normal

Tracking

(firefox23 verified)

VERIFIED FIXED
Firefox 23
Tracking Status
firefox23 --- verified

People

(Reporter: ibarlow, Assigned: sriram)

References

Details

(Whiteboard: ui-hackathon)

Attachments

(3 files)

Attached file icon assets
The current number+arrow doesn't work very well with the new single colour tab design. This new icon does a better job at communicating what the number is associated with. 

It also simplifies our lives since we no longer have the "which way does the arrow need to point" problem. 

The number inside the icon should be Roboto Bold, 12sp, #43484e, and should be kerned a little tighter than normal if possible.
Blocks: 817675
Oh, this is what it should look like btw http://cl.ly/image/2u123j1W130m
^. That is lovely.
(In reply to Aaron Train [:aaronmt] from comment #2)
> ^. That is lovely.

agreed
Attached patch PatchSplinter Review
Oooooh. So pretty icon!
Note: This patch doesn't fix the landscape files as we are filling them in bug 861138
Attachment #739306 - Flags: review?(mark.finkle)
This adds a heart beat like animation. Old value shrinks to 80%, and new value expands from 80% to 100%.
Depends on: 863828
Let's land this asap and try to uplift it with the rest of the new 1-colour tab button work. 

I filed bug 863828 to finish up the tab increment transition that should accompany it.
No longer depends on: 863828
Depends on: 863828
Whiteboard: ui-hackathon
Comment on attachment 739306 [details] [diff] [review]
Patch

I saw an early screenshot of this patch in action. The number seemed to be overlayed a bit "high" in the image. Please verify that the number is positioned nicely.
Attachment #739306 - Flags: review?(mark.finkle) → review+
Screenshot?
FYI: I rebases sriram's patch to account for the toolbar changes done in bug 858687. I'll wait until the patches for bug 858687 land in m-c before pushing it just to avoid a potential backout-fest.
https://hg.mozilla.org/mozilla-central/rev/9df37c60263f
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 23
Status: RESOLVED → VERIFIED
Depends on: 867242
I'm sorry for being late but I find this new count too small to read (for my eyes, at least). I just filed a bug yesterday to complain about that : https://bugzilla.mozilla.org/show_bug.cgi?id=868538
Blocks: 868538
No longer blocks: 868538
Depends on: 868538
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.