863379 - Update tab counter icon

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

Description

[Ian Barlow (:ibarlow)]

Attachment: icon assets

The current number+arrow doesn't work very well with the new single colour tab design. This new icon does a better job at communicating what the number is associated with. 

It also simplifies our lives since we no longer have the "which way does the arrow need to point" problem. 

The number inside the icon should be Roboto Bold, 12sp, #43484e, and should be kerned a little tighter than normal if possible.

Comment 1

[Ian Barlow (:ibarlow)]

Oh, this is what it should look like btw http://cl.ly/image/2u123j1W130m

Comment 2

[Aaron Train [:aaronmt]]

^. That is lovely.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Aaron Train [:aaronmt] from comment #2)
> ^. That is lovely.

agreed

Comment 4

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch

Oooooh. So pretty icon!
Note: This patch doesn't fix the landscape files as we are filling them in bug 861138

Comment 5

[Sriram Ramasubramanian [:sriram]]

Attachment: WIP: Heart beat animation

This adds a heart beat like animation. Old value shrinks to 80%, and new value expands from 80% to 100%.

Comment 6

[Ian Barlow (:ibarlow)]

Let's land this asap and try to uplift it with the rest of the new 1-colour tab button work. 

I filed bug 863828 to finish up the tab increment transition that should accompany it.

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 739306 [details] [diff] [review]
Patch

I saw an early screenshot of this patch in action. The number seemed to be overlayed a bit "high" in the image. Please verify that the number is positioned nicely.

Comment 8

[Ian Barlow (:ibarlow)]

Screenshot?

Comment 9

[Lucas Rocha (:lucasr)]

FYI: I rebases sriram's patch to account for the toolbar changes done in bug 858687. I'll wait until the patches for bug 858687 land in m-c before pushing it just to avoid a potential backout-fest.

Comment 10

[Lucas Rocha (:lucasr)]

Pushed: https://hg.mozilla.org/integration/mozilla-inbound/rev/9df37c60263f

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9df37c60263f

Comment 12

[Hervé Renault]

I'm sorry for being late but I find this new count too small to read (for my eyes, at least). I just filed a bug yesterday to complain about that : https://bugzilla.mozilla.org/show_bug.cgi?id=868538