864251 - Link to update history from about:support

Status: RESOLVED FIXED

(Toolkit :: General, defect)

Description

[Geoff Lankow (:darktrojan)]

It might be useful to have the date of the most recent update and a link to the update history window in about:support.

Comment 1

[Robert Strong (they/them - no direct email)]

All of the code that would need to be added to accomplish this would be in Firefox code and not app update so moving to the correct product and component.

Comment 2

[Robert Strong (they/them - no direct email)]

Correct Product anyway

Comment 3

[Drew Willcoxon :adw]

Geoff, was there a specific reason you filed this?  Like, when and to whom would it be useful?

about:support/Troubleshoot.jsm lives in toolkit, so moving back there.

Comment 4

[Geoff Lankow (:darktrojan)]

No particular reason, it's just too hard to get to IMO.

Firefox button > Preferences > Advanced > Update > Show Update History
vs
about:support > Show Update History

Comment 6

[Geoff Lankow (:darktrojan)]

Attachment: v1

Adds a 'Show Update History' button to the version row. I was going to add "last updated 3 days ago" style text but I don't think it's worth it.

Comment 7

[Drew Willcoxon :adw]

Comment on attachment 753195 [details] [diff] [review]
v1

Review of attachment 753195 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the patch.  If you click "Copy text to clipboard" you'll see that "Show Update History" is included in the copy, but it shouldn't be.  That's not so easy to fix: Serializer.prototype._serializeTable assumes that you want to copy everything in a table row.  You could modify _serializeTable to call _serializeElement.  Then you could put class="no-copy" on the button and it wouldn't be copied.

But you could avoid the problem altogether by making Show Update History its own row in the table and adding no-copy to the tr, which _serializeTable currently recognizes.  I think that might look better anyway.

::: toolkit/content/aboutSupport.js
@@ +505,5 @@
>  }
>  
> +function showUpdates() {
> +  var prompter = Components.classes["@mozilla.org/updates/update-prompt;1"]
> +                           .createInstance(Components.interfaces.nsIUpdatePrompt);

Please use Cc instead of Components.classes and Ci instead of Components.interfaces.

Comment 8

[Geoff Lankow (:darktrojan)]

Attachment: v2

> If you click "Copy text to clipboard" you'll see that
> "Show Update History" is included in the copy, but it shouldn't be.

I knew there was something else I was going to check!

Comment 9

[Drew Willcoxon :adw]

Comment on attachment 753556 [details] [diff] [review]
v2

Review of attachment 753556 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/content/aboutSupport.js
@@ +504,4 @@
>    new nsLocalFile(profileDir).reveal();
>  }
>  
> +function showUpdates() {

Please name this function showUpdateHistory.

::: toolkit/content/aboutSupport.xhtml
@@ +85,5 @@
> +            <th class="column">
> +              &aboutSupport.appBasicsUpdateHistory;
> +            </th>
> +
> +            <td id="version-box">

I think you accidentally left this ID here, right?  The td that contains the version string has this ID already.

::: toolkit/locales/en-US/chrome/global/aboutSupport.dtd
@@ +21,5 @@
>  <!ENTITY aboutSupport.appBasicsName "Name">
>  <!ENTITY aboutSupport.appBasicsVersion "Version">
>  
> +<!ENTITY aboutSupport.appBasicsUpdateHistory "Update History">
> +<!ENTITY aboutSupport.appBasicsShowUpdateHistory "Show Update History">

Please add a "LOCALIZATION NOTE" that "Update" in both of these strings is a noun and not a verb.

Comment 10

[Geoff Lankow (:darktrojan)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d1b9087dd689

Comment 11

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/d1b9087dd689