864832 - Get rid of nsSVGUtils::InvalidateBounds and just use nsSVGEffects::InvalidateRenderingObservers where DLBI is working

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Jonathan Watt [:jwatt]]

We can get rid of nsSVGUtils::InvalidateBounds and just use nsSVGEffects::InvalidateRenderingObservers where DLBI is working due to nsSVGUtils::ScheduleReflowSVG calls.

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: patch

In the patched locations, the nsSVGUtils::ScheduleReflowSVG calls make sure that DLBI will be scheduled to run.

I've restructured some of the code into separate if-else blocks so as to only make the switch for non-transform cases. That partly takes some of that splitting from bug 839865, where the transform cases still need to be worked on.

Comment 2

[Robert Longson [:longsonr]]

When we change the rotate attribute on a text element isn't that more like a translation modification (that needs a bounds update) than a location change? We're not going to get artifacts if we rotate say a capital I?

Comment 3

[Jonathan Watt [:jwatt]]

The nsSVGUtils::ScheduleReflowSVG calls should take care of that.

Comment 4

[Jonathan Watt [:jwatt]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/96c350f2c64a

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/96c350f2c64a