Closed Bug 865246 Opened 7 years ago Closed 7 years ago

Implement the processing for BiquadFilterNode

Categories

(Core :: Web Audio, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla23

People

(Reporter: ehsan, Assigned: ehsan)

References

Details

Attachments

(5 files, 1 obsolete file)

No description provided.
Assignee: nobody → ehsan
Status: NEW → ASSIGNED
Attachment #742592 - Flags: review?(paul)
Blocks: 866442
(Forgot to introduce mDetune to the cycle collector)
Attachment #742598 - Attachment is obsolete: true
Attachment #742598 - Flags: review?(paul)
Attachment #742755 - Flags: review?(paul)
Attachment #742592 - Flags: review?(paul) → review+
Attachment #742596 - Flags: review?(paul) → review+
Attachment #742755 - Flags: review?(paul) → review+
Attachment #742599 - Flags: review?(paul) → review+
Attachment #742600 - Flags: review?(paul) → review+
I'm wondering how to test this in a meaningful manner. I'm thinking about a number of generated sines, with biquads set in a way that the RMS level of the output would be well known, considering the filter frequency and slope.

Actually, we can test this node using the AnalyserNode, but first, we need to write tests for the AnalyserNode. Something based on generated sines would do the job, I guess, but I'm going to talk to people who know this stuff to make sure.
Sounds good, please file a bug once you come up with a testing plan for either of these nodes.  :-)
Mass moving Web Audio bugs to the Web Audio component.  Filter on duckityduck.
Component: Video/Audio → Web Audio
Blocks: 924286
Blocks: 924288
You need to log in before you can comment on or make changes to this bug.