865246 - Implement the processing for BiquadFilterNode

Status: RESOLVED FIXED

(Core :: Web Audio, defect)

Comment 1

[(no longer active)]

Attachment: Part 1: Import the Biquad processing implementation from Blink

Comment 2

[(no longer active)]

Attachment: Part 2: Add the Biquad processing implementation to the build system

Comment 3

[(no longer active)]

Attachment: Part 3: Update the BiquadFilterNode IDL to match the current spec

Comment 4

[(no longer active)]

Attachment: Part 4: Send the changes in the type parameter to the stream

Comment 5

[(no longer active)]

Attachment: Part 5: Implement BiquadFilterNode's processing based on the Blink implementation

Comment 6

[(no longer active)]

Demo/testcase: http://people.mozilla.org/~eakhgari/webaudio/biquad.html

Comment 7

[(no longer active)]

Attachment: Part 3: Update the BiquadFilterNode IDL to match the current spec

(Forgot to introduce mDetune to the cycle collector)

Comment 8

[Paul Adenot (:padenot)]

I'm wondering how to test this in a meaningful manner. I'm thinking about a number of generated sines, with biquads set in a way that the RMS level of the output would be well known, considering the filter frequency and slope.

Actually, we can test this node using the AnalyserNode, but first, we need to write tests for the AnalyserNode. Something based on generated sines would do the job, I guess, but I'm going to talk to people who know this stuff to make sure.

Comment 9

[(no longer active)]

Sounds good, please file a bug once you come up with a testing plan for either of these nodes.  :-)

Comment 10

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/752f587eeddc
https://hg.mozilla.org/integration/mozilla-inbound/rev/d173019355d0
https://hg.mozilla.org/integration/mozilla-inbound/rev/e6327ce28b30
https://hg.mozilla.org/integration/mozilla-inbound/rev/eb46dc93b5e0
https://hg.mozilla.org/integration/mozilla-inbound/rev/35360afebda3

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/752f587eeddc
https://hg.mozilla.org/mozilla-central/rev/d173019355d0
https://hg.mozilla.org/mozilla-central/rev/e6327ce28b30
https://hg.mozilla.org/mozilla-central/rev/eb46dc93b5e0
https://hg.mozilla.org/mozilla-central/rev/35360afebda3

Comment 12

[(no longer active)]

Mass moving Web Audio bugs to the Web Audio component.  Filter on duckityduck.