866563 - [Buri][Homescreen]Continuously drag APP to hotseat,hotseat will be freeze.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect, P2)

Description

[sync-1]

+++ This bug was initially created as a clone of Bug #446351 +++
 
 Created an attachment (id=398725)
 picture
 
 DEFECT DESCRIPTION:
 [Homescreen]Continuously drag APP to hotseat,hotseat will be freeze.
 
  REPRODUCING PROCEDURES:
    Long press one APP to activate the move mode,drag down some APP to hotseat,sometimes the APP and the hotseat will be freeze.->ko
    Comment:Only restart will be ok.If press home key,idle screen is normal.
  It is beeter to remove the APP in hotseat first,then you can add more to it.
 
  EXPECTED BEHAVIOUR:
 No freeze.
 
  ASSOCIATE SPECIFICATION:
 
  TEST PLAN REFERENCE:
 B2G-5640
 
  TOOLS AND PLATFORMS USED:
 
  USER IMPACT:
 
  REPRODUCING RATE:
 1/8
 
  For FT PR, Please list reference mobile's behavior:
 
 ++++++++++ end of initial bug #446351 description ++++++++++
 
 
 
 CONTACT INFO (Name,Phone number):
 
  DEFECT DESCRIPTION:
 
  REPRODUCING PROCEDURES:
 
  EXPECTED BEHAVIOUR:
 
  ASSOCIATE SPECIFICATION:
 
  TEST PLAN REFERENCE:
 
  TOOLS AND PLATFORMS USED:
 
  USER IMPACT:
 
  REPRODUCING RATE:
 
  For FT PR, Please list reference mobile's behavior:

Comment 1

[sync-1]

Clone from brother

Comment 2

[sync-1]

Attachment: picture

Clone from brother

Comment 3

[sync-1]

Clone from brother

Comment 4

[sync-1]

Attachment: logcat

Clone from brother

Comment 5

[Cristian Rodriguez (:crdlc)]

Please, what does hotseat mean? Thanks

Comment 6

[sync-1]

(In reply to comment #1)
 > Comment from Mozilla:Please, what does hotseat mean? Thanks
 > 
 
 when drag the icon to the dock,sometime the icon will stop near the dock.

Comment 7

[Cristian Rodriguez (:crdlc)]

I cannot reproduce it sorry

Comment 8

[Cyong]

(In reply to Cristian Rodriguez (a remontar!) from comment #7)
> I cannot reproduce it sorry

It's a little difficult to reproduce it. 
When I first get this bug,I tried to drag lots of icons in and out of dock,with several minutes,it was reproduced.

Comment 9

[xiupinglong]

(In reply to Cristian Rodriguez de la Cruz (:crdlc) from comment #7)
> I cannot reproduce it sorry

Hi,

It been reproduced when you drag icon quickly and drag lots of icons in and out of dock. 
When this situation happened, the bellow code in homescreen->js->dragdrop.js have not been  executed. 
    DragLeaveEventManager.send(page, function(done) {
      draggableIcon.onDragStop(callback);
      done();
    }, true);
So the drag element which is cloned has not been remove from the homescreen body. And then you can see it in homescreen.

Comment 10

[Cristian Rodriguez (:crdlc)]

Please someone from QA could help us? I cannot reproduce it. Thanks

Comment 11

[bhavana bajaj [:bajaj]]

Triage is waiting for qa feedback to see if this is reproducible.

Comment 12

[Marcia Knous [:marcia]]

Can we please clarify what the "hotseat" is? I am assuming it is the dock.

Comment 13

[Angela Hubenya]

I was able to reproduce this issue 1/5 on the Buri device using the com ril. 
A couple applications got grouped near the dock as I was trying to drag them in there. The only way I was able to separate the applications was by restarting my device. 

Buri Build ID: 20130710070204
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/5b34e0cda635
Gaia: 61453c4d32beb15a33ec91b2e740e96e5ce45759
Platform Version: 18.1
RIL Version: 01.01.00.019.157

Comment 14

[Cristian Rodriguez (:crdlc)]

Attachment: Patch to ensure dragend event

Hi Angela, I don't have a Buri device, could you apply my patch in your Gaia's branch and tell me if the bug disappears? I guess firmly that it could fix the problem although I cannot test it on that device. 

Thanks a lot

Comment 16

[Cristian Rodriguez (:crdlc)]

Hello, could someone that is able to reproduce the issue check this patch? Thanks

Comment 17

[Wayne Chang [:wchang]]

Triage- Leo-'ing for now, please renom if reproduced on leo/v1-train and provide specific build information.

Comment 18

[John Hammink]

This still repros on my leo build:  

Gecko  http://hg.mozilla.org/releases/mozilla-b2g18/rev/282b5c37cf8d
Gaia   e2ef782119b7e79fc62c48d36f0c36909d982988
BuildID 20130712070210
Version 18.0

Comment 19

[Cristian Rodriguez (:crdlc)]

Hi John, 

  I don't have a leo device and I cannot reproduce it on my Unagi device. I implemented a fallback mechanism in order to exit from drag state in all cases theoretically. Could you test the patch in your leo device? It will be a great help for me.

Thanks a lot

Comment 20

[Alex Keybl [:akeybl]]

This either needs to occur with frequency, or have exact STR. Would also be great to understand if the volume of this issue has increased since 1.0.

Comment 21

[Dietrich Ayala (:dietrich)]

Please renominate when there's data for triage to make a decision with.

Comment 22

[Jason Smith [:jsmith]]

(In reply to Dietrich Ayala (:dietrich) from comment #21)
> Please renominate when there's data for triage to make a decision with.

I'm assuming you meant to minus here.

Comment 23

[Jason Smith [:jsmith]]

QA Wanted - we need clearer STR or proof that the attached patch worked for someone that can reproduce it.

Comment 24

[John Hammink]

Not set up to build here, unfortunately.   Deferring to nhirata.

Comment 25

[xiupinglong]

I have tested it with this patch. It is still not ok for me on my leo device.
 
 AU_LINUX_GECKO_ICS_STRAWBERRY.01.01.00.019.152
  Firefox os  v1.1
  Mozilla build ID:20130702230206

Comment 26

[Cristian Rodriguez (:crdlc)]

Attachment: Ensuring dragend & transitionend for draggable icon events with tons of logs

Comment 27

[Cristian Rodriguez (:crdlc)]

Hi Xiupinglong,

   If you can test my new patch :), it will be a pleasure for me and a great help! I've added a new fix and the most important: tons of logs. In that case, if you can reproduce the problem again, you could attach me the traces in order to know where it crashes. Please stop when the draggable icons fails.

Thanks a lot for you help

Cheers

Comment 28

[Askeing Yen[:askeing][:fyen]]

(In reply to Jason Smith [:jsmith] from comment #23)
> QA Wanted - we need clearer STR or proof that the attached patch worked for
> someone that can reproduce it.

It seems like the dup of Bug 878422.
If so, then https://bugzilla.mozilla.org/show_bug.cgi?id=878422#c45 has the STR video.

Comment 29

[xiupinglong]

Attachment: adb logcat

Hi,
It is still not ok on my leo device. The adb log you can find in the attachment.

Comment 30

[Cristian Rodriguez (:crdlc)]

Attachment: Patch v3 - Ensuring dragend & transitionend for draggable icon events with tons of logs

Please could you test it again?

and better use: adb logcat | grep GeckoConsole

Thanks a lot

Comment 31

[Cristian Rodriguez (:crdlc)]

I am crossing my fingers right now ;) waiting for your results, thanks a lot!!!!

Comment 32

[Alex Keybl [:akeybl]]

comment 20's request has not yet been fulfilled. needs more info.

Comment 33

[xiupinglong]

Attachment: bug866563_log.txt

Hi,
I try to drag icons to the dock and remove them from the dock quickly and frequently, 2 or 3 minutes after, this issue still happen. The log you can see in the attachment. 
"E/GeckoConsole(  416): [JavaScript Error: "NotFoundError: Node was not found" {file: "app://homescreen.gaiamobile.org/js/page.js" line: 509}]
" 
Corresponding the code 
"document.body.removeChild(draggableElem);"

Comment 34

[Walter Chen[:ypwalter][:wachen]]

Per comment 28, I think this issue is the same as Bug 878422.

Cristian Rodriguez de la Cruz,
Do you remember that you had a hard time solving this?
The patch in Bug 878422 should solve this issue.
(The patch of bug 878422 is in master & v1-train, but not in v101)

Comment 35

[Cristian Rodriguez (:crdlc)]

> Do you remember that you had a hard time solving this?

I remember it but what do you mean? AFAIK it was fixed bug 878422, comment 52. This one was reproducible in all devices as you know but the current bug is impossible for me to reproduce in my Unagi. And, per comment 33, only after 2 or 3 minutes moving icons to dock quickly, it fails on Buri. 

> The patch in Bug 878422 should solve this issue.

Theoretically, it should, but it fails because sometimes some transitionend/animationend event is not performed so the chain of operations is broken and the bug happens. In this patch, I tried to implement fallbacks for the transitionend's callbacks

Comment 36

[Cristian Rodriguez (:crdlc)]

Attachment: Patch v4

Please, could you test it the "last time"? If it fails, could you record a video from the beginning in order to detect some pattern? Thanks a lot

Comment 37

[xiupinglong]

Attachment: new_log

Hi,

With your new patch, I have tried for 20 minutes, it happened one time. So I think nobody can move icon so long time. Then I have tried again for 20 minutes, but it not occur. So I can not record video. Sorry!

Comment 38

[Cristian Rodriguez (:crdlc)]

OK, thanks a lot, great news! Do you have logs? Regards

Comment 39

[xiupinglong]

(In reply to Cristian Rodriguez de la Cruz (:crdlc) from comment #38)
> OK, thanks a lot, great news! Do you have logs? Regards

Hi,

The logs in  attachment 778405 [details]. Thank you!

Comment 40

[Cristian Rodriguez (:crdlc)]

Attachment: Patch ONLY v1-train

Comment 41

[Cristian Rodriguez (:crdlc)]

Attachment: Patch for master

Comment 42

[Jason Smith [:jsmith]]

I'm pulling qawanted  since it looks like [e-mail] has a workflow right now to work with the assignee to test the patch.

Comment 43

[Cristian Rodriguez (:crdlc)]

Master:

https://github.com/mozilla-b2g/gaia/commit/edb1dea8b45238add44b199cf02c9b4ed808b767

While this pull request will not be on v1-train the bug is reproducible on Leo

https://github.com/mozilla-b2g/gaia/pull/11073

Comment 45

[Amelie Kong]

As the original Bug seems critical to us, I nominate it as leo?
Please consider.

Comment 46

[Wayne Chang [:wchang]]

Triage - leo+'ing this as bug is reproduced by multiple parties including triage partners since last triage.

Comment 47

[Cristian Rodriguez (:crdlc)]

v1-train:

https://github.com/mozilla-b2g/gaia/commit/c97b3e11acad10a757b00fdffb5caab54afb6fea

Comment 48

[sbogati]

Issue no longer repros on Leo.
Build ID: 20130729070226
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/8135299f3efd
Gaia: 7aaffc8ccb6cf7ddd1e97943c108f1cb9eae5de0
Platform Version: 18.1
RIL Version: 01.01.00.019.171
[Homescreen]Continuously drag APP to hot seat,hotseat does not freeze.

Comment 49

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

The need info was set for me to verify the patch.  Having said that the patch already landed before I could get to it.

It seems to be fixed.
see comment 48; I tested myself as well.