866950 - Errors from files loaded through loader.js not showing source in browser console

Status: RESOLVED FIXED

(DevTools :: Console, defect)

Description

[Rob Campbell [:rc] (:robcee)]

Fallout from bug 855914.

Error messages in files loaded through jetpack's loader are not showing source when clicking on the location.

e.g., [18:35:26.937] ReferenceError: console is not defined @ 
                resource://gre/modules/commonjs/toolkit/loader.js -> 
                resource:///modules/devtools/framework/toolbox.js:795

Comment 1

[Mihai Sucan [:msucan]]

How is this error logged? console.error() call or is it an nsIScriptError? What is the message source?

Comment 2

[Panos Astithas (he/him) [:past] (please ni?)]

Looks like an nsIScriptError to me. Here is how we treat these URLs in the debugger frontend:

http://mxr.mozilla.org/mozilla-central/source/browser/devtools/debugger/debugger-panes.js#104

Comment 3

[Mihai Sucan [:msucan]]

Investigated the problem. The |sourceName| holds " -> ". It seems we need to split on that, and always use the last item. Thanks Panos for the pointer to that code.

Comment 4

[Mihai Sucan [:msucan]]

This is probably not a regression. The Web/Browser Console never handled script errors with multiple sourceNames joined together with " -> ".

Comment 5

[Mihai Sucan [:msucan]]

Attachment: proposed patch

Straight-forward fix.

Try push: https://tbpl.mozilla.org/?tree=Try&rev=6c2b9c444d9b

Comment 6

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 756131 [details] [diff] [review]
proposed patch

Review of attachment 756131 [details] [diff] [review]:
-----------------------------------------------------------------

yes!

Comment 7

[Mihai Sucan [:msucan]]

Thanks!

Comment 8

[Panos Astithas (he/him) [:past] (please ni?)]

https://hg.mozilla.org/integration/fx-team/rev/c0054eccfbac

Comment 9

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/c0054eccfbac