867231 - MozActivity "open" with a blob should offer "save" button

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Gallery, defect)

Description

[Corey Frang [:gnarf]]

The gallery app should be offering a "Save" button for blob's opened by other applications.

Copying this part of the description from https://bugzilla.mozilla.org/show_bug.cgi?id=840059#c6 :

The image file is opened by the gallery, while the picture is viewed, the user has the option to "save" that content, if the user selects that option, a banner indicating the success/failure of the operation is shown when completed. If the user cancels the "view" operation, he is returned to the thread detail screen in SMS Application. All this code should be implemented by an activity (I suppose in the gallery).

Comment 1

[David Flanagan [:djf]]

Wireframes here: https://www.dropbox.com/s/vbxes8onsv58ir7/meta-pattern-previews.pdf

Comment 2

[David Flanagan [:djf]]

Work in progress patch is here: https://github.com/mozilla-b2g/gaia/pull/9549

It looks like there is a gecko bug, however: the gallery app crashes right after saving the file.  dhylands is investigating.

Comment 3

[David Flanagan [:djf]]

This bug is blocked on a gecko crash in bug 868625

Comment 4

[David Flanagan [:djf]]

Attachment: link to patch on github

Dominic,

This is a bug that the MMS team wants soon. For some reason they are not marking their bugs leo+, but they need to land soon to get into the v1.1 release.

This adds an optional Save button to the open activity for Gallery. MMS needs the same thing for Music and Video, so I've put some utilties in shared/js to make it easier for those apps.  

(The Music app is bug 867448. I'm happy to work on that one after this patch lands, but if you'd like to take it that's okay with me.)

Comment 5

[David Flanagan [:djf]]

Dominic,

Comment 3 says the bug is blocked by a crash. It turns out that if the blob passed to the view activity is from device storage, then saving it again causes a crash. But there is no crash when I test it with the new uitest in the pull request. So I think it is okay to review and land this Gaia patch now. When the gecko crash gets fixed, then the save feature will start working.

Comment 6

[Dominic Kuo [:dkuo]]

Comment on attachment 746731 [details]
link to patch on github

David,

I have encountered the gecko crash in bug 868625 which you mentioned in Comment 3, then I turned to test the uitest that you also added in this patch, that uitest works good and fits the requirement in the wireframes. After that I backed to test it with modified email app again, and found although it crashes but a broken file is saved, so I think the saving works are done in this patch and we can land this first to wait bug 868625 to be fixed.

Comment 7

[Dominic Kuo [:dkuo]]

David,

To speed up landing the save features for music and video, I think it would be great if we implement bug 867448 and bug 869292 in parallel, and we can even review the patches each other! how about that?

Comment 8

[David Flanagan [:djf]]

Dominic,

Sounds like a good idea. I'll take the video bug now and leave the music one to you.

Comment 9

[David Flanagan [:djf]]

Landed to gaia master: https://github.com/mozilla-b2g/gaia/commit/ad01e40314fb800493e3865912b107b96664836b

Comment 10

[David Flanagan [:djf]]

uplifted to v1-train: https://github.com/mozilla-b2g/gaia/commit/12f348ec283f5f395d860a2e89a68d9d4a48a3e8