[Music] Need to be able to save from the "open" activity window

RESOLVED FIXED

Status

Firefox OS
Gaia::Music
P1
normal
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: gnarf, Assigned: dkuo)

Tracking

({feature})

unspecified
x86
Mac OS X
feature
Dependency tree / graph
Bug Flags:
in-moztrap +

Firefox Tracking Flags

(blocking-b2g:leo+, b2g18 fixed, b2g18-v1.0.0 wontfix, b2g18-v1.0.1 wontfix)

Details

(URL)

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

5 years ago
To copy some text from bug 840056:

The audio file is opened by the media player, while the sound is played in the music player, the user has the option to "save" that content, if the user selects that option, a banner indicating the success/failure of the operation is shown when completed.
(Reporter)

Updated

5 years ago
Blocks: 840056
(Reporter)

Updated

5 years ago
Blocks: 840065
The fix for this bug will probably resemble the fix for bug 867231.  If you take this bug, please see the work I've done in that one.  In particular, my pull request in that bug includes useful utilities in shared/js/device_storage_utils.js  You'll almost certainly want to use those for this bug as well.

Updated

5 years ago
Depends on: 868625
This bug is blocked on a gecko crash in bug 868625. When that is fixed, I can probably take this one. But I haven't taken it yet in case someone else wants it.
does this cover audio and video, or just audio?
(Assignee)

Comment 4

5 years ago
I think I should be the someone else so I am taking it.
Assignee: nobody → dkuo
Summary: Need to be able to save from the "open" activity window → [Music] Need to be able to save from the "open" activity window
(Assignee)

Comment 5

5 years ago
The one for video is filed in Bug 869292, this one will cover audio only.
Blocks a blocker.
blocking-b2g: --- → leo+
Priority: -- → P1
Keywords: feature
(Assignee)

Comment 7

5 years ago
Created attachment 747484 [details]
add a save option to music app open activity

David,

This is the patch that implements the save funtion in open activity, I followed how gallery/video did and modified some parts base on the currect open acticity of music app. The major one is the workaround of bug 848723 casue it seems fixed to me so I removed it as well. And I also modified the metadata.js so our audio parser will be able to parse both file and blob without errors, that's becasue I heard that browser app might support save media files from web page and probably use open/view activity to achieve this.
Attachment #747484 - Flags: review?(dflanagan)
Comment on attachment 747484 [details]
add a save option to music app open activity

Dominic,

This is a good patch, but I'm giving r- because one of the uitests doesn't work right (it won't save without a .ogg extension on the filename).

There is also an unsed title variable that can be removed.

Because the MMS team wants this quickly, I'll modify your patch to make those two minor changes and land that.
Attachment #747484 - Flags: review?(dflanagan) → review-
Created attachment 747613 [details]
minor changes to Dominic's patch

Attaching a link to a new PR that fixes the merge commits and a couple of trivial bugs in Dominic's patch so that it is ready to land and giving an r+
Attachment #747484 - Attachment is obsolete: true
Attachment #747613 - Flags: review+
Landed on master: https://github.com/mozilla-b2g/gaia/commit/c00f94deb7325b024f37ca7ee0e7c51417ef2c87
Status: NEW → RESOLVED
Last Resolved: 5 years ago
status-b2g18: --- → affected
status-b2g18-v1.0.0: --- → wontfix
status-b2g18-v1.0.1: --- → wontfix
Resolution: --- → FIXED

Updated

5 years ago
Flags: in-moztrap?

Updated

5 years ago
Flags: in-moztrap? → in-moztrap+
QA Contact: amiller
You need to log in before you can comment on or make changes to this bug.